From 7506522f40352bfd49f0c3cb1bc3e9b8288445d6 Mon Sep 17 00:00:00 2001 From: "James Page james.page@ubuntu.com, Bernd Zeimetz" Date: Thu, 26 Aug 2021 09:36:49 +0100 Subject: [PATCH] Avoid overloading on 32 bit architectures Forwarded: no unsigned and size_t are equivalent on 32 bit architectures, so only define the size_t based overload of advance on 64 bit architectures. https://wiki.debian.org/ArchitectureSpecificsMemo Gbp-Pq: Name 32bit-avoid-overloading.patch --- src/include/buffer.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/include/buffer.h b/src/include/buffer.h index 774ca0522..ef94302de 100644 --- a/src/include/buffer.h +++ b/src/include/buffer.h @@ -737,7 +737,12 @@ inline namespace v14_2_0 { void advance(int o) = delete; void advance(unsigned o); + +// unsigned and size_t are equivalent on 32bit architectures. +// so casting is only needed when not on 32bit. +#if defined(UINTPTR_MAX) && UINTPTR_MAX > 0xffffffff void advance(size_t o) { advance(static_cast(o)); } +#endif void seek(unsigned o); char operator*() const; iterator_impl& operator++(); -- 2.30.2