From 72e038450d3d5de1a39f0cfa2d2b0f9b3d43c6c6 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 17 Feb 2017 18:03:58 +0000 Subject: [PATCH] x86/cpuid: Handle leaf 0x6 in guest_cpuid() The thermal/performance leaf was previously hidden from HVM guests, but fully visible to PV guests. Most of the leaf refers to MSR availability, and there is nothing an unprivileged PV guest can do with the information, so hide the leaf entirely. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich --- xen/arch/x86/cpuid.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/cpuid.c b/xen/arch/x86/cpuid.c index 78c786b4bc..2eab5de8ef 100644 --- a/xen/arch/x86/cpuid.c +++ b/xen/arch/x86/cpuid.c @@ -168,6 +168,7 @@ static void recalculate_misc(struct cpuid_policy *p) p->basic.apic_id = 0; /* Dynamic. */ p->basic.raw[0x5] = EMPTY_LEAF; /* MONITOR not exposed to guests. */ + p->basic.raw[0x6] = EMPTY_LEAF; /* Therm/Power not exposed to guests. */ p->basic.raw[0x8] = EMPTY_LEAF; p->basic.raw[0xc] = EMPTY_LEAF; @@ -650,8 +651,7 @@ static void pv_cpuid(uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res) *res = EMPTY_LEAF; break; - case 0x0 ... 0x5: - case 0x7 ... 0x9: + case 0x0 ... 0x9: case 0xc ... XSTATE_CPUID: case 0x80000000 ... 0xffffffff: ASSERT_UNREACHABLE(); @@ -685,8 +685,7 @@ static void hvm_cpuid(uint32_t leaf, uint32_t subleaf, struct cpuid_leaf *res) res->a = (res->a & ~0xff) | 3; break; - case 0x0 ... 0x5: - case 0x7 ... 0x9: + case 0x0 ... 0x9: case 0xc ... XSTATE_CPUID: case 0x80000000 ... 0xffffffff: ASSERT_UNREACHABLE(); @@ -746,7 +745,7 @@ void guest_cpuid(const struct vcpu *v, uint32_t leaf, goto legacy; case 0x0 ... 0x3: - case 0x5: + case 0x5 ... 0x6: case 0x8 ... 0x9: case 0xc: *res = p->basic.raw[leaf]; -- 2.30.2