From 6ec48cf41b6656c98148380f39010063e62628c5 Mon Sep 17 00:00:00 2001 From: Stefano Stabellini Date: Wed, 30 Apr 2014 16:06:24 +0100 Subject: [PATCH] libxl: introduce an option for disabling the non-O_DIRECT workaround Document and implement a new option that permits disk backends which would otherwise have to avoid O_DIRECT (because of the network memory lifetime bug) to use it anyway. This is: direct-io-safe in the xl domain disk config specification direct_io_safe in the libxl disk API direct-io-safe in the backend xenstore interface Add a reference to xen/include/public/io/blkif.h in docs/misc/vbd-interface.txt. Signed-off-by: Stefano Stabellini Signed-off-by: Ian Jackson Acked-by: Ian Campbell Tested-by: Felipe Franciosi --- docs/misc/vbd-interface.txt | 6 + docs/misc/xl-disk-configuration.txt | 38 ++ tools/libxl/libxl.c | 4 + tools/libxl/libxl.h | 7 + tools/libxl/libxl_types.idl | 1 + tools/libxl/libxlu_disk_l.c | 681 ++++++++++++++-------------- tools/libxl/libxlu_disk_l.h | 2 +- tools/libxl/libxlu_disk_l.l | 1 + xen/include/public/io/blkif.h | 22 + 9 files changed, 428 insertions(+), 334 deletions(-) diff --git a/docs/misc/vbd-interface.txt b/docs/misc/vbd-interface.txt index 3952e73b51..f873db0f70 100644 --- a/docs/misc/vbd-interface.txt +++ b/docs/misc/vbd-interface.txt @@ -125,3 +125,9 @@ because they directly map the bottom 8 bits of the xenstore integer directly to the Linux guest's device number and throw away the rest; they can crash due to minor number clashes. With these guests, the workaround is not to supply problematic combinations of devices. + + +Other frontend and backend options +---------------------------------- + +See xen/include/public/io/blkif.h for the full list of options. diff --git a/docs/misc/xl-disk-configuration.txt b/docs/misc/xl-disk-configuration.txt index cf22397ba4..11fee9a9b8 100644 --- a/docs/misc/xl-disk-configuration.txt +++ b/docs/misc/xl-disk-configuration.txt @@ -178,6 +178,44 @@ information to be interpreted by the executable program