From 6c19b02888c96982e2d0dba5fe72fee0aab728a2 Mon Sep 17 00:00:00 2001 From: Hannah von Reth Date: Mon, 2 Dec 2019 15:30:47 +0100 Subject: [PATCH] Disable http2 support for now Issue: #7610 --- src/libsync/accessmanager.cpp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/libsync/accessmanager.cpp b/src/libsync/accessmanager.cpp index 50107609e..87d435644 100644 --- a/src/libsync/accessmanager.cpp +++ b/src/libsync/accessmanager.cpp @@ -98,12 +98,8 @@ QNetworkReply *AccessManager::createRequest(QNetworkAccessManager::Operation op, #if QT_VERSION >= QT_VERSION_CHECK(5, 9, 4) // only enable HTTP2 with Qt 5.9.4 because old Qt have too many bugs (e.g. QTBUG-64359 is fixed in >= Qt 5.9.4) - - /* Disable http2 for now due to Qt bug but allow enabling it via env var, see: https://github.com/owncloud/client/pull/7620 - * and: https://github.com/nextcloud/desktop/pull/1806 - * Issue: https://github.com/nextcloud/desktop/issues/1503 - */ if (newRequest.url().scheme() == "https") { // Not for "http": QTBUG-61397 + // http2 seems to cause issues, as with our recommended server setup we don't support http2, disable it by default for now static const bool http2EnabledEnv = qEnvironmentVariableIntValue("OWNCLOUD_HTTP2_ENABLED") == 1; newRequest.setAttribute(QNetworkRequest::HTTP2AllowedAttribute, http2EnabledEnv); -- 2.30.2