From 6431d66aeb9f31b2760c553a96d79b738e20231a Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Fri, 7 Apr 2023 15:23:43 +0800 Subject: [PATCH] Remove unnecessary signalling response to start edit locally, just start it within the job Signed-off-by: Claudio Cambra --- src/gui/editlocallyjob.cpp | 1 + src/gui/editlocallymanager.cpp | 11 +++-------- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gui/editlocallyjob.cpp b/src/gui/editlocallyjob.cpp index cb652ba94..1f15e4ded 100644 --- a/src/gui/editlocallyjob.cpp +++ b/src/gui/editlocallyjob.cpp @@ -153,6 +153,7 @@ void EditLocallyJob::proceedWithSetup() Systray::instance()->destroyEditFileLocallyLoadingDialog(); Q_EMIT setupFinished(); + startEditLocally(); } void EditLocallyJob::findAfolderAndConstructPaths() diff --git a/src/gui/editlocallymanager.cpp b/src/gui/editlocallymanager.cpp index c301d4b42..cd6ade7d3 100644 --- a/src/gui/editlocallymanager.cpp +++ b/src/gui/editlocallymanager.cpp @@ -79,14 +79,9 @@ void EditLocallyManager::createJob(const QString &userId, _jobs.insert(token, job); const auto removeJob = [this, token] { _jobs.remove(token); }; - const auto setupJob = [job] { job->startEditLocally(); }; - - connect(job.data(), &EditLocallyJob::error, - this, removeJob); - connect(job.data(), &EditLocallyJob::finished, - this, removeJob); - connect(job.data(), &EditLocallyJob::setupFinished, - job.data(), setupJob); + + connect(job.data(), &EditLocallyJob::error, this, removeJob); + connect(job.data(), &EditLocallyJob::finished, this, removeJob); job->startSetup(); } -- 2.30.2