From 615367b5275a5b0123f1f1ee86c985fab234a5a4 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Thu, 25 Feb 2021 16:54:17 +0000 Subject: [PATCH] x86/dmop: Properly fail for PV guests The current code has an early exit for PV guests, but it returns 0 having done nothing. Fixes: 524a98c2ac5 ("public / x86: introduce __HYPERCALL_dm_op...") Signed-off-by: Andrew Cooper Reviewed-by: Ian Jackson Reviewed-by: Jan Beulich Release-Acked-by: Ian Jackson --- xen/arch/x86/hvm/dm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/hvm/dm.c b/xen/arch/x86/hvm/dm.c index 5bc172a5d4..612749442e 100644 --- a/xen/arch/x86/hvm/dm.c +++ b/xen/arch/x86/hvm/dm.c @@ -365,6 +365,7 @@ int dm_op(const struct dmop_args *op_args) if ( rc ) return rc; + rc = -EINVAL; if ( !is_hvm_domain(d) ) goto out; -- 2.30.2