From 5fa9cbb8057b000f7e47f1305408fc0865fa2c23 Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Mon, 19 Apr 2010 11:34:49 +0100 Subject: [PATCH] x86: Simplify freeze_domains() and thaw_domains(). Since they now run in idle-vcpu context, no care needs to be taken about pausing 'current'. Signed-off-by: Keir Fraser --- xen/arch/x86/acpi/power.c | 35 +++++++---------------------------- 1 file changed, 7 insertions(+), 28 deletions(-) diff --git a/xen/arch/x86/acpi/power.c b/xen/arch/x86/acpi/power.c index e6847b3e4f..9efae905c2 100644 --- a/xen/arch/x86/acpi/power.c +++ b/xen/arch/x86/acpi/power.c @@ -77,46 +77,25 @@ static void device_power_up(void) static void freeze_domains(void) { struct domain *d; - struct vcpu *v; rcu_read_lock(&domlist_read_lock); + /* + * Note that we iterate in order of domain-id. Hence we will pause dom0 + * first which is required for correctness (as only dom0 can add domains to + * the domain list). Otherwise we could miss concurrently-created domains. + */ for_each_domain ( d ) - { - switch ( d->domain_id ) - { - case 0: - for_each_vcpu ( d, v ) - if ( v != current ) - vcpu_pause(v); - break; - default: - domain_pause(d); - break; - } - } + domain_pause(d); rcu_read_unlock(&domlist_read_lock); } static void thaw_domains(void) { struct domain *d; - struct vcpu *v; rcu_read_lock(&domlist_read_lock); for_each_domain ( d ) - { - switch ( d->domain_id ) - { - case 0: - for_each_vcpu ( d, v ) - if ( v != current ) - vcpu_unpause(v); - break; - default: - domain_unpause(d); - break; - } - } + domain_unpause(d); rcu_read_unlock(&domlist_read_lock); } -- 2.30.2