From 5f81ebff71ae8637d34e23662cdc0e79a9bca8da Mon Sep 17 00:00:00 2001
From: Dirk Farin <dirk.farin@gmail.com>
Date: Fri, 1 Sep 2023 21:18:48 +0200
Subject: [PATCH] [PATCH] fix #418

Gbp-Pq: Name CVE-2023-43887.patch
---
 libde265/decctx.cc | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/libde265/decctx.cc b/libde265/decctx.cc
index 3eb5daa..0747c69 100644
--- a/libde265/decctx.cc
+++ b/libde265/decctx.cc
@@ -854,16 +854,17 @@ de265_error decoder_context::read_pps_NAL(bitreader& reader)
   std::shared_ptr<pic_parameter_set> new_pps = std::make_shared<pic_parameter_set>();
 
   bool success = new_pps->read(&reader,this);
+  if (!success) {
+    return DE265_WARNING_PPS_HEADER_INVALID;
+  }
 
   if (param_pps_headers_fd>=0) {
     new_pps->dump(param_pps_headers_fd);
   }
 
-  if (success) {
-    pps[ (int)new_pps->pic_parameter_set_id ] = new_pps;
-  }
+  pps[ (int)new_pps->pic_parameter_set_id ] = new_pps;
 
-  return success ? DE265_OK : DE265_WARNING_PPS_HEADER_INVALID;
+  return DE265_OK;
 }
 
 de265_error decoder_context::read_sei_NAL(bitreader& reader, bool suffix)
-- 
2.30.2