From 5be3f335e0d0dd1e449cdd23be3c37366c114b86 Mon Sep 17 00:00:00 2001 From: "Luis R. Rodriguez" Date: Thu, 17 Jul 2014 16:28:15 -0700 Subject: [PATCH] oxenstored: force FD_CLOEXEC with Unix.set_close_on_exec on LSB init Lets match the systemd active socket activation implementation and ensure that FD_CLOEXEC is set by usin Unix.set_close_on_exec. David notes oxenstored likely does not exec but there is no harm in being careful just in case things change in the future. Cc: David Scott Cc: Anil Madhavapeddy Cc: Ian Jackson Cc: Stefano Stabellini Cc: Ian Campbell Cc: Vincent Hanquez Signed-off-by: Luis R. Rodriguez Acked-by: Ian Campbell --- tools/ocaml/xenstored/utils.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/ocaml/xenstored/utils.ml b/tools/ocaml/xenstored/utils.ml index 0cfededb48..61321c619b 100644 --- a/tools/ocaml/xenstored/utils.ml +++ b/tools/ocaml/xenstored/utils.ml @@ -78,6 +78,7 @@ let create_regular_unix_socket name = Unixext.mkdir_rec (Filename.dirname name) 0o700; let sockaddr = Unix.ADDR_UNIX(name) in let sock = Unix.socket Unix.PF_UNIX Unix.SOCK_STREAM 0 in + Unix.set_close_on_exec sock; Unix.bind sock sockaddr; Unix.listen sock 1; sock -- 2.30.2