From 5bd600c1cd9783837ecb5c6fdf37790b2dd0e239 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9my=20Lal?= Date: Thu, 29 Aug 2024 10:25:23 +0200 Subject: [PATCH] do not use dns.ADDRCONFIG for localhost Last-Update: 2020-06-11 Bug-Debian: https://bugs.debian.org/962318 Forwarded: https://github.com/nodejs/node/issues/33816 it fails on IPv6-only systems. Setting it with libc fails on linux. https://github.com/nodejs/node/issues/33279 https://lists.debian.org/debian-devel/2023/12/msg00011.html Gbp-Pq: Topic deps Gbp-Pq: Name localhost-no-addrconfig.patch --- lib/net.js | 8 +------- test/sequential/sequential.status | 4 ++++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/lib/net.js b/lib/net.js index 6fe798e0f..a25bd32f6 100644 --- a/lib/net.js +++ b/lib/net.js @@ -1,4 +1,5 @@ // Copyright Joyent, Inc. and other Node contributors. + // // Permission is hereby granted, free of charge, to any person obtaining a // copy of this software and associated documentation files (the @@ -1339,13 +1340,6 @@ function lookupAndConnect(self, options) { hints: options.hints || 0, }; - if (!isWindows && - dnsopts.family !== 4 && - dnsopts.family !== 6 && - dnsopts.hints === 0) { - dnsopts.hints = dns.ADDRCONFIG; - } - debug('connect: find host', host); debug('connect: dns options', dnsopts); self._host = host; diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 7998811ae..cdda55534 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -30,6 +30,10 @@ test-cli-syntax: PASS,FLAKY test-watch-mode: SKIP test-watch-mode-inspect: SKIP +# does not work on IPv6 only host +test-tls-psk-client: PASS,FLAKY +test-tls-securepair-client: PASS,FLAKY + [$system==win32] # https://github.com/nodejs/node/issues/47116 test-http-max-sockets: PASS, FLAKY -- 2.30.2