From 59953d857b1613ea8d807a73ff03bdcdc0ba8b7b Mon Sep 17 00:00:00 2001 From: Matthieu Gallien Date: Thu, 25 Nov 2021 16:44:57 +0100 Subject: [PATCH] use a proper constant for the size of batch Signed-off-by: Matthieu Gallien --- src/libsync/bulkpropagatorjob.cpp | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libsync/bulkpropagatorjob.cpp b/src/libsync/bulkpropagatorjob.cpp index 3aa8b76a2..7c74a3ce9 100644 --- a/src/libsync/bulkpropagatorjob.cpp +++ b/src/libsync/bulkpropagatorjob.cpp @@ -64,6 +64,8 @@ QByteArray getHeaderFromJsonReply(const QJsonObject &reply, const QByteArray &he return reply.value(headerName).toString().toLatin1(); } +constexpr auto batchSize = 100; + } namespace OCC { @@ -73,7 +75,8 @@ BulkPropagatorJob::BulkPropagatorJob(OwncloudPropagator *propagator, : PropagatorJob(propagator) , _items(items) { - _filesToUpload.reserve(100); + _filesToUpload.reserve(batchSize); + _pendingChecksumFiles.reserve(batchSize); } bool BulkPropagatorJob::scheduleSelfOrChild() @@ -83,7 +86,7 @@ bool BulkPropagatorJob::scheduleSelfOrChild() } _state = Running; - for(int i = 0; i < 100 && !_items.empty(); ++i) { + for(int i = 0; i < batchSize && !_items.empty(); ++i) { auto currentItem = _items.front(); _items.pop_front(); _pendingChecksumFiles.insert(currentItem->_file); -- 2.30.2