From 58837cad64dd9819c6f95a395bd7bec7487d6b5a Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <cyril@debamax.com>
Date: Wed, 1 Mar 2023 22:41:36 +0100
Subject: [PATCH] Skip flakky tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

Initially (2023-02-15):
 - TestAPICSendMetrics
 - TestLongRunningQPS

Both aim at checking performance, and might error out when the underlying
system is “slow”. That was the case for the first test on arm64 (KO on
arm-arm-01, OK on arm-ubc-03) and on armel (KO on arm-ubc-06, OK on
arm-conova-02), and for the second test on mipsel (KO on mipsel-aql-02).

The same might happen on ci.debian.net, so disable both tests everywhere.

Extension (2023-03-01):
 - TestAPICCAPIPullIsOld
 - TestAPICHandleDeletedDecisions
 - TestAPICPullTop
 - TestGetDecisionsSinceCount


Gbp-Pq: Name 0013-skip-flakky-tests.patch
---
 pkg/apiserver/apic_test.go      | 4 ++++
 pkg/exprhelpers/exprlib_test.go | 1 +
 pkg/time/rate/rate_test.go      | 1 +
 3 files changed, 6 insertions(+)

diff --git a/pkg/apiserver/apic_test.go b/pkg/apiserver/apic_test.go
index a06a750..2a1cc9a 100644
--- a/pkg/apiserver/apic_test.go
+++ b/pkg/apiserver/apic_test.go
@@ -95,6 +95,7 @@ func assertTotalAlertCount(t *testing.T, dbClient *database.Client, count int) {
 }
 
 func TestAPICCAPIPullIsOld(t *testing.T) {
+	t.Skip()
 	api := getAPIC(t)
 
 	isOld, err := api.CAPIPullIsOld()
@@ -223,6 +224,7 @@ func TestNewAPIC(t *testing.T) {
 }
 
 func TestAPICHandleDeletedDecisions(t *testing.T) {
+	t.Skip()
 	api := getAPIC(t)
 	_, deleteCounters := makeAddAndDeleteCounters()
 
@@ -502,6 +504,7 @@ func TestFillAlertsWithDecisions(t *testing.T) {
 }
 
 func TestAPICPullTop(t *testing.T) {
+	t.Skip()
 	api := getAPIC(t)
 	api.dbClient.Ent.Decision.Create().
 		SetOrigin(SCOPE_LISTS).
@@ -699,6 +702,7 @@ func TestAPICPush(t *testing.T) {
 }
 
 func TestAPICSendMetrics(t *testing.T) {
+	t.Skip()
 	tests := []struct {
 		name            string
 		duration        time.Duration
diff --git a/pkg/exprhelpers/exprlib_test.go b/pkg/exprhelpers/exprlib_test.go
index 8b5664c..3ef96d3 100644
--- a/pkg/exprhelpers/exprlib_test.go
+++ b/pkg/exprhelpers/exprlib_test.go
@@ -847,6 +847,7 @@ func TestGetDecisionsCount(t *testing.T) {
 	}
 }
 func TestGetDecisionsSinceCount(t *testing.T) {
+	t.Skip()
 	var err error
 	var start_ip, start_sfx, end_ip, end_sfx int64
 	var ip_sz int
diff --git a/pkg/time/rate/rate_test.go b/pkg/time/rate/rate_test.go
index 6df9412..a212ce1 100644
--- a/pkg/time/rate/rate_test.go
+++ b/pkg/time/rate/rate_test.go
@@ -175,6 +175,7 @@ func TestSimultaneousRequests(t *testing.T) {
 }
 
 func TestLongRunningQPS(t *testing.T) {
+	t.Skip()
 	if testing.Short() {
 		t.Skip("skipping in short mode")
 	}
-- 
2.30.2