From 56d563577ffda1de539edba62486cfad4f81a070 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Wed, 9 Nov 2022 15:46:14 -0400 Subject: [PATCH] analysis --- ...d_S3_tree_does_not_unexport_git_objects.mdwn | 2 +- ..._3_176cbc137afb5cf8841ff9114b111fef._comment | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects/comment_3_176cbc137afb5cf8841ff9114b111fef._comment diff --git a/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects.mdwn b/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects.mdwn index ad68504451..d06fe59a96 100644 --- a/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects.mdwn +++ b/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects.mdwn @@ -394,4 +394,4 @@ ok Thank you for all your work making this wonderful tool! -[[!meta title="export tree sometimes does not delete removed git files"]] +[[!meta title="export tree bug when two files with the same content both should be removed"]] diff --git a/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects/comment_3_176cbc137afb5cf8841ff9114b111fef._comment b/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects/comment_3_176cbc137afb5cf8841ff9114b111fef._comment new file mode 100644 index 0000000000..0d8f4ce9e4 --- /dev/null +++ b/doc/bugs/Versioned_S3_tree_does_not_unexport_git_objects/comment_3_176cbc137afb5cf8841ff9114b111fef._comment @@ -0,0 +1,17 @@ +[[!comment format=mdwn + username="joey" + subject="""comment 3""" + date="2022-11-09T19:41:33Z" + content=""" +Ok, the bug is due to 2 files that have the same content. + + sub-000101/ses-baseline/pet/sub-000101_ses-baseline_rec-MLEM_pet.json + sub-000101/ses-displaced/pet/sub-000101_ses-displaced_rec-MLEM_pet.json + +Both files get deleted. And the bug makes it only pick one of the two files +to delete, because it's using a map from key to file and the second file +overwrites the first in the map. + +So this would also presumably affect annexed files when two have the same +content and are being deleted. +"""]] -- 2.30.2