From 54809e9eb381a11c8e7c3e948c36b2ff99a0a336 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Mon, 9 May 2022 15:53:23 -0400 Subject: [PATCH] fix untrustworthiness of import/export remotes Commit 36133f27c0bd5ba037291420d4b66a3bd8e26308 had a boolean flip in it, aaargh. Special remotes with importtree=yes or exporttree=yes are once again treated as untrusted, since files stored in them can be deleted or modified at any time. Sponsored-by: Kevin Mueller on Patreon --- CHANGELOG | 4 ++++ Remote/Helper/ExportImport.hs | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG b/CHANGELOG index fa9a9c106d..70aeedebba 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -1,5 +1,9 @@ git-annex (10.20220505) UNRELEASED; urgency=medium + * Special remotes with importtree=yes or exporttree=yes are once again + treated as untrusted, since files stored in them can be deleted or + modified at any time. + (Fixes a reversion in 8.20201129) * Added support for "megabit" and related bandwidth units in annex.stalldetection and everywhere else that git-annex parses data units. Note that the short form is "Mbit" not "Mb" because diff --git a/Remote/Helper/ExportImport.hs b/Remote/Helper/ExportImport.hs index 71911889d1..d753dee66a 100644 --- a/Remote/Helper/ExportImport.hs +++ b/Remote/Helper/ExportImport.hs @@ -216,7 +216,7 @@ adjustExportImport' isexport isimport r rs = do , untrustworthy = if versioned || thirdPartyPopulated (remotetype r) then untrustworthy r - else False + else True -- git-annex testremote cannot be used to test -- import/export since it stores keys. , mkUnavailable = return Nothing -- 2.30.2