From 50e9d1ed5448ba44adc427749ae9094c58c99b0d Mon Sep 17 00:00:00 2001 From: Jonathan Dieter Date: Fri, 14 Sep 2018 13:21:58 +0100 Subject: [PATCH] Fix memory leak (Coverity ID: 310910) Signed-off-by: Jonathan Dieter --- src/lib/index/index_read.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/src/lib/index/index_read.c b/src/lib/index/index_read.c index 136c1bd..2754750 100644 --- a/src/lib/index/index_read.c +++ b/src/lib/index/index_read.c @@ -24,6 +24,7 @@ * POSSIBILITY OF SUCH DAMAGE. */ +#include #include #include #include @@ -67,19 +68,12 @@ bool index_read(zckCtx *zck, char *data, size_t size, size_t max_length) { } zckChunk *new = zmalloc(sizeof(zckChunk)); - if(!new) { - set_fatal_error(zck, "Unable to allocate %lu bytes", - sizeof(zckChunk)); - return false; - } + assert(new); /* Read index entry digest */ new->digest = zmalloc(zck->index.digest_size); - if(!new->digest) { - set_fatal_error(zck, "Unable to allocate %lu bytes", - zck->index.digest_size); - return false; - } + assert(new->digest); + memcpy(new->digest, data+length, zck->index.digest_size); new->digest_size = zck->index.digest_size; length += zck->index.digest_size; -- 2.30.2