From 4973b89e5830740f7586c7e33304ceb735f89d88 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9my=20Lal?= Date: Wed, 20 Dec 2023 18:07:36 +0100 Subject: [PATCH] adapt test-ci build target for buildd Forwarded: not-needed Reviewed-By: Xavier Guimard Last-Update: 2020-02-09 * run tests with ./node * remove addons from test-ci suite, because it creates a dependency loop nodejs -> node-gyp -> nodejs which is painful to manage. * disabled because it requires stdin: + test-stdout-close-unref + test-regress-GH-746 * test-tick-processor fails on ppc64 and s390x, currently investigated https://github.com/nodejs/node/issues/2471 * test-cluster-disconnect sometimes fails on busy buildd, forwarded upstream https://github.com/nodejs/node/issues/3383 * test-fs-watch is flaky, might be related to https://github.com/nodejs/node/issues/4082 * huge timeout value for all platforms, buildd could be busy * test-npm-install and test-release-npm must fail, debian package dfsg-repacked npm out * ability to override CI_NATIVE_SUITES, CI_JS_SUITES * disable tests failing because DNS is disabled * sequential/test-http2-session-timeout is flaky https://github.com/nodejs/node/issues/20628 Gbp-Pq: Topic build Gbp-Pq: Name test_ci.patch --- Makefile | 2 +- test/common/index.js | 15 +++++------ test/parallel/parallel.status | 43 +++++++++++++++++++++++++++++++ test/sequential/sequential.status | 18 +++++++++++++ tools/test.py | 20 +------------- 5 files changed, 70 insertions(+), 28 deletions(-) diff --git a/Makefile b/Makefile index 36bc51f5a..776bcd76c 100644 --- a/Makefile +++ b/Makefile @@ -540,7 +540,7 @@ test-ci-native: | benchmark/napi/.buildstamp test/addons/.buildstamp test/js-nat # This target should not use a native compiler at all # Related CI job: node-test-commit-arm-fanned test-ci-js: | clear-stalled - $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \ + $(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap \ --mode=$(BUILDTYPE_LOWER) --flaky-tests=$(FLAKY_TESTS) \ $(TEST_CI_ARGS) $(CI_JS_SUITES) $(info Clean up any leftover processes, error if found.) diff --git a/test/common/index.js b/test/common/index.js index e25b861cc..7479e99d1 100644 --- a/test/common/index.js +++ b/test/common/index.js @@ -259,16 +259,15 @@ const pwdCommand = isWindows ? function platformTimeout(ms) { const multipliers = typeof ms === 'bigint' ? - { two: 2n, four: 4n, seven: 7n } : { two: 2, four: 4, seven: 7 }; + { fast: 2n, slow: 4n } : { fast: 3, slow: 5 }; + + if (process.arch.startsWith('arm') || process.arch.startsWith('mips') || process.arch.startsWith('riscv')) + ms = multipliers.slow * ms; + else + ms = multipliers.fast * ms; if (process.features.debug) - ms = multipliers.two * ms; - - if (exports.isAIX || exports.isIBMi) - return multipliers.two * ms; // Default localhost speed is slower on AIX - - if (isPi) - return multipliers.two * ms; // Raspberry Pi devices + ms = multipliers.slow * ms; return ms; } diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 58beb9d2c..1c217b8dc 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -6,6 +6,45 @@ prefix parallel [true] # This section applies to all platforms +test-process-config : PASS,FLAKY +test-regress-GH-746 : PASS,FLAKY +test-stdout-close-unref : PASS,FLAKY +test-npm-install : FAIL +test-npm-version : FAIL +test-release-npm : FAIL +# skip tests accessing network +test-dns : SKIP +test-net-connect-immediate-finish : SKIP +test-net-better-error-messages-port-hostname : SKIP + +# in debian build env, skip because it somehow tries to access network +test-https-connect-address-family : SKIP +test-tls-connect-address-family : SKIP +test-dns-cancel-reverse-lookup: SKIP +test-dns-resolveany-bad-ancount: SKIP + +# https://bugs.debian.org/919588 +## flaky on some user environments +test-net-listen-after-destroying-stdin: PASS,FLAKY +## fails when running with eatmydata +test-fs-error-messages: PASS,FLAKY + +# this new test doesn't have a built target properly setup +test-child-process-stdio-overlapped: SKIP + +# does not pass in autopkgtest ci env +test-cluster-bind-privileged-port: PASS,FLAKY +test-cluster-shared-handle-bind-privileged-port: PASS,FLAKY +test-debugger-preserve-breaks: PASS,FLAKY + +# corepack is dfsg-excluded +test-corepack-yarn-install: SKIP +test-corepack-version: SKIP + +# might fail, see https://github.com/nodejs/node/issues/17909 +test-fs-utimes: PASS,FLAKY +test-fs-utimes-y2K38: PASS,FLAKY + [$system==win32] # https://github.com/nodejs/node/issues/41206 test-crypto-keygen: PASS,FLAKY @@ -54,6 +93,10 @@ test-crypto-keygen: SKIP # https://github.com/nodejs/node/issues/47297 test-wasm-web-api: SKIP +[$arch==mips64el] +# the debug flag is for hacking v8 internals +test-debug-args: PASS,FLAKY + [$system==solaris] # Also applies to SmartOS # https://github.com/nodejs/node/issues/43457 test-domain-no-error-handler-abort-on-uncaught-0: PASS, FLAKY diff --git a/test/sequential/sequential.status b/test/sequential/sequential.status index 0cfd67fc8..2cae4b028 100644 --- a/test/sequential/sequential.status +++ b/test/sequential/sequential.status @@ -11,6 +11,24 @@ test-cpu-prof-dir-worker: PASS, FLAKY test-watch-mode: PASS, FLAKY test-watch-mode-inspect: PASS, FLAKY +# flaky or failing at least on debian build servers +test-fs-watch : PASS,FLAKY +test-force-repl : SKIP +test-performance : SKIP +test-http2-session-timeout : PASS,FLAKY +test-debugger-preserve-breaks : PASS,FLAKY +test-debugger-exec-scope : PASS,FLAKY + +# https://github.com/nodejs/node/issues/24403 +test-cli-syntax: PASS,FLAKY + +# for debian buildd i386 (but pass on porter barriere.d.o) +test-debugger-heap-profiler: PASS,FLAKY + +# new test - failing/hanging https://github.com/nodejs/node/issues/44898 +test-watch-mode: SKIP +test-watch-mode-inspect: SKIP + [$system==win32] # https://github.com/nodejs/node/issues/47116 test-http-max-sockets: PASS, FLAKY diff --git a/tools/test.py b/tools/test.py index 14ed3ea08..4a3f37f11 100755 --- a/tools/test.py +++ b/tools/test.py @@ -934,25 +934,7 @@ class Context(object): self.node_has_crypto = True def GetVm(self, arch, mode): - if self.vm is not None: - return self.vm - if arch == 'none': - name = 'out/Debug/node' if mode == 'debug' else 'out/Release/node' - else: - name = 'out/%s.%s/node' % (arch, mode) - - # Currently GYP does not support output_dir for MSVS. - # http://code.google.com/p/gyp/issues/detail?id=40 - # It will put the builds into Release/node.exe or Debug/node.exe - if utils.IsWindows(): - if not exists(name + '.exe'): - name = name.replace('out/', '') - name = os.path.abspath(name + '.exe') - - if not exists(name): - raise ValueError('Could not find executable. Should be ' + name) - - return name + return './node' def GetTimeout(self, mode, section=''): timeout = self.timeout * TIMEOUT_SCALEFACTOR[ARCH_GUESS or 'ia32'][mode] -- 2.30.2