From 40bc44503a84080e7df60133df78c2aa05b5f99d Mon Sep 17 00:00:00 2001 From: Benjamin Otte Date: Tue, 14 Mar 2023 16:31:44 +0000 Subject: [PATCH] Merge branch 'wip/hadess/children-left-msg' into 'main' gtk: Fix "children left" warning with fatal warnings See merge request GNOME/gtk!5652 (cherry picked from commit a05b73cb05a407a23a670b30c8d3719fa94436b9) 4f1ea18c gtk: Fix "children left" warning with fatal warnings --- gtk/gtkwidget.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/gtk/gtkwidget.c b/gtk/gtkwidget.c index 702f9a72c1..974e126172 100644 --- a/gtk/gtkwidget.c +++ b/gtk/gtkwidget.c @@ -7637,14 +7637,20 @@ gtk_widget_finalize (GObject *object) if (_gtk_widget_get_first_child (widget) != NULL) { GtkWidget *child; - g_warning ("Finalizing %s %p, but it still has children left:", - gtk_widget_get_name (widget), widget); + GString *s; + + s = g_string_new (NULL); + g_string_append_printf (s, "Finalizing %s %p, but it still has children left:", + gtk_widget_get_name (widget), widget); for (child = _gtk_widget_get_first_child (widget); child != NULL; child = _gtk_widget_get_next_sibling (child)) { - g_warning (" - %s %p", gtk_widget_get_name (child), child); + g_string_append_printf (s, "\n - %s %p", + gtk_widget_get_name (child), child); } + g_warning ("%s", s->str); + g_string_free (s, TRUE); } if (g_object_is_floating (object)) -- 2.30.2