From 3b519493606fef4685964f2d2f2bf75aadc434e7 Mon Sep 17 00:00:00 2001 From: James Addison Date: Wed, 1 Jan 2025 14:34:52 +0100 Subject: [PATCH] Harmonize V8 stack sizes on ARM architectures to match almost all other architectures Last-Update: 2023-02-28 Forwarded: https://github.com/nodejs/node/issues/41163 Gbp-Pq: Topic arm64 Gbp-Pq: Name stacksize.patch --- deps/v8/src/common/globals.h | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/deps/v8/src/common/globals.h b/deps/v8/src/common/globals.h index 17057b4c5..92b0047b2 100644 --- a/deps/v8/src/common/globals.h +++ b/deps/v8/src/common/globals.h @@ -152,26 +152,9 @@ namespace internal { #define ENABLE_SPARKPLUG true -#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_ARM64 -// Set stack limit lower for ARM and ARM64 than for other architectures because: -// - on Arm stack allocating MacroAssembler takes 120K bytes. -// See issue crbug.com/405338 -// - on Arm64 when running in single-process mode for Android WebView, when -// initializing V8 we already have a large stack and so have to set the -// limit lower. See issue crbug.com/v8/10575 -#define V8_DEFAULT_STACK_SIZE_KB 864 -#elif V8_TARGET_ARCH_IA32 -// In mid-2022, we're observing an increase in stack overflow crashes on -// 32-bit Windows; the suspicion is that some third-party software suddenly -// started to consume a lot more stack memory (before V8 is even initialized). -// So we speculatively lower the ia32 limit to the ARM limit for the time -// being. See crbug.com/1346791. -#define V8_DEFAULT_STACK_SIZE_KB 864 -#else // Slightly less than 1MB, since Windows' default stack size for // the main execution thread is 1MB. #define V8_DEFAULT_STACK_SIZE_KB 984 -#endif // Helper macros to enable handling of direct C calls in the simulator. #if defined(USE_SIMULATOR) && \ -- 2.30.2