From 37cf71a9a79018714c10e8788c5183cd405a7a24 Mon Sep 17 00:00:00 2001 From: Claudio Cambra Date: Thu, 11 May 2023 19:47:55 +0800 Subject: [PATCH] Don't bother creating a unique ptr for PutMultiFileJob as we never use the guarded ptr Signed-off-by: Claudio Cambra --- src/libsync/bulkpropagatorjob.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/libsync/bulkpropagatorjob.cpp b/src/libsync/bulkpropagatorjob.cpp index f414c73f3..bbbc98ab1 100644 --- a/src/libsync/bulkpropagatorjob.cpp +++ b/src/libsync/bulkpropagatorjob.cpp @@ -219,19 +219,18 @@ void BulkPropagatorJob::triggerUpload() } const auto bulkUploadUrl = Utility::concatUrlPath(propagator()->account()->url(), QStringLiteral("/remote.php/dav/bulk")); - auto job = std::make_unique(propagator()->account(), bulkUploadUrl, std::move(uploadParametersData), this); - connect(job.get(), &PutMultiFileJob::finishedSignal, this, &BulkPropagatorJob::slotPutFinished); + auto job = new PutMultiFileJob(propagator()->account(), bulkUploadUrl, std::move(uploadParametersData), this); + connect(job, &PutMultiFileJob::finishedSignal, this, &BulkPropagatorJob::slotPutFinished); for(auto &singleFile : _filesToUpload) { - connect(job.get(), &PutMultiFileJob::uploadProgress, - this, [this, singleFile] (qint64 sent, qint64 total) { + connect(job, &PutMultiFileJob::uploadProgress, this, [this, singleFile] (const qint64 sent, const qint64 total) { slotUploadProgress(singleFile._item, sent, total); }); } - adjustLastJobTimeout(job.get(), timeout); - _jobs.append(job.get()); - job.release()->start(); + adjustLastJobTimeout(job, timeout); + _jobs.append(job); + job->start(); if (parallelism() == PropagatorJob::JobParallelism::FullParallelism && _jobs.size() < parallelJobsMaximumCount) { scheduleSelfOrChild(); } -- 2.30.2