From 341569f1d18df00bda6625a77c2b106cee382562 Mon Sep 17 00:00:00 2001 From: Dario Faggioli Date: Thu, 13 Apr 2017 09:49:54 +0200 Subject: [PATCH] xen: credit: change an ASSERT on nr_runnable so that it makes sense. Since the counter is unsigned, it's pointless/bogous to check for if to be above zero. Check that it is at least one before it's decremented, instead. Spotted by Coverity. Reported-by: Andrew Cooper Signed-off-by: Dario Faggioli Reviewed-by: George Dunlap Release-acked-by: Julien Grall --- xen/common/sched_credit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/sched_credit.c b/xen/common/sched_credit.c index 93658dcfe5..efdf6bf2f3 100644 --- a/xen/common/sched_credit.c +++ b/xen/common/sched_credit.c @@ -275,8 +275,8 @@ static inline void dec_nr_runnable(unsigned int cpu) { ASSERT(spin_is_locked(per_cpu(schedule_data, cpu).schedule_lock)); + ASSERT(CSCHED_PCPU(cpu)->nr_runnable >= 1); CSCHED_PCPU(cpu)->nr_runnable--; - ASSERT(CSCHED_PCPU(cpu)->nr_runnable >= 0); } static inline void -- 2.30.2