From 241597a8a5bbc4223d7739ffe191e5114af40caa Mon Sep 17 00:00:00 2001 From: Colin Walters Date: Thu, 14 Dec 2023 08:03:01 -0500 Subject: [PATCH] zipl: NUL terminate buffer we're searching Found by a static analyzer. --- src/libostree/ostree-bootloader-zipl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libostree/ostree-bootloader-zipl.c b/src/libostree/ostree-bootloader-zipl.c index d6fb7ebd..0329eb65 100644 --- a/src/libostree/ostree-bootloader-zipl.c +++ b/src/libostree/ostree-bootloader-zipl.c @@ -149,9 +149,10 @@ _ostree_secure_boot_is_enabled (gboolean *out_enabled, GCancellable *cancellable while (*out_enabled != TRUE && max_lines > 0) { char buf[1024]; - ssize_t len = TEMP_FAILURE_RETRY (read (fd, buf, sizeof (buf))); + ssize_t len = TEMP_FAILURE_RETRY (read (fd, buf, sizeof (buf) - 1)); if (len < 0) break; + buf[len] = '\0'; *out_enabled = strstr (buf, "Secure-IPL enabled") != NULL; --max_lines; } -- 2.30.2