From 23a3ea668736440790b7372c1258b4bb694ec7ec Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 9 Oct 2018 16:25:38 +0100 Subject: [PATCH] xenstore.h: Put ( ) around XS_* define shifts These definitions were not properly protected from unwanted operator precedence interactions. Existing use sites in-tree all use & or |, so this does not change any actual behaviour in-tree. The same seems likely to be true in external callers. Signed-off-by: Ian Jackson Acked-by: Wei Liu --- tools/xenstore/include/xenstore.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/xenstore/include/xenstore.h b/tools/xenstore/include/xenstore.h index f460b8c5e5..064b62c455 100644 --- a/tools/xenstore/include/xenstore.h +++ b/tools/xenstore/include/xenstore.h @@ -23,8 +23,8 @@ #define XBT_NULL 0 -#define XS_OPEN_READONLY 1UL<<0 -#define XS_OPEN_SOCKETONLY 1UL<<1 +#define XS_OPEN_READONLY (1UL<<0) +#define XS_OPEN_SOCKETONLY (1UL<<1) /* * Setting XS_UNWATCH_FILTER arranges that after xs_unwatch, no @@ -45,7 +45,7 @@ * xs_unwatch for the first watch * has returned. */ -#define XS_UNWATCH_FILTER 1UL<<2 +#define XS_UNWATCH_FILTER (1UL<<2) struct xs_handle; typedef uint32_t xs_transaction_t; -- 2.30.2