From 207de071f48868f94937a52a5624499896cd7466 Mon Sep 17 00:00:00 2001 From: Michael Schuster Date: Mon, 16 Sep 2019 20:26:18 +0200 Subject: [PATCH] Add warning for failed chown in libsync/propagatedownload.cpp In addition to PR 1409 generate warnings if chown fails. See: https://github.com/nextcloud/desktop/pull/1409 Signed-off-by: Michael Schuster --- src/libsync/propagatedownload.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libsync/propagatedownload.cpp b/src/libsync/propagatedownload.cpp index a0d1bd6bc..56b3b1162 100644 --- a/src/libsync/propagatedownload.cpp +++ b/src/libsync/propagatedownload.cpp @@ -800,7 +800,8 @@ namespace { // Anonymous namespace for the recall feature #ifdef Q_OS_UNIX int chownErr = chown(fileName.toLocal8Bit().constData(), -1, fi.groupId()); if (chownErr) { - // TODO: Error handling! + // TODO: Consider further error handling! + qCWarning(lcPropagateDownload) << QString("preserveGroupOwnership: chown error %1: setting group %2 failed on file %3").arg(chownErr).arg(fi.groupId()).arg(fileName); } #else Q_UNUSED(fileName); -- 2.30.2