From 1f96f351e09d6f6fccb62243926c364cad0417c0 Mon Sep 17 00:00:00 2001 From: Georges Basile Stavracas Neto Date: Fri, 3 Jul 2015 15:48:48 -0300 Subject: [PATCH] entrycompletion: no need to return boolean The boolean _gtk_entry_completion_resize_popup's return value is not used anywhere, and only adds more complexity for the method. https://bugzilla.gnome.org/show_bug.cgi?id=751913 --- gtk/gtkentrycompletion.c | 8 +++----- gtk/gtkentryprivate.h | 2 +- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/gtk/gtkentrycompletion.c b/gtk/gtkentrycompletion.c index 6a8cbf4377..fb6e558817 100644 --- a/gtk/gtkentrycompletion.c +++ b/gtk/gtkentrycompletion.c @@ -1486,7 +1486,7 @@ gtk_entry_completion_list_motion_notify (GtkWidget *widget, /* some nasty size requisition */ -gboolean +void _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion) { GtkAllocation allocation; @@ -1509,10 +1509,10 @@ _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion) window = gtk_widget_get_window (completion->priv->entry); if (!window) - return FALSE; + return; if (!completion->priv->filter_model) - return FALSE; + return; gtk_widget_get_allocation (completion->priv->entry, &allocation); gtk_widget_get_preferred_size (completion->priv->entry, @@ -1604,8 +1604,6 @@ _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion) } gtk_window_move (GTK_WINDOW (completion->priv->popup_window), x, y); - - return above; } static void diff --git a/gtk/gtkentryprivate.h b/gtk/gtkentryprivate.h index 7e84d06c7c..6d85d87739 100644 --- a/gtk/gtkentryprivate.h +++ b/gtk/gtkentryprivate.h @@ -74,7 +74,7 @@ struct _GtkEntryCompletionPrivate GdkDevice *device; }; -gboolean _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion); +void _gtk_entry_completion_resize_popup (GtkEntryCompletion *completion); void _gtk_entry_completion_popdown (GtkEntryCompletion *completion); void _gtk_entry_completion_connect (GtkEntryCompletion *completion, GtkEntry *entry); -- 2.30.2