From 1e06838c1c15ad2197168f24b88da5ef11817ffd Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" Date: Wed, 23 May 2018 20:06:01 +0200 Subject: [PATCH] icontheme: Keep dir_mtimes in order Don't reverse the order each time we insert a theme. Reverse it only once, after all themes have been loaded. Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1115 --- gtk/gtkicontheme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gtk/gtkicontheme.c b/gtk/gtkicontheme.c index 0faca7d72c..33ef8542a9 100644 --- a/gtk/gtkicontheme.c +++ b/gtk/gtkicontheme.c @@ -1091,7 +1091,6 @@ insert_theme (GtkIconTheme *icon_theme, priv->dir_mtimes = g_list_prepend (priv->dir_mtimes, dir_mtime); } - priv->dir_mtimes = g_list_reverse (priv->dir_mtimes); theme_file = NULL; for (i = 0; i < priv->search_path_len && !theme_file; i++) @@ -1316,7 +1315,7 @@ load_themes (GtkIconTheme *icon_theme) dir = icon_theme->priv->search_path[base]; dir_mtime = g_slice_new (IconThemeDirMtime); - priv->dir_mtimes = g_list_append (priv->dir_mtimes, dir_mtime); + priv->dir_mtimes = g_list_prepend (priv->dir_mtimes, dir_mtime); dir_mtime->dir = g_strdup (dir); dir_mtime->mtime = 0; @@ -1341,6 +1340,7 @@ load_themes (GtkIconTheme *icon_theme) g_dir_close (gdir); } + priv->dir_mtimes = g_list_reverse (priv->dir_mtimes); for (d = priv->resource_paths; d; d = d->next) { -- 2.30.2