From 1b843b2097e89d0fae18123cde88da9d167d9a0c Mon Sep 17 00:00:00 2001 From: Meng Xu Date: Fri, 21 Oct 2016 22:12:02 -0400 Subject: [PATCH] xen: rtds: always clear the flag when replenishing a depleted vcpu We should clear the __RTDS_depleted bit once a VCPU budget is replenished. Because repl_timer_handler may be called after rt_schedule but before rt_context_saved, the VCPU may be not on CPU or on queue when the VCPU is the middle of context switch Signed-off-by: Meng Xu Acked-by: Dario Faggioli Release-acked-by: Wei Liu --- xen/common/sched_rt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/common/sched_rt.c b/xen/common/sched_rt.c index d95f79818f..d61804a1ce 100644 --- a/xen/common/sched_rt.c +++ b/xen/common/sched_rt.c @@ -1480,8 +1480,8 @@ static void repl_timer_handler(void *data){ if ( svc->cur_deadline > next_on_runq->cur_deadline ) runq_tickle(ops, next_on_runq); } - else if ( vcpu_on_q(svc) && - __test_and_clear_bit(__RTDS_depleted, &svc->flags) ) + else if ( __test_and_clear_bit(__RTDS_depleted, &svc->flags) && + vcpu_on_q(svc) ) runq_tickle(ops, svc); list_del(&svc->replq_elem); -- 2.30.2