From 1afe55905427b7e25936388c65a29c2bbb280bc8 Mon Sep 17 00:00:00 2001 From: Michal Orzel Date: Wed, 27 Apr 2022 11:49:39 +0200 Subject: [PATCH] platforms/xgene: Make use of dt_device_get_address return value Currently function xgene_check_pirq_eoi assigns the return value of dt_device_get_address to a variable res but does not make use of it. Fix it by making use of res in the condition checking the result of a call to dt_device_get_address instead of checking the address stored in dbase. Signed-off-by: Michal Orzel Reviewed-by: Julien Grall --- xen/arch/arm/platforms/xgene-storm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/platforms/xgene-storm.c b/xen/arch/arm/platforms/xgene-storm.c index fced4d7c2c..befd0c3c2d 100644 --- a/xen/arch/arm/platforms/xgene-storm.c +++ b/xen/arch/arm/platforms/xgene-storm.c @@ -51,7 +51,7 @@ static void __init xgene_check_pirq_eoi(void) panic("%s: Can not find interrupt controller node\n", __func__); res = dt_device_get_address(node, 0, &dbase, NULL); - if ( !dbase ) + if ( res ) panic("%s: Cannot find a valid address for the distributor\n", __func__); /* -- 2.30.2