From 159444e9bf3fb2c7ba54648431fad2a42e556a03 Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=A9r=C3=A9my=20Lal?= Date: Mon, 20 Apr 2020 08:44:09 +0100 Subject: [PATCH] only emit Buffer DEP0005 warning if --pending-deprecation is set Forwarded: not-needed, upstream wants to do otherwise Last-Update: 2019-01-06 Gbp-Pq: Name temporarily_silence_buffer_deprecations.patch --- lib/buffer.js | 3 +-- test/parallel/parallel.status | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/buffer.js b/lib/buffer.js index 8f919a52f..a28434944 100644 --- a/lib/buffer.js +++ b/lib/buffer.js @@ -145,8 +145,7 @@ const bufferWarning = 'Buffer() is deprecated due to security and usability ' + function showFlaggedDeprecation() { if (bufferWarningAlreadyEmitted || ++nodeModulesCheckCounter > 10000 || - (!pendingDeprecation && - isInsideNodeModules())) { + !pendingDeprecation) { // We don't emit a warning, because we either: // - Already did so, or // - Already checked too many times whether a call is coming diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index 3eda236d2..baf4fe9b4 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -30,6 +30,11 @@ test-net-listen-after-destroying-stdin: PASS,FLAKY ## fails when running with eatmydata test-fs-error-messages: PASS,FLAKY +# pending deprecation for buffer is off +test-buffer-constructor-node-modules-paths : SKIP +test-buffer-constructor-deprecation-error : SKIP +test-buffer-constructor-outside-node-modules : SKIP + # should have been disabled 'cause openssl 1.1.0 test-tls-ecdh-disable : SKIP -- 2.30.2