From 0e719f6ec95d7f9c9151ecbbdcba92028307e2b4 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 7 Sep 2021 09:34:57 +0200 Subject: [PATCH] gnttab: drop a redundant expression from gnttab_release_mappings() This gnttab_host_mapping_get_page_type() invocation sits in the "else" path of a conditional controlled by "map->flags & GNTMAP_readonly". Signed-off-by: Jan Beulich Acked-by: Julien Grall --- xen/common/grant_table.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index b1930e2d8e..5f35f78314 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -3801,9 +3801,7 @@ int gnttab_release_mappings(struct domain *d) if ( gnttab_release_host_mappings(d) && !is_iomem_page(act->mfn) ) { - if ( gnttab_host_mapping_get_page_type((map->flags & - GNTMAP_readonly), - d, rd) ) + if ( gnttab_host_mapping_get_page_type(false, d, rd) ) put_page_type(pg); put_page(pg); } -- 2.30.2