From 0d9acbdd8d6edcc8f1572a270b087c36e81504fd Mon Sep 17 00:00:00 2001 From: Sergey Dyasli Date: Tue, 6 Mar 2018 16:47:34 +0100 Subject: [PATCH] pv_console: remove unnecessary #ifdefs The header for PV console contains empty function definitions in case of !CONFIG_XEN_GUEST specially to avoid #ifdefs in a code that uses them to make the code look cleaner. Unfortunately, during the release of shim-comet, PV console functions were enclosed into unnecessary #ifdefs CONFIG_X86. Remove them. Signed-off-by: Sergey Dyasli Acked-by: Jan Beulich Acked-by: Wei Liu --- xen/drivers/char/console.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index 121073c8ed..0f0536930b 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -30,10 +30,10 @@ #include /* for do_console_io */ #include #include +#include #ifdef CONFIG_X86 #include -#include #include #endif @@ -347,10 +347,8 @@ static void sercon_puts(const char *s) else serial_puts(sercon_handle, s); -#ifdef CONFIG_X86 /* Copy all serial output into PV console */ pv_console_puts(s); -#endif } static void dump_console_ring_key(unsigned char key) @@ -816,9 +814,9 @@ void __init console_init_preirq(void) p++; if ( !strncmp(p, "vga", 3) ) video_init(); -#ifdef CONFIG_X86 - else if ( !strncmp(p, "pv", 2) ) + else if ( !strncmp(p, "pv", 2) ) pv_console_init(); +#ifdef CONFIG_X86 else if ( !strncmp(p, "xen", 3) ) opt_console_xen = true; #endif @@ -841,10 +839,7 @@ void __init console_init_preirq(void) } serial_set_rx_handler(sercon_handle, serial_rx); - -#ifdef CONFIG_X86 pv_console_set_rx_handler(serial_rx); -#endif /* HELLO WORLD --- start-of-day banner text. */ spin_lock(&console_lock); @@ -897,10 +892,7 @@ void __init console_init_ring(void) void __init console_init_postirq(void) { serial_init_postirq(); - -#ifdef CONFIG_X86 pv_console_init_postirq(); -#endif if ( conring != _conring ) return; -- 2.30.2