From 07ce3eb6c3e388ba5063585ba9f22dd26e340975 Mon Sep 17 00:00:00 2001 From: Peter Pentchev Date: Sun, 22 Aug 2021 14:51:11 +0300 Subject: [PATCH] Properly detect a read error. Spotted by: cppcheck --- src/lib/io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/lib/io.c b/src/lib/io.c index 5925d51..b91b7ca 100644 --- a/src/lib/io.c +++ b/src/lib/io.c @@ -115,11 +115,13 @@ int chunks_from_temp(zckCtx *zck) { char *data = zmalloc(BUF_SIZE); while((read_count = read(zck->temp_fd, data, BUF_SIZE)) > 0) { - if(read_count == -1 || !write_data(zck, zck->fd, data, read_count)) { + if(!write_data(zck, zck->fd, data, read_count)) { free(data); return false; } } free(data); + if(read_count == -1) + return false; return true; } -- 2.30.2