From 0747b012c308ce274d08e866a1c6031d7f77684f Mon Sep 17 00:00:00 2001 From: B Horn Date: Thu, 7 Nov 2024 06:00:36 +0000 Subject: [PATCH] kern/dl: Check for the SHF_INFO_LINK flag in grub_dl_relocate_symbols() The grub_dl_relocate_symbols() iterates through the sections in an ELF looking for relocation sections. According to the spec [1] the SHF_INFO_LINK flag should be set if the sh_info field is meant to be a section index. [1] https://refspecs.linuxbase.org/elf/gabi4+/ch4.sheader.html Reported-by: B Horn Signed-off-by: B Horn Reviewed-by: Daniel Kiper Conflicts: grub-core/kern/dl.c Conflicts: grub-core/kern/dl.c Gbp-Pq: Topic cve-2025-jan Gbp-Pq: Name kern-dl-Check-for-the-SHF_INFO_LINK-flag-in-grub_dl_reloc.patch --- grub-core/kern/dl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/grub-core/kern/dl.c b/grub-core/kern/dl.c index 1a38742..958de3b 100644 --- a/grub-core/kern/dl.c +++ b/grub-core/kern/dl.c @@ -599,6 +599,9 @@ grub_dl_relocate_symbols (grub_dl_t mod, void *ehdr) grub_dl_segment_t seg; grub_err_t err; + if (!(s->sh_flags & SHF_INFO_LINK)) + continue; + /* Find the target segment. */ for (seg = mod->segment; seg; seg = seg->next) if (seg->section == s->sh_info) -- 2.30.2