From 02bbeaac1be35d5c96dc86d361aa44801a41aefe Mon Sep 17 00:00:00 2001 From: James Addison Date: Sat, 22 Jun 2024 15:21:29 +0300 Subject: [PATCH] Harmonize V8 stack sizes on ARM architectures to match almost all other architectures Last-Update: 2023-02-28 Forwarded: https://github.com/nodejs/node/issues/41163 Gbp-Pq: Topic arm64 Gbp-Pq: Name stacksize.patch --- deps/v8/src/common/globals.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/deps/v8/src/common/globals.h b/deps/v8/src/common/globals.h index 1117478c2..389eb7006 100644 --- a/deps/v8/src/common/globals.h +++ b/deps/v8/src/common/globals.h @@ -71,19 +71,9 @@ namespace internal { #define V8_EMBEDDED_CONSTANT_POOL false #endif -#if V8_TARGET_ARCH_ARM || V8_TARGET_ARCH_ARM64 -// Set stack limit lower for ARM and ARM64 than for other architectures because: -// - on Arm stack allocating MacroAssembler takes 120K bytes. -// See issue crbug.com/405338 -// - on Arm64 when running in single-process mode for Android WebView, when -// initializing V8 we already have a large stack and so have to set the -// limit lower. See issue crbug.com/v8/10575 -#define V8_DEFAULT_STACK_SIZE_KB 864 -#else // Slightly less than 1MB, since Windows' default stack size for // the main execution thread is 1MB for both 32 and 64-bit. #define V8_DEFAULT_STACK_SIZE_KB 984 -#endif // Helper macros to enable handling of direct C calls in the simulator. #if defined(USE_SIMULATOR) && defined(V8_TARGET_ARCH_ARM64) -- 2.30.2