From 01f72fcd2d0eb1c38b3a39ea84f3a6692df447f5 Mon Sep 17 00:00:00 2001 From: Ben Hutchings Date: Tue, 30 May 2023 00:16:39 +0200 Subject: [PATCH] linux-perf: Remove remaining source filenames from executable When we build perf with -ffile-prefix-map, there are still 2 source directory names embedded in the executable: 1. The Documentation subdirectory, used as a fallback from the installed location. 2. The python subdirectory, used in the Python script test. Remove (1) since it is an unnecessary fallback. Change (2) to the installed location. Gbp-Pq: Topic debian Gbp-Pq: Name linux-perf-remove-remaining-source-filenames-from-executable.patch --- tools/perf/Build | 2 +- tools/perf/builtin-report.c | 2 ++ tools/perf/tests/Build | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/perf/Build b/tools/perf/Build index 3e486f7df94..5230df4d5a7 100644 --- a/tools/perf/Build +++ b/tools/perf/Build @@ -52,7 +52,7 @@ CFLAGS_perf.o += -DPERF_HTML_PATH="BUILD_STR($(htmldir_SQ))" \ -DPREFIX="BUILD_STR($(prefix_SQ))" CFLAGS_builtin-trace.o += -DSTRACE_GROUPS_DIR="BUILD_STR($(STRACE_GROUPS_DIR_SQ))" CFLAGS_builtin-report.o += -DTIPDIR="BUILD_STR($(tipdir_SQ))" -CFLAGS_builtin-report.o += -DDOCDIR="BUILD_STR($(srcdir_SQ)/Documentation)" +#CFLAGS_builtin-report.o += -DDOCDIR="BUILD_STR($(srcdir_SQ)/Documentation)" perf-util-y += util/ perf-util-y += arch/ diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 8700c396806..b307a7d7dd9 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -662,10 +662,12 @@ static int report__browse_hists(struct report *rep) path = system_path(TIPDIR); if (perf_tip(&help, path) || help == NULL) { +#if 0 /* fallback for people who don't install perf ;-) */ free(path); path = system_path(DOCDIR); if (perf_tip(&help, path) || help == NULL) +#endif help = strdup("Cannot load tips.txt file, please install perf!"); } free(path); diff --git a/tools/perf/tests/Build b/tools/perf/tests/Build index 5671ee53001..efcb1c283a4 100644 --- a/tools/perf/tests/Build +++ b/tools/perf/tests/Build @@ -73,7 +73,7 @@ perf-test-$(CONFIG_DWARF_UNWIND) += dwarf-unwind.o endif CFLAGS_attr.o += -DBINDIR="BUILD_STR($(bindir_SQ))" -DPYTHON="BUILD_STR($(PYTHON_WORD))" -CFLAGS_python-use.o += -DPYTHONPATH="BUILD_STR($(OUTPUT)python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))" +CFLAGS_python-use.o += -DPYTHONPATH="BUILD_STR($(perfexec_instdir_SQ)/scripts/python)" -DPYTHON="BUILD_STR($(PYTHON_WORD))" CFLAGS_dwarf-unwind.o += -fno-optimize-sibling-calls perf-test-y += workloads/ -- 2.30.2