crypto: adjust rijndaelEncrypt() prototype for gcc11
authorJan Beulich <jbeulich@suse.com>
Thu, 4 Mar 2021 15:47:51 +0000 (16:47 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 4 Mar 2021 15:47:51 +0000 (16:47 +0100)
commitc6ad5a701b9a6df443a6c98d9e7201c958bbcafc
tree451e38cb7b1fa6d247856fafe7102efd9dc767be
parent5d16679ab0760dbe5e4df52c02f15c69ed5541e6
crypto: adjust rijndaelEncrypt() prototype for gcc11

The upcoming release complains, not entirely unreasonably:

In file included from rijndael.c:33:
.../xen/include/crypto/rijndael.h:55:53: note: previously declared as 'const unsigned char[]'
   55 | void    rijndaelEncrypt(const unsigned int [], int, const unsigned char [],
      |                                                     ^~~~~~~~~~~~~~~~~~~~~~
rijndael.c:865:8: error: argument 4 of type 'u8[16]' {aka 'unsigned char[16]'} with mismatched bound [-Werror=array-parameter=]
  865 |     u8 ct[16])
      |     ~~~^~~~~~
In file included from rijndael.c:33:
.../xen/include/crypto/rijndael.h:56:13: note: previously declared as 'unsigned char[]'
   56 |             unsigned char []);
      |             ^~~~~~~~~~~~~~~~

Simply declare the correct array dimensions right away. This then allows
compilers to apply checking at call sites, which seems desirable anyway.

For the moment I'm leaving untouched the disagreement between u8/u32
used in the function definition and unsigned {char,int} used in the
declaration, as making this consistent would call for touching further
functions.

Reported-by: Charles Arnold <carnold@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
xen/include/crypto/rijndael.h