x86/hvm: Fix altp2m_op hypercall continuations
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 5 Apr 2019 14:59:27 +0000 (15:59 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 9 Apr 2019 18:34:41 +0000 (19:34 +0100)
commit8228577ad1ba9f4b49370b76c90b75fb9243ee2f
tree42922b4f921d43b9693f148f201f6498517671da
parent2bed1bc241f51d6ac4baa3c991e2637728e4da6d
x86/hvm: Fix altp2m_op hypercall continuations

c/s 9383de210 "x86/altp2m: support for setting restrictions for an array of
pages" introduced this logic, but do_hvm_op() was already capable of handling
-ERESTART correctly.

More problematic however is a continuation from compat_altp2m_op().  The arg
written back into register state points into the hypercall XLAT area, not at
the original parameter passed by the guest.  It may be truncated by the
vmentry, but definitely won't be correct on the next invocation.

Delete the hypercall_create_continuation() call, and return -ERESTART, which
will cause the compat case to start working correctly.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/hvm/hvm.c