tools/oxenstored: mkdir conflicts were sometimes missed
authorEdwin Török <edvin.torok@citrix.com>
Fri, 15 Jan 2021 19:38:58 +0000 (19:38 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 4 Feb 2021 14:17:44 +0000 (14:17 +0000)
commit45dee7d92b493bb531e7e77a6f9c0180ab152f87
treeb312f81aba1ff00f8e895ad7378eee3824f46df6
parentdc8caf214fb882546b0e93317b9828247a7c9da8
tools/oxenstored: mkdir conflicts were sometimes missed

Due to how set_write_lowpath was used here it didn't detect create/delete
conflicts.  When we create an entry we must mark our parent as modified
(this is what creating a new node via write does).

Otherwise we can have 2 transactions one creating, and another deleting a node
both succeeding depending on timing.  Or one transaction reading an entry,
concluding it doesn't exist, do some other work based on that information and
successfully commit even if another transaction creates the node via mkdir
meanwhile.

Signed-off-by: Edwin Török <edvin.torok@citrix.com>
Acked-by: Christian Lindig <christian.lindig@citrix.com>
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
tools/ocaml/xenstored/transaction.ml