trace: fix build with gcc9
authorJan Beulich <jbeulich@suse.com>
Mon, 13 May 2019 07:51:23 +0000 (09:51 +0200)
committerJan Beulich <jbeulich@suse.com>
Mon, 13 May 2019 07:51:23 +0000 (09:51 +0200)
commit3fd3b266d4198c06e8e421ca515d9ba09ccd5155
tree7f1290a967b898a61afc785f6005cafddf5271de
parente83077a3d11072708a5c38fa09fa9d011914e2a1
trace: fix build with gcc9

While I've not observed this myself, gcc 9 (imo validly) reportedly may
complain

trace.c: In function '__trace_hypercall':
trace.c:826:19: error: taking address of packed member of 'struct <anonymous>' may result in an unaligned pointer value [-Werror=address-of-packed-member]
  826 |     uint32_t *a = d.args;

and the fix is rather simple - remove the __packed attribute. Introduce
a BUILD_BUG_ON() as replacement, for the unlikely case that Xen might
get ported to an architecture where array alignment higher that that of
its elements.

Reported-by: Martin Liška <martin.liska@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
xen/common/trace.c