xz: validate the value before assigning it to an enum variable
authorLasse Collin <lasse.collin@tukaani.org>
Mon, 7 Mar 2022 08:08:54 +0000 (09:08 +0100)
committerJan Beulich <jbeulich@suse.com>
Mon, 7 Mar 2022 08:08:54 +0000 (09:08 +0100)
commit0a21660515c24f09c4ee060ce0bb42e4b2e6b6fa
tree40ac7c7e37e3cd4695cb34fe03e2ba4ba02e88dd
parent10454f381f9157bce26d5db15e07e857b317b4af
xz: validate the value before assigning it to an enum variable

This might matter, for example, if the underlying type of enum xz_check
was a signed char. In such a case the validation wouldn't have caught an
unsupported header. I don't know if this problem can occur in the kernel
on any arch but it's still good to fix it because some people might copy
the XZ code to their own projects from Linux instead of the upstream
XZ Embedded repository.

This change may increase the code size by a few bytes. An alternative
would have been to use an unsigned int instead of enum xz_check but
using an enumeration looks cleaner.

Link: https://lore.kernel.org/r/20211010213145.17462-3-xiang@kernel.org
Signed-off-by: Lasse Collin <lasse.collin@tukaani.org>
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 4f8d7abaa413
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/common/xz/dec_stream.c