lib/pull: Drop partial fetch code from libsoup backend
authorColin Walters <walters@verbum.org>
Thu, 14 Sep 2017 19:10:54 +0000 (15:10 -0400)
committerAtomic Bot <atomic-devel@projectatomic.io>
Fri, 15 Sep 2017 17:01:51 +0000 (17:01 +0000)
commit0488b4870e80ef575d8b0edf6f2a9e5ad54bf4df
tree5e5471a430aa09787c2038e8db6491477eddd681
parentc32f234e9a63396725e98792dc2c4373504b44ac
lib/pull: Drop partial fetch code from libsoup backend

Doing this in prep for libglnx tmpdir porting, but I think we should also do
this because the partial fetch code IMO was never fully baked; among other
things it was never integrated into the scheme we came up with for "boot id
sync" that we use for complete/staged objects.

There's a lot of complexity here that while we have some coverage for, I think
we need to refocus on the core functionality. The libcurl backend doesn't have
an equivalent to this today.

In particular for small objects, this is simply overly complex. The downside is
clearly for large objects like FAH's 61MB initramfs; not being able to resume
fetches of those is unfortunate.

In practice though, I think most people should be using deltas, and we need to
make sure deltas work for large objects anyways.

Further ultimately the peer-to-peer work should help a lot for people
with truly unreliable connections.

Closes: #1176
Approved by: jlebon
src/libostree/ostree-fetcher-curl.c
src/libostree/ostree-fetcher-soup.c
src/libostree/ostree-fetcher-util.h
src/libostree/ostree-repo-commit.c
src/libostree/ostree-repo-private.h
src/libostree/ostree-repo.c