Jocelyn Turcotte [Mon, 20 Apr 2015 09:30:29 +0000 (11:30 +0200)]
Fix the neon build
Markus Goetz [Mon, 20 Apr 2015 09:22:19 +0000 (11:22 +0200)]
Declare master as 1.9.0git
Jocelyn Turcotte [Wed, 15 Apr 2015 13:19:11 +0000 (15:19 +0200)]
Pass SyncFileItems by pointer instead of by value
Use a QSharedPointer to keep the same ownership and
continue passing the SyncFileItems as a const& when
ownership isn't taken. This allows sharing the same
allocations between the jobs and the result vectors.
This saves about 20MB of memory (off 120MB) once all
jobs are created.
Olivier Goffart [Thu, 16 Apr 2015 10:49:31 +0000 (12:49 +0200)]
Merge branch '1.8'
Olivier Goffart [Thu, 16 Apr 2015 09:21:39 +0000 (11:21 +0200)]
Propagate download: Fix restoring files for which the conflict file exists
For issue #3106
1) Always use the actual timestamp from the file in the file system
to create the conflict file. This is important because if one edit a
file several time, they should have different name. Also it makes more
sens to have the mtime of the modified file.
2) Give the correct size to the job so we know when the temporary file
is complete in case of resuming.
Jenkins for ownCloud [Thu, 16 Apr 2015 06:18:36 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Olivier Goffart [Wed, 15 Apr 2015 13:31:47 +0000 (15:31 +0200)]
PropagateDownload: Read the mtime from the file system after writing it
Because file system like FAT only have two second accuracy and would result
in a upload if the mtime in the database is not the same as the one that was
downloaded
Issue #3103
Daniel Molkentin [Wed, 15 Apr 2015 13:33:17 +0000 (15:33 +0200)]
1.8.1 beta 1
Markus Goetz [Wed, 15 Apr 2015 12:58:27 +0000 (14:58 +0200)]
ConfigFile: Remove unused functions
Markus Goetz [Wed, 15 Apr 2015 10:31:08 +0000 (12:31 +0200)]
Translations: Attempt two for Serbian #3083
Jenkins for ownCloud [Wed, 15 Apr 2015 06:18:35 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Daniel Molkentin [Tue, 14 Apr 2015 18:00:42 +0000 (20:00 +0200)]
Sort folder sizes SelectiveSyncTreeView numerically
Fixes #3112
Markus Goetz [Tue, 14 Apr 2015 12:56:25 +0000 (14:56 +0200)]
LsColXMLParser: More testing 2
Markus Goetz [Tue, 14 Apr 2015 12:41:48 +0000 (14:41 +0200)]
LsColXMLParser: More testing
Klaas Freitag [Tue, 14 Apr 2015 11:45:09 +0000 (13:45 +0200)]
test xmlparser: Verify call to parse()
Klaas Freitag [Tue, 14 Apr 2015 06:37:06 +0000 (08:37 +0200)]
Added unit test for XML Parser class.
Klaas Freitag [Tue, 14 Apr 2015 06:36:17 +0000 (08:36 +0200)]
LsColJob: Create a XML parser object for better unit testability.
Klaas Freitag [Tue, 14 Apr 2015 11:41:51 +0000 (13:41 +0200)]
LsColXMLParser: let parse return bool.
Jenkins for ownCloud [Tue, 14 Apr 2015 06:18:33 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Markus Goetz [Mon, 13 Apr 2015 16:27:28 +0000 (18:27 +0200)]
Translations: Try to add Serbian #3083
Markus Goetz [Mon, 13 Apr 2015 14:04:24 +0000 (16:04 +0200)]
Discovery: Explicitly check for XML parser errors
..instead of relying that our state machine does not do anything in that case.
Markus Goetz [Mon, 13 Apr 2015 13:49:33 +0000 (15:49 +0200)]
Discovery: Initialize error with EIO in constructor
This is safer, initializing it in remote_vio_opendir_hook was enough though.
Markus Goetz [Mon, 13 Apr 2015 13:36:07 +0000 (15:36 +0200)]
Discovery: Initialize error with EIO
Markus Goetz [Mon, 13 Apr 2015 13:10:04 +0000 (15:10 +0200)]
Discovery: Add a sanity check when results are parsed
Markus Goetz [Mon, 13 Apr 2015 12:58:25 +0000 (14:58 +0200)]
CSync: Log if file_id is too long
Olivier Goffart [Mon, 13 Apr 2015 11:03:46 +0000 (13:03 +0200)]
Restore submodule
Klaas Freitag [Sun, 12 Apr 2015 10:59:25 +0000 (12:59 +0200)]
owncloudcmd: Filter out empty lines in selectivesync
Klaas Freitag [Sun, 12 Apr 2015 10:35:40 +0000 (12:35 +0200)]
Networkjobs: Only log a subset of the account url.
This avoids disclosing of user and password in the logfile which can
happen in some cases.
Jenkins for ownCloud [Sun, 12 Apr 2015 06:18:27 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 11 Apr 2015 06:18:26 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Christian Kamm [Fri, 10 Apr 2015 10:11:35 +0000 (12:11 +0200)]
ProtocolWidget: Fix adding of seconds. #2535
Christian Kamm [Fri, 10 Apr 2015 07:24:25 +0000 (09:24 +0200)]
AuthRedirect: Use the configured DAV path. #3082
Christian Kamm [Thu, 9 Apr 2015 11:38:52 +0000 (13:38 +0200)]
Handle redirect of auth request. #3082
Olivier Goffart [Thu, 9 Apr 2015 13:06:48 +0000 (15:06 +0200)]
Reconcile: Fix clang warning
csync_reconcile.c:159:26: warning: address of array 'tmp->path' will always evaluate to 'true' [-Wpointer-bool-conversion]
if( tmp->path ) {
~~ ~~~~~^~~~
csync_file_stat_s::path is an array so it is never null
What was meant here is to check if the string was not empty
Olivier Goffart [Thu, 9 Apr 2015 12:24:26 +0000 (14:24 +0200)]
Merge remote-tracking branch 'origin/1.8'
Jenkins for ownCloud [Thu, 9 Apr 2015 06:18:32 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Christian Kamm [Wed, 8 Apr 2015 13:30:07 +0000 (15:30 +0200)]
Discovery: Speed up initial run. #2796
Christian Kamm [Wed, 8 Apr 2015 08:50:08 +0000 (10:50 +0200)]
Sync: Fix sync of deletions during 503. #2894
Roeland Jago Douma [Mon, 16 Mar 2015 15:26:35 +0000 (16:26 +0100)]
Only show share dialog if we are connected.
Jocelyn Turcotte [Tue, 7 Apr 2015 14:55:04 +0000 (16:55 +0200)]
SyncEngine: Fix a crash in csync_vio_file_stat_copy #3051
In some cryptic cases where the getetag property wasn't returned by
the server, we might be trying to c_strdup a null pointer in
csync_vio_file_stat_copy.
At least avoid crashing in this case by looking for
CSYNC_VIO_FILE_STAT_FIELDS_ETAG, like csync_vio_file_stat_destroy
does.
Jocelyn Turcotte [Thu, 2 Apr 2015 13:16:33 +0000 (15:16 +0200)]
SyncEngine: Fix a crash caused by an invalid DiscoveryDirectoryResult::iterator #3051
The default constructor of the iterator points to NULL, which makes
it != end() but invalid to dereference.
Use an integer index instead to keep 0 as a valid default value that
can always correctly be checked against size().
Also make sure that no data is shared between threads by making the
csync_vio_file_stat_t copyable and passing it as const.
Christian Kamm [Wed, 8 Apr 2015 06:59:36 +0000 (08:59 +0200)]
Sharedialog: Fix compiler warnings.
Jenkins for ownCloud [Wed, 8 Apr 2015 06:18:30 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Klaas Freitag [Thu, 26 Mar 2015 17:08:06 +0000 (18:08 +0100)]
More GUI refinements.
Klaas Freitag [Thu, 26 Mar 2015 16:23:29 +0000 (17:23 +0100)]
ShareDialog: handle resize properly with elided text
Klaas Freitag [Thu, 26 Mar 2015 15:51:31 +0000 (16:51 +0100)]
ShareDialog: Some GUI rework requested by Jan.
Olivier Goffart [Tue, 7 Apr 2015 08:42:27 +0000 (10:42 +0200)]
Merge remote-tracking branch into 1.8
Olivier Goffart [Tue, 7 Apr 2015 08:35:27 +0000 (10:35 +0200)]
PropfindJob: fix xml parsing
It would only find the first property
Jenkins for ownCloud [Tue, 7 Apr 2015 06:18:46 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Olivier Goffart [Tue, 7 Apr 2015 06:02:55 +0000 (08:02 +0200)]
Merge remote-tracking branch into 1.8
Markus Goetz [Mon, 6 Apr 2015 19:46:03 +0000 (21:46 +0200)]
AbstractSslErrorHandler: Also give QSslConfiguration
Olivier Goffart [Mon, 6 Apr 2015 14:20:28 +0000 (16:20 +0200)]
AccountState: Fix uninitialized memory access spotted by valgrind
QuotaInfo's constructor uses the AccountState's _state which is
initialized after
Jenkins for ownCloud [Sat, 4 Apr 2015 06:18:40 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Olivier Goffart [Fri, 3 Apr 2015 09:27:06 +0000 (11:27 +0200)]
theme: fix compilation of libsync without QtGui
Jenkins for ownCloud [Fri, 3 Apr 2015 06:18:33 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Markus Goetz [Thu, 2 Apr 2015 14:52:53 +0000 (16:52 +0200)]
Discovery: Add warning if returned etag is 0
There will be another bugfix which fixes
https://gist.github.com/jturcotte/
3d5a7874d26bc27b1be9
directory.
Markus Goetz [Thu, 2 Apr 2015 13:18:19 +0000 (15:18 +0200)]
SyncEngine: Show more timing measurements #3064
Jenkins for ownCloud [Thu, 2 Apr 2015 06:18:44 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jocelyn Turcotte [Wed, 1 Apr 2015 12:45:05 +0000 (14:45 +0200)]
Clean up remains of SOCKETAPI_TCP
Jocelyn Turcotte [Wed, 1 Apr 2015 12:40:34 +0000 (14:40 +0200)]
Fix a crash on shutdown in ~SocketApi #3057
Deleting the QLocalSocket while iterating the QList with qDeleteAll
would trigger onLostConnection, which would modify the list mid-air
and leave dangling pointers in it.
Jocelyn Turcotte [Wed, 1 Apr 2015 11:45:04 +0000 (13:45 +0200)]
Windows: Add version information for owncloud.exe
This should help us know what version or build number a crash report was generated with.
Jenkins for ownCloud [Wed, 1 Apr 2015 06:18:37 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Tue, 31 Mar 2015 06:18:45 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Lukas Reschke [Mon, 30 Mar 2015 15:32:19 +0000 (17:32 +0200)]
Use 1.8 troubleshooting link
Daniel Molkentin [Mon, 30 Mar 2015 12:38:19 +0000 (14:38 +0200)]
Updater: Give context as to which app is about to be updated
Fixes #3040
Markus Goetz [Mon, 30 Mar 2015 06:41:37 +0000 (08:41 +0200)]
Propagator: Fix compile
Jenkins for ownCloud [Sun, 29 Mar 2015 06:18:47 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sun, 29 Mar 2015 05:15:23 +0000 (01:15 -0400)]
[tx-robot] updated from transifex
Jenkins for ownCloud [Sat, 28 Mar 2015 06:18:42 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Christian Kamm [Fri, 27 Mar 2015 12:19:17 +0000 (13:19 +0100)]
Remove unused HttpConfigFile.
Markus Goetz [Fri, 27 Mar 2015 12:16:11 +0000 (13:16 +0100)]
Propagator: Debug output regarding OC-ETag
We can remove this in some time, but currently it is interesting
to see for what server setup is no ETag but an OC-ETag.
Markus Goetz [Fri, 27 Mar 2015 12:15:43 +0000 (13:15 +0100)]
owncloudcmd: Always trail path with /
Else the csync code vs the Qt code get confused.
Markus Goetz [Fri, 27 Mar 2015 10:53:58 +0000 (11:53 +0100)]
Proxy: More debug, always set returned system proxy
Christian Kamm [Fri, 27 Mar 2015 08:07:21 +0000 (09:07 +0100)]
ProtocolWidget: Always add seconds to the DateTime locale. #2535
Christian Kamm [Fri, 27 Mar 2015 10:19:59 +0000 (11:19 +0100)]
Merge remote-tracking branch 'origin/1.8'
Conflicts:
doc/installing.rst
Christian Kamm [Fri, 27 Mar 2015 10:11:44 +0000 (11:11 +0100)]
Fix clang warnings about deleting incomplete 'Account'.
Markus Goetz [Fri, 27 Mar 2015 09:36:34 +0000 (10:36 +0100)]
Proxy: Fix compile harder
Christian Kamm [Fri, 27 Mar 2015 09:49:24 +0000 (10:49 +0100)]
CookieJar: Don't accidentally overwrite cookies. #2808
Calling save() in the CookieJar destructor was problematic. For instance
we sometimes create a new QNAM with a new CookieJar and then call
setCookieJar() on it to assign some other jar. That destroy the fresh
jar and potentially overwrite cookies.
Also explicitly saving the account's cookies when the account is saved
is more explicit and thus more reliable than counting on the Account
destructor to do it.
Christian Kamm [Fri, 27 Mar 2015 09:30:35 +0000 (10:30 +0100)]
Account: Destroy on exit.
During shutdown we want the account object to be deleted and
therefore we need to be able to remove the strong reference
in AccountManager.
Christian Kamm [Fri, 27 Mar 2015 09:24:09 +0000 (10:24 +0100)]
ConValidator: Delete instance if no credentials.
Christian Kamm [Thu, 26 Mar 2015 10:15:24 +0000 (11:15 +0100)]
HttpCreds: Delete password from old location. #2186
Jenkins for ownCloud [Fri, 27 Mar 2015 06:18:47 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Markus Goetz [Thu, 26 Mar 2015 17:36:37 +0000 (18:36 +0100)]
Proxy: Fix compile
Markus Goetz [Thu, 26 Mar 2015 14:17:02 +0000 (15:17 +0100)]
Qt4: Fix compile
Roeland Jago Douma [Thu, 19 Mar 2015 08:05:57 +0000 (09:05 +0100)]
On creation of a share always retrieve the share
This makes sure that if a default expiration date is set this is reflected in
the dialog. #2889
Christian Kamm [Wed, 25 Mar 2015 12:27:40 +0000 (13:27 +0100)]
HttpCreds: Fill pw dialog with previous password. #2848 #2879
Jenkins for ownCloud [Thu, 26 Mar 2015 06:18:43 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Markus Goetz [Wed, 25 Mar 2015 14:39:53 +0000 (15:39 +0100)]
SslButton: Make menu creation lazy
Saves ~200msec on my not-so-old MBP on OS X.
For #3007 #2990
Christian Kamm [Wed, 25 Mar 2015 13:57:23 +0000 (14:57 +0100)]
Themes: Cache icons instead of rebuilding a lot.
Markus Goetz [Wed, 25 Mar 2015 11:25:18 +0000 (12:25 +0100)]
Proxy: Fix issues with previous patch
This is for #2993 and #2802
Markus Goetz [Tue, 24 Mar 2015 20:30:42 +0000 (21:30 +0100)]
Proxy: Look up system proxy from different thread
We should actually upstream this into QNAM.
This is for #2993 and #2802
Markus Goetz [Tue, 24 Mar 2015 10:01:06 +0000 (11:01 +0100)]
Account: Unusued variable
Jenkins for ownCloud [Wed, 25 Mar 2015 06:18:53 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Daniel Molkentin [Tue, 24 Mar 2015 21:05:40 +0000 (22:05 +0100)]
Add user id param
Olivier Goffart [Tue, 24 Mar 2015 11:17:48 +0000 (12:17 +0100)]
Sync engine: Check the blacklist for the right tree
When the operation is download, we have a INSTRUCTION_NONE for the local
tree, but we should not check the blacklist just yet.
Jocelyn Turcotte [Tue, 24 Mar 2015 09:23:49 +0000 (10:23 +0100)]
Revert "Switch back to an existing sha"
This reverts commit
48c92225787336e3b2400c1ee174cc1f93a58cf0.
The submodule repository now has the required commit.
Jenkins for ownCloud [Tue, 24 Mar 2015 06:18:42 +0000 (02:18 -0400)]
[tx-robot] updated from transifex
Daniel Molkentin [Mon, 23 Mar 2015 21:40:57 +0000 (22:40 +0100)]
Switch back to an existing sha
Daniel Molkentin [Mon, 23 Mar 2015 21:22:54 +0000 (22:22 +0100)]
Add docker buildscript for win32
Carla Schroder [Mon, 23 Mar 2015 17:57:05 +0000 (10:57 -0700)]
add note re linux password managers