Claudio Cambra [Wed, 5 Jul 2023 15:32:08 +0000 (23:32 +0800)]
Ensure whitelist/blacklist procedure removes activity
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 14:05:21 +0000 (22:05 +0800)]
Add method to add notification activity in activity list in User
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 13:35:33 +0000 (21:35 +0800)]
Add method to get user pointer in UserModel by AccountState pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 09:17:28 +0000 (17:17 +0800)]
Handle WHITELIST_FOLDER and BLACKLIST_FOLDER verbs in activitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 09:16:36 +0000 (17:16 +0800)]
Add convenience methods to folderman so that classes can add and remove paths from folders without needing to know which folder the path belongs to
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 09:16:03 +0000 (17:16 +0800)]
Add methods to Folder so that other classes can easily add folder paths to white/blacklists
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 16:39:03 +0000 (00:39 +0800)]
Remove redundant "optional" gui log functions which relly just call gui log under the hood
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 15:55:05 +0000 (23:55 +0800)]
Add specific message for existing folders exceeding warning limit in accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 15:34:14 +0000 (23:34 +0800)]
Move findPathInList from discoveryphase to common syncjournaldb
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 15:33:00 +0000 (23:33 +0800)]
Clean up AccountSettings::refreshSelectiveSyncStatus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 14:32:58 +0000 (22:32 +0800)]
Do not notify about folders growing beyond threshold by default
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 14:26:11 +0000 (22:26 +0800)]
Ensure notify big folders checkbox state is changed when parent checkbox changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 14:03:50 +0000 (22:03 +0800)]
Do not notify if setting is not enabled for folders going over limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 08:24:58 +0000 (16:24 +0800)]
Hook up existing folder notification size checkbox in general settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 08:12:11 +0000 (16:12 +0800)]
Add config settings for notifying existing folders going over limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 07:36:57 +0000 (15:36 +0800)]
Add a checkbox in UI to obey folder size limit for existing folders
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 3 Jul 2023 17:21:03 +0000 (01:21 +0800)]
Properly check folder size on server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 3 Jul 2023 17:15:34 +0000 (01:15 +0800)]
Make checkFolderSizeLimit more task agnostic
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Jun 2023 11:39:09 +0000 (19:39 +0800)]
Create and connect specific signal for existing folder now being discovered to be big
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Jun 2023 11:33:22 +0000 (19:33 +0800)]
Add slot for existing folders becoming big in Folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Jun 2023 11:00:28 +0000 (19:00 +0800)]
Use single convenience method to handle trailing slash in paths for Folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Jun 2023 10:33:21 +0000 (18:33 +0800)]
Check selective sync state directories that have been updated and now have differing size
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 28 Jun 2023 10:21:40 +0000 (18:21 +0800)]
Add DiscoveryPhase::checkSelectiveSyncExistingFolder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Jun 2023 15:27:28 +0000 (23:27 +0800)]
Extract processServerNew into a proper method instead of large lambda
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Jun 2023 14:09:16 +0000 (22:09 +0800)]
Move active folder size limit check to independent convenience method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Jun 2023 07:56:30 +0000 (15:56 +0800)]
Clean up declaration of DiscoveryPhase::checkSelectiveSyncNewFolder by using const auto, renaming single letter variables, more
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 27 Jun 2023 07:28:53 +0000 (15:28 +0800)]
Const autofy variables in ProcessDirectoryJob::processFileAnalyzeRemoteInfo
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 4 Aug 2023 02:44:07 +0000 (02:44 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 3 Aug 2023 02:41:15 +0000 (02:41 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 2 Aug 2023 03:05:54 +0000 (03:05 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 1 Aug 2023 02:39:34 +0000 (02:39 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 31 Jul 2023 02:38:50 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 30 Jul 2023 02:34:23 +0000 (02:34 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 28 Jul 2023 02:47:03 +0000 (02:47 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 27 Jul 2023 02:31:58 +0000 (02:31 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 26 Jul 2023 14:57:07 +0000 (16:57 +0200)]
Merge pull request #5621 from nextcloud/feature/check-server-availibility-everyminute
Feature/check server availibility everyminute
alex-z [Mon, 24 Apr 2023 13:15:58 +0000 (15:15 +0200)]
Fix review comments.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 19 Apr 2023 18:52:51 +0000 (20:52 +0200)]
Iteration.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Wed, 19 Apr 2023 15:00:16 +0000 (17:00 +0200)]
Check server's 204 endpoint every minute and restore connection immidiately after successful status code.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Matthieu Gallien [Wed, 26 Jul 2023 14:15:08 +0000 (16:15 +0200)]
Merge pull request #5889 from m7913d/fixNonExistingPlaceholder
Convert VFS file to placeholder again if needed
Dries Mys [Tue, 25 Jul 2023 12:10:18 +0000 (14:10 +0200)]
Small coding improvements
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Dries Mys [Sat, 22 Jul 2023 22:01:45 +0000 (00:01 +0200)]
Alter testUnexpectedNonPlaceholder to better reflect the actual use case
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Dries Mys [Sat, 15 Jul 2023 19:03:11 +0000 (21:03 +0200)]
Convert VFS file to placeholder again if needed
Note that Windows may convert a placeholder file to a regular file when
it is replaced by another file, even if the old and new file (inode,
modified time, file size) are identical.
WIN32_FIND_DATA::dwReserved0 is only initialised in case of
FILE_ATTRIBUTE_REPARSE_POINT is set. This field is not a bit set. Check
corrected to only include all cloud reparse points and not other special
reparse points.
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
Nextcloud bot [Wed, 26 Jul 2023 03:08:38 +0000 (03:08 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 25 Jul 2023 19:37:30 +0000 (21:37 +0200)]
force MSI package to install all files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Tue, 25 Jul 2023 02:33:48 +0000 (02:33 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Tue, 25 Jul 2023 01:59:20 +0000 (03:59 +0200)]
Merge pull request #5408 from nextcloud/bugfix/errors-in-activity-list-sort
Ensure errors are displayed as first entries in tray window activity list, add testing for SortedActivityListModel
Claudio Cambra [Tue, 25 Jul 2023 00:42:09 +0000 (08:42 +0800)]
Use nodiscard in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 11:33:48 +0000 (19:33 +0800)]
Fix testing of sync result error activities in sorted activity list test
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 11:33:29 +0000 (19:33 +0800)]
Fix setting of sourcemodel in sorted activity list test
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 15:34:04 +0000 (16:34 +0100)]
Test sorted activity list model sort order
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 15:33:24 +0000 (16:33 +0100)]
Expose max activity data from activity list model in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 13:45:25 +0000 (14:45 +0100)]
Expose max activities in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 13:43:51 +0000 (14:43 +0100)]
Add convenience method in TestingALM to fetch more than maximum activities to be displayed in activitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 13:31:21 +0000 (14:31 +0100)]
Clean up declarations in activitylistmodel header, remove unused methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 13:06:36 +0000 (14:06 +0100)]
Fix fetch handling in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 12:36:18 +0000 (13:36 +0100)]
Expose insert dummy activity method in TestingALM
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 12:35:36 +0000 (13:35 +0100)]
Make TestingALM a friend class of ActivityListModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 12:16:37 +0000 (13:16 +0100)]
Add test to check that the sortedactivitylistmodel correctly gets updated when the sourcemodel does
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 11:52:34 +0000 (12:52 +0100)]
Verify sorted model is showing the rows in source activity model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 11:26:29 +0000 (12:26 +0100)]
Add SortedActivityListModel test
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 01:06:24 +0000 (02:06 +0100)]
Move creation of example activities from testactivitylistmodel to activitylistmodeltestutils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 00:52:22 +0000 (01:52 +0100)]
Move activitylistmodel testing QNAM override to dedicated convenience method in ActivityTestUtils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 1 Mar 2023 00:23:37 +0000 (01:23 +0100)]
Replace unnecessary folder include in ActivityData with SyncResult
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 28 Feb 2023 22:59:27 +0000 (23:59 +0100)]
Move TestingALM to activitylistmodeltestutils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 28 Feb 2023 22:50:49 +0000 (23:50 +0100)]
Move FakeRemoteActivityStorate to new activitylistmodeltestutils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 6 Feb 2023 15:45:48 +0000 (16:45 +0100)]
Place all sorts of sync file item status errors near the top
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 6 Feb 2023 15:37:02 +0000 (16:37 +0100)]
Move activity list SyncResult errors to the top of the list
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 6 Feb 2023 15:29:48 +0000 (16:29 +0100)]
Move activity list syncfileitemstatus errors to the top of the list
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 23:47:20 +0000 (01:47 +0200)]
Merge pull request #5602 from nextcloud/bugfix/clean-up-systray-mac
Clean up systray.mm (macOS)
Claudio Cambra [Mon, 24 Jul 2023 23:13:32 +0000 (07:13 +0800)]
Use QSharedPointer<T>::create for talk reply in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:26:03 +0000 (17:26 +0800)]
Fix spacing and indentation in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:14:11 +0000 (17:14 +0800)]
Modernise property accessing in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:06:51 +0000 (17:06 +0800)]
Use const auto for C++ variables in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Apr 2023 09:00:57 +0000 (17:00 +0800)]
Constify object pointers in systray.mm
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 10:43:27 +0000 (12:43 +0200)]
Merge pull request #5903 from nextcloud/bugfix/fix-findersyncext
Fix Finder Sync Extension
Claudio Cambra [Mon, 24 Jul 2023 10:02:15 +0000 (18:02 +0800)]
Operate directly on NSMutableData for incoming socket data, do not work with raw buffers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Jul 2023 06:02:20 +0000 (14:02 +0800)]
Use more informative NSAssert rather than assert for _registeredDirectories
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 21 Jul 2023 06:01:57 +0000 (14:01 +0800)]
Allocate new unsigned char buffer for processed line in heap, fixing crash
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 10:18:55 +0000 (18:18 +0800)]
Fix optional compile of File Provider module
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 08:35:53 +0000 (16:35 +0800)]
Fix BUILD_FILE_PROVIDER_MODULE check in application.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 20 Jul 2023 02:13:54 +0000 (10:13 +0800)]
Do not GENERATE_INFOPLIST_FILE for FinderSyncExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 23:46:45 +0000 (07:46 +0800)]
Correctly initialise internal data members for FinderSync
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 23:46:16 +0000 (07:46 +0800)]
Define FinderSync internal data members as private interface extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 15:00:29 +0000 (23:00 +0800)]
Use modern dot notation to access _inBuffer properties
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 14:51:50 +0000 (22:51 +0800)]
Add quotes to processed line in FinderSyncExt to easily demarcate received line start and end
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 14:50:36 +0000 (22:50 +0800)]
Fix parsing of in buffer lines in FinderSyncExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 19 Jul 2023 14:03:16 +0000 (22:03 +0800)]
Clean up FinderSyncExt processInBuffer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Mon, 24 Jul 2023 02:32:09 +0000 (02:32 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
István Váradi [Sat, 22 Jul 2023 14:10:02 +0000 (16:10 +0200)]
Remove Ubuntu Kinetic, add Mantic
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
Nextcloud bot [Sun, 23 Jul 2023 02:33:43 +0000 (02:33 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Sat, 22 Jul 2023 10:56:52 +0000 (12:56 +0200)]
Merge pull request #5468 from nextcloud/work/sparkle-bumps
Improve macOS Sparkle updater
Claudio Cambra [Thu, 13 Jul 2023 10:13:07 +0000 (18:13 +0800)]
Convert directly from QUrl to NSURL
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 15:10:47 +0000 (16:10 +0100)]
Clean up declaration in SparkleUpdater header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 15:08:49 +0000 (16:08 +0100)]
Fix localisation of updater status strings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 14:20:47 +0000 (15:20 +0100)]
Properly handle skipping auto update checks in the sparkle updater
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 14:03:51 +0000 (15:03 +0100)]
Only instantiate sparkle updater if autoupdating is available
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 13:34:35 +0000 (14:34 +0100)]
Fix qbytearray related clazy warnings in objective-c++ sparkle updater side
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 13:25:03 +0000 (14:25 +0100)]
Only enable check for update button when the sparkle updater is not working
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 23 Feb 2023 13:23:33 +0000 (14:23 +0100)]
Implement proper notifying of sparkle updater state changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
projects / nextcloud-desktop.git / log