Claudio Cambra [Tue, 1 Aug 2023 08:00:39 +0000 (16:00 +0800)]
Remember server colors across restarts, enabling correct color before capabilities fetched
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Claudio Cambra [Tue, 1 Aug 2023 08:00:17 +0000 (16:00 +0800)]
Only update private colors if received capabilities colors are valid
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Claudio Cambra [Tue, 1 Aug 2023 07:55:41 +0000 (15:55 +0800)]
Store server color in private member of account when capabilities fetched
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
Matthieu Gallien [Wed, 23 Aug 2023 09:54:41 +0000 (11:54 +0200)]
Merge pull request #5798 from nextcloud/bugfix/doNotFlushLogEachLine
only flush debug log files when closing them
Matthieu Gallien [Mon, 12 Jun 2023 15:02:51 +0000 (17:02 +0200)]
only flush debug log files when closing them
do not force a flush every time a log line is added to a file to speed
up the logging process
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Wed, 23 Aug 2023 02:42:31 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Wed, 23 Aug 2023 01:29:54 +0000 (09:29 +0800)]
Merge pull request #5969 from nextcloud/feature/warn-before-encrypt
Add warning prior to folder encryption, prevent unknowing users from creating unrecoverable encrypted folders
Claudio Cambra [Fri, 11 Aug 2023 07:05:42 +0000 (15:05 +0800)]
Add warning prior to folder encryption to prevent unknowing users from creating unrecoverable encrypted folders
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 22 Aug 2023 20:44:53 +0000 (04:44 +0800)]
Merge pull request #5972 from nextcloud/bugfix/encrypt-problem-folders
Fix user-facing message about why encryption cannot yet be done
Claudio Cambra [Fri, 11 Aug 2023 07:08:32 +0000 (15:08 +0800)]
Fix warning dialog box message when trying to encrypt folders that have not been successfully synced (i.e. error/problem)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 22 Aug 2023 16:56:36 +0000 (18:56 +0200)]
Merge pull request #5975 from nextcloud/bugfix/accented-filedetails
Make file details tray follow current account accent colour
Claudio Cambra [Tue, 15 Aug 2023 07:29:32 +0000 (15:29 +0800)]
Also accent ncBlue buttons in ShareDetailsPage with user accent color
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 15 Aug 2023 07:10:41 +0000 (15:10 +0800)]
Colour coloured elements in share view with user accent colour
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 15 Aug 2023 07:00:19 +0000 (15:00 +0800)]
Make accent colour of NCTabButton in file details follow user accent colour
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 22 Aug 2023 15:59:46 +0000 (17:59 +0200)]
Merge pull request #5996 from nextcloud/ci/updateCiImages
update main CI image to get newer Qt, Java and other dependencies
Joas Schilling [Tue, 22 Aug 2023 12:51:37 +0000 (14:51 +0200)]
Sign .drone.yml
Signed-off-by: Joas Schilling <coding@schilljs.com>
Matthieu Gallien [Tue, 22 Aug 2023 11:47:41 +0000 (13:47 +0200)]
update main CI image to get newer Qt, Java and other dependencies
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Claudio Cambra [Tue, 22 Aug 2023 13:59:36 +0000 (21:59 +0800)]
Merge pull request #5966 from nextcloud/feature/generate-password-for-require-password-share
Generate a suggested password when server requires password for share creation
Claudio Cambra [Fri, 11 Aug 2023 04:20:23 +0000 (12:20 +0800)]
Suggest a password when password is enforced on server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 11 Aug 2023 03:04:25 +0000 (11:04 +0800)]
Move createRandomPassword to public static Q_INVOKABLE method of ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Matthieu Gallien [Tue, 22 Aug 2023 09:00:24 +0000 (11:00 +0200)]
Merge pull request #5948 from nextcloud/bugfix/share-password-entry-display
Hide password field in share settings when share type does not support passwords
Claudio Cambra [Wed, 2 Aug 2023 09:01:01 +0000 (17:01 +0800)]
Hide password field in share settings when share type does not support passwords
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 22 Aug 2023 03:09:34 +0000 (03:09 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Mon, 21 Aug 2023 14:37:45 +0000 (16:37 +0200)]
Merge pull request #5978 from nextcloud/bugfix/lockUnlockVirtualFiles
update read-only status of virtual files when needed for lock state
Matthieu Gallien [Fri, 18 Aug 2023 14:24:30 +0000 (16:24 +0200)]
update read-only status of virtual files when needed for lock state
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 21 Aug 2023 09:31:56 +0000 (11:31 +0200)]
add an automated test to check that locked files are read-only
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Thu, 17 Aug 2023 02:47:17 +0000 (02:47 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Wed, 16 Aug 2023 11:50:50 +0000 (13:50 +0200)]
Merge pull request #5971 from nextcloud/bugfix/fixFilenameEncodingTestOnWindows
on windows file names can always be encoded: fix wrong test
Matthieu Gallien [Mon, 14 Aug 2023 16:40:49 +0000 (18:40 +0200)]
on windows file names can always be encoded: fix wrong test
inspired by https://github.com/owncloud/client/pull/6820
Close #5935
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 14 Aug 2023 17:43:31 +0000 (19:43 +0200)]
test that discovery of file names with UTF-8 is working
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Nextcloud bot [Wed, 16 Aug 2023 02:35:11 +0000 (02:35 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 15 Aug 2023 03:13:17 +0000 (03:13 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 14 Aug 2023 02:42:12 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 13 Aug 2023 02:35:32 +0000 (02:35 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 12 Aug 2023 02:42:20 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 11 Aug 2023 16:26:08 +0000 (00:26 +0800)]
Merge pull request #5965 from nextcloud/feature/allow-resharing-share
Add "Allow resharing" option to share dialog
Claudio Cambra [Thu, 10 Aug 2023 23:33:49 +0000 (07:33 +0800)]
More distinctly name server allowing resharing property
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 10 Aug 2023 08:55:33 +0000 (16:55 +0800)]
Hide 'Allow resharing' checkbox when resharing not allowed by server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 10 Aug 2023 08:54:35 +0000 (16:54 +0800)]
Add resharing allowed property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 10 Aug 2023 08:14:24 +0000 (16:14 +0800)]
Make busy indicator for share permissions cover all share permission check/radio boxes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 10 Aug 2023 08:03:34 +0000 (16:03 +0800)]
Add checkbox in share details page for resharing allowed setting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 10 Aug 2023 08:03:14 +0000 (16:03 +0800)]
Add role for resharing allowed in share model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 10 Aug 2023 06:58:05 +0000 (14:58 +0800)]
Fix share permission values
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Fri, 11 Aug 2023 02:41:23 +0000 (02:41 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Thu, 10 Aug 2023 02:42:45 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 9 Aug 2023 03:04:11 +0000 (03:04 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 8 Aug 2023 02:44:13 +0000 (02:44 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Mon, 7 Aug 2023 09:28:37 +0000 (17:28 +0800)]
Merge pull request #5872 from nextcloud/work/do-not-mod-new-files-unnecessarily
Do not modify discovered files on disk if not necessary
Claudio Cambra [Mon, 7 Aug 2023 00:24:43 +0000 (08:24 +0800)]
Set modificationHappened to also depend on file size change
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 13 Jul 2023 13:04:07 +0000 (21:04 +0800)]
Add test for unmodified local files not getting mtimes changed upon upload to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 11 Jul 2023 07:37:29 +0000 (15:37 +0800)]
Add find method to DiskFileModifier class in SyncEngineTestUtils
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 05:00:28 +0000 (13:00 +0800)]
Ensure file modification time is set if item modtime differs from journal modtime
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 7 Jul 2023 11:15:54 +0000 (19:15 +0800)]
Only attempt conversion to placeholder on new file if VFS enabled in SyncEngine::slotItemDiscovered
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 7 Jul 2023 11:15:03 +0000 (19:15 +0800)]
Only change modification time if any modifications were actually made on downsynced file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 7 Jul 2023 11:14:09 +0000 (19:14 +0800)]
Return bool from FileSystem::setFileReadOnlyWeak depending on whether permission change was actually made or not
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Fri, 7 Jul 2023 11:11:59 +0000 (19:11 +0800)]
Unify else and if in SyncEngine::slotItemDiscovered for filesystem setmodtime check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Mon, 7 Aug 2023 02:41:59 +0000 (02:41 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 6 Aug 2023 02:37:40 +0000 (02:37 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 5 Aug 2023 02:41:35 +0000 (02:41 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Fri, 4 Aug 2023 10:29:56 +0000 (18:29 +0800)]
Merge pull request #5868 from nextcloud/work/folder-threshold-improve
Add option to notify when synced folder overcomes set size limit
Claudio Cambra [Thu, 3 Aug 2023 09:24:32 +0000 (17:24 +0800)]
Add additional logging for folder size check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 07:34:39 +0000 (15:34 +0800)]
Deduplicate whitelistFolderPath and blacklistFolderPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 07:25:15 +0000 (15:25 +0800)]
Extract folder now big activity generation into separate method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 07:19:22 +0000 (15:19 +0800)]
Extract notifying of existing folder now big to separate static method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 07:13:51 +0000 (15:13 +0800)]
Declare whitelist and blacklist activity verbs as static constexprs in activitydata, refer to this in usage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 07:00:55 +0000 (15:00 +0800)]
Fix breakages in testactivitylistmodel caused by recent activitylistmodel changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 07:00:20 +0000 (15:00 +0800)]
Fix generation of context menu activity links
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Thu, 3 Aug 2023 06:59:58 +0000 (14:59 +0800)]
Ensure generated activity buttons are within count set by maxActionButtons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 09:11:47 +0000 (17:11 +0800)]
Do not clear the whitelist on sync success
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 09:05:44 +0000 (17:05 +0800)]
Do not always re-notify user on existing folder now big if this folder already black or white listed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 08:06:00 +0000 (16:06 +0800)]
Stop current sync when existing folder becomes big and we have enabled disabling sync of folders that become big
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 07:50:03 +0000 (15:50 +0800)]
Add UI element in general settings to stop syncing existing folders that have now overcome limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 24 Jul 2023 07:46:39 +0000 (15:46 +0800)]
Add config option to stop synchronising existing folders when they grow beyond size
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 18 Jul 2023 09:19:39 +0000 (17:19 +0800)]
Add test for correct reporting of existing folder overcoming size limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 18 Jul 2023 09:17:51 +0000 (17:17 +0800)]
Report size for directories in syncenginetestutils propfind response
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:51:24 +0000 (17:51 +0800)]
Replace all manual isntancesof adding trailing slash with use of utility method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:27:58 +0000 (17:27 +0800)]
Move trailingSlashPath convenience function into Utility class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:22:14 +0000 (17:22 +0800)]
Fix trailing slash procedure in DiscoveryPhase::checkSelectiveSyncNewFolder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:21:40 +0000 (17:21 +0800)]
Use simpler sort methods for white and black lists in discoveryphase
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:20:44 +0000 (17:20 +0800)]
Remove use of old foreach in SyncJournalDb::setSelectiveSyncList
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:20:23 +0000 (17:20 +0800)]
Constify SyncJournalDb::findPathInSelectiveSyncList
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 10 Jul 2023 09:14:40 +0000 (17:14 +0800)]
Const autofy variables in ProcessDirectoryJob::processFile
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 18:47:05 +0000 (02:47 +0800)]
Default to adding existing now big folders to whitelist when undecided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 18:38:49 +0000 (02:38 +0800)]
Ensure folder whitelist and blacklist helper methods remove path from other lists
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 18:38:23 +0000 (02:38 +0800)]
Prevent possible accountsettings crash by sorting blacklist before checking
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 18:24:10 +0000 (02:24 +0800)]
Prevent double notification of folder now big in activities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 15:44:45 +0000 (23:44 +0800)]
Ensure newly whitelisted or blacklisted paths are removed from undecided list
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 15:35:13 +0000 (23:35 +0800)]
Add activity for existing folder going over set limit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 15:33:43 +0000 (23:33 +0800)]
Do not create dismiss links for notifications as these are not used anyway
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 15:32:46 +0000 (23:32 +0800)]
Create more than one converted activity link, therby respecting maxactionbuttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 15:32:08 +0000 (23:32 +0800)]
Ensure whitelist/blacklist procedure removes activity
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 14:05:21 +0000 (22:05 +0800)]
Add method to add notification activity in activity list in User
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 13:35:33 +0000 (21:35 +0800)]
Add method to get user pointer in UserModel by AccountState pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 09:17:28 +0000 (17:17 +0800)]
Handle WHITELIST_FOLDER and BLACKLIST_FOLDER verbs in activitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 09:16:36 +0000 (17:16 +0800)]
Add convenience methods to folderman so that classes can add and remove paths from folders without needing to know which folder the path belongs to
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 5 Jul 2023 09:16:03 +0000 (17:16 +0800)]
Add methods to Folder so that other classes can easily add folder paths to white/blacklists
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 16:39:03 +0000 (00:39 +0800)]
Remove redundant "optional" gui log functions which relly just call gui log under the hood
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 15:55:05 +0000 (23:55 +0800)]
Add specific message for existing folders exceeding warning limit in accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 15:34:14 +0000 (23:34 +0800)]
Move findPathInList from discoveryphase to common syncjournaldb
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 4 Jul 2023 15:33:00 +0000 (23:33 +0800)]
Clean up AccountSettings::refreshSelectiveSyncStatus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
projects / nextcloud-desktop.git / log