gtk4.git
7 years agoadjustment: Remove adjustment_changed_stamp
Timm Bäder [Fri, 23 Mar 2018 13:22:45 +0000 (14:22 +0100)]
adjustment: Remove adjustment_changed_stamp

7 years agotestsuite: Print tested property name in notify test
Timm Bäder [Fri, 23 Mar 2018 12:55:01 +0000 (13:55 +0100)]
testsuite: Print tested property name in notify test

7 years agoadjustment: Use public setters in set_property
Timm Bäder [Fri, 23 Mar 2018 12:48:31 +0000 (13:48 +0100)]
adjustment: Use public setters in set_property

7 years agothemes: Regenerate CSS for recent commits
Daniel Boles [Wed, 20 Jun 2018 18:25:04 +0000 (19:25 +0100)]
themes: Regenerate CSS for recent commits

e.g. the box.linked one, which didn't update the compiled CSS.

7 years agoHC: Avoid excessive selectors from prev commit
Daniel Boles [Wed, 20 Jun 2018 18:23:59 +0000 (19:23 +0100)]
HC: Avoid excessive selectors from prev commit

The new rule does not need to affect all those other pseudoclasses. I
just put it in the wrong scope.

7 years agoHC: Avoid same BG/FG colors in flat treeview entry
Daniel Boles [Wed, 20 Jun 2018 17:32:49 +0000 (18:32 +0100)]
HC: Avoid same BG/FG colors in flat treeview entry

Selected rows in tree views in HighContrast have a background colour the
same or nearly as the normal text colour, so we cannot let entries in
such rows have transparent backgrounds, or the text inside the entry
becomes nearly or totally impossible to see.

Dodge this by giving entry.flat inside treeview and with :focus the
$base_color, which is different from the text & so lets that be seen.

https://gitlab.gnome.org/GNOME/gtk/merge_requests/125

7 years agosearchenginetracker: Don't leak the hits' GFiles
Daniel Boles [Wed, 20 Jun 2018 08:54:16 +0000 (09:54 +0100)]
searchenginetracker: Don't leak the hits' GFiles

https://gitlab.gnome.org/GNOME/gtk/merge_requests/206

7 years agoMerge branch 'issue1084' into 'master'
Matthias Clasen [Wed, 20 Jun 2018 15:34:51 +0000 (15:34 +0000)]
Merge branch 'issue1084' into 'master'

application: Complete the startup sequence before quitting remote instances

Closes #979

See merge request GNOME/gtk!156

7 years agoMerge branch 'master' into 'issue1084'
Matthias Clasen [Wed, 20 Jun 2018 14:21:24 +0000 (14:21 +0000)]
Merge branch 'master' into 'issue1084'

# Conflicts:
#   gdk/gdk.c

7 years agowindow: Remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 19:50:33 +0000 (21:50 +0200)]
window: Remove priv pointer

7 years agopathbar: Remove unused define
Timm Bäder [Mon, 18 Jun 2018 19:18:34 +0000 (21:18 +0200)]
pathbar: Remove unused define

7 years agodocs: Remove a duplicate line in gdk4-sections.txt
Matthias Clasen [Tue, 19 Jun 2018 20:59:20 +0000 (16:59 -0400)]
docs: Remove a duplicate line in gdk4-sections.txt

This was causing another docs build break.

7 years agodocs: fix a typo
Matthias Clasen [Tue, 19 Jun 2018 20:46:53 +0000 (16:46 -0400)]
docs: fix a typo

Invalid syntax in gdk4-sections.txt was causing docs builds to fail.

7 years agoMerge branch '1160-crash-clearing-gtkentry-icon-tooltip-master' into 'master'
Daniel Boles [Tue, 19 Jun 2018 20:22:38 +0000 (20:22 +0000)]
Merge branch '1160-crash-clearing-gtkentry-icon-tooltip-master' into 'master'

Resolve "Crash clearing GtkEntry icon tooltip"

Closes #1160

See merge request GNOME/gtk!205

7 years agowin32: Fix typo
Benjamin Otte [Tue, 19 Jun 2018 19:45:44 +0000 (21:45 +0200)]
win32: Fix typo

This should fix gtk-doc erroring out.

7 years agoRevert "Add aligned allocator functions to GSK"
Benjamin Otte [Tue, 19 Jun 2018 17:54:19 +0000 (19:54 +0200)]
Revert "Add aligned allocator functions to GSK"

This reverts commit 8e74eb382f0c617b7b65a6850952d6acc9fd3018.

This code is not necessary. It worked around a bug in graphene where
graphene was requiring stricter alignment than glib allocators could
guarantee.

7 years agoRevert "Use aligned allocators for GtkSnapshot"
Benjamin Otte [Tue, 19 Jun 2018 17:52:52 +0000 (19:52 +0200)]
Revert "Use aligned allocators for GtkSnapshot"

This reverts commit c02bc22cc575470aab870599f2781c3781fb75e6.

This code is not necessary.
The bug causing this problem ws prsent in the graphene library.

7 years agorendernodepaintable: Fix rendering position
Benjamin Otte [Tue, 19 Jun 2018 17:43:12 +0000 (19:43 +0200)]
rendernodepaintable: Fix rendering position

When the given size had an offset, we were moving that offset in the
wrong direction.

7 years agodnd: Use a GtkPicture in gtk_dnd_set_icon_paintable()
Benjamin Otte [Tue, 19 Jun 2018 17:41:49 +0000 (19:41 +0200)]
dnd: Use a GtkPicture in gtk_dnd_set_icon_paintable()

We don't want to get the paintable scaled down to icon size.

Also set can-shrink = FALSE to replicate GTK3 behavior with size
requests.

7 years agosnapshot: Compute correct size in gtk_snapshot_to_paintable()
Benjamin Otte [Tue, 19 Jun 2018 17:40:37 +0000 (19:40 +0200)]
snapshot: Compute correct size in gtk_snapshot_to_paintable()

Also, do actually respect the passed in size argument if it isn't NULL.

Fixes text being cut off inside DND icons.

7 years agodnd: gdk_drag_action_is_unique() should return a boolean
Benjamin Otte [Tue, 19 Jun 2018 14:47:36 +0000 (16:47 +0200)]
dnd: gdk_drag_action_is_unique() should return a boolean

7 years agoa11y/entry: Fix copy-pasteo re 2ndary icon tooltip
Daniel Boles [Tue, 19 Jun 2018 17:30:34 +0000 (18:30 +0100)]
a11y/entry: Fix copy-pasteo re 2ndary icon tooltip

The else case was wrongly resetting the accessible description on the
primary icon, which might not exist and can therefore cause a crash.

https://gitlab.gnome.org/GNOME/gtk/issues/1160

7 years agoMerge branch 'wip/carlosg/issue-1159' into 'master'
Matthias Clasen [Tue, 19 Jun 2018 16:40:39 +0000 (16:40 +0000)]
Merge branch 'wip/carlosg/issue-1159' into 'master'

Fix issue 1159

Closes #1159

See merge request GNOME/gtk!202

7 years agoUpdate POTFILES.in
Piotr Drąg [Tue, 19 Jun 2018 15:52:13 +0000 (17:52 +0200)]
Update POTFILES.in

7 years agowayland: Use shm_open(SHM_ANON) on FreeBSD
myfreeweb [Tue, 19 Jun 2018 14:49:18 +0000 (14:49 +0000)]
wayland: Use shm_open(SHM_ANON) on FreeBSD

This functionality is similar to Linux's memfd. It creates anonymous shared memory without touching the filesystem, which allows it to work in Capsicum capability mode (sandbox).

7 years agogtkgesture: Check claimed status after event delivery
Carlos Garnacho [Tue, 19 Jun 2018 11:38:09 +0000 (13:38 +0200)]
gtkgesture: Check claimed status after event delivery

The claimed status check should happen after ::end is emitted,
as the gesture may deny the sequence that much late. In this
case the event should keep propagating.

https://gitlab.gnome.org/GNOME/gtk/issues/1159

Closes: #1159
7 years agogtkwidget: Avoid doubly coordinate conversion when emulating press
Carlos Garnacho [Tue, 19 Jun 2018 11:17:57 +0000 (13:17 +0200)]
gtkwidget: Avoid doubly coordinate conversion when emulating press

We are poking again into the event propagation machinery, which
expects events in toplevel coordinates. Since we can't fetch the
original event back at this point, translate the coordinates
back to the toplevel so the emulated press ends up in the right
place.

https://gitlab.gnome.org/GNOME/gtk/issues/1159

Closes: #1159
7 years agox11: Set background as transparent as possible
Benjamin Otte [Mon, 18 Jun 2018 14:26:06 +0000 (16:26 +0200)]
x11: Set background as transparent as possible

Instead of making the background black, make it transparent black for
RGBA visuals and set a None background otherwise.

7 years agowidget: Remove time argument from drag_data_get() vfunc
Benjamin Otte [Sat, 16 Jun 2018 02:49:47 +0000 (04:49 +0200)]
widget: Remove time argument from drag_data_get() vfunc

7 years agodnd: Remove unused time arguments
Benjamin Otte [Sat, 16 Jun 2018 02:34:48 +0000 (04:34 +0200)]
dnd: Remove unused time arguments

7 years agodnd: Remove GdkDragContext.dest_surface
Benjamin Otte [Fri, 15 Jun 2018 06:39:51 +0000 (08:39 +0200)]
dnd: Remove GdkDragContext.dest_surface

The variable is now unused

7 years agoGDK W32: Remove gdk_win32_surface_foreign_new_for_display
Руслан Ижбулатов [Sat, 16 Jun 2018 17:18:54 +0000 (17:18 +0000)]
GDK W32: Remove gdk_win32_surface_foreign_new_for_display

That function is now unused.

7 years agoGDK W32: Adapt to dest_surface removal, misc changes
Руслан Ижбулатов [Sat, 16 Jun 2018 17:13:19 +0000 (17:13 +0000)]
GDK W32: Adapt to dest_surface removal, misc changes

* There's no GdkDragContext->dest_surface anymore.
  Add dest_window field to GdkWin32DragContext,
  and use that instead.
* Remove unused function prototypes
* Add more comments
* Rename variables and fields from 'window' to 'surface'
  where appropriate
* Fix header indentation a bit
* Try to ensure that uninitialized/unknown handle variables
  and fields are set to INVALID_HANDLE_VALUE instead of NULL,
  as there may be cases where NULL is a valid handle value.

7 years agodnd: Remove GdkDragContext.is_source
Benjamin Otte [Fri, 15 Jun 2018 06:48:27 +0000 (08:48 +0200)]
dnd: Remove GdkDragContext.is_source

All drag contexts are sources these days, the other ones are GdkDrop
now.

7 years agox11: Remove gdk_x11_surface_foreign_new_for_display()
Benjamin Otte [Fri, 15 Jun 2018 06:38:19 +0000 (08:38 +0200)]
x11: Remove gdk_x11_surface_foreign_new_for_display()

People who want to use foreign windows should use X directly.

7 years agox11: Store the XID instead of a GdkSurface
Benjamin Otte [Fri, 15 Jun 2018 06:35:14 +0000 (08:35 +0200)]
x11: Store the XID instead of a GdkSurface

This might be foreign Windows and we don't want to create surfaces for
those.

Also, stop using GdkDragContext.dest_surface, that variable is meant to
go away.

7 years agox11: Simplify test
Benjamin Otte [Fri, 15 Jun 2018 06:12:33 +0000 (08:12 +0200)]
x11: Simplify test

Now that we have gdk_drag_context_get_display(), use it.

7 years agox11: xdnd_send_event() always returns TRUE
Benjamin Otte [Fri, 15 Jun 2018 06:00:41 +0000 (08:00 +0200)]
x11: xdnd_send_event() always returns TRUE

Make it return nothing instead and delete the code that handled the
FALSE case.

7 years agox11: Don't multiply X values by the scale factor
Benjamin Otte [Fri, 15 Jun 2018 05:57:45 +0000 (07:57 +0200)]
x11: Don't multiply X values by the scale factor

This is fallout from a too eager change in
bdb442be21471a91820219347b1345ed7b84d034.

7 years agodnd: Make the base Drag/Drop types abstract
Benjamin Otte [Thu, 14 Jun 2018 03:13:13 +0000 (05:13 +0200)]
dnd: Make the base Drag/Drop types abstract

This way, they'll be ignored by the testsuite.

And we don't want to instantiate them anyway, the backends have
their own subclasses.

7 years agodnd: GdkDragContext is no longer a GdkDrop subclass
Benjamin Otte [Thu, 14 Jun 2018 02:58:50 +0000 (04:58 +0200)]
dnd: GdkDragContext is no longer a GdkDrop subclass

This includes a bunch of header cleanup

7 years agodnd: Remove gdk_drag_status() and gdk_drag_finish()
Benjamin Otte [Thu, 14 Jun 2018 02:57:10 +0000 (04:57 +0200)]
dnd: Remove gdk_drag_status() and gdk_drag_finish()

Those functions are unused and have been replaced by their equivalents
gdk_drop_status() and gdk_drop_finish().

7 years agosurface: Kill event masks
Benjamin Otte [Thu, 14 Jun 2018 02:13:59 +0000 (04:13 +0200)]
surface: Kill event masks

In particular, this patch removes:
  gdk_surface_get_events()
  gdk_surface_set_events()
  gdk_surface_get_device_events()
  gdk_surface_set_device_events()

Event masks so far still exist for grabs.

7 years agox11: Store the source surface as an XID
Benjamin Otte [Thu, 14 Jun 2018 01:41:57 +0000 (03:41 +0200)]
x11: Store the source surface as an XID

Don't create a foreign GDK surface, just store the XID.

With this, we can avoid GDK APIs that we want to get rid of and just
use the X counterpart.

7 years agox11: Split drag and drop contexts
Benjamin Otte [Thu, 14 Jun 2018 00:47:56 +0000 (02:47 +0200)]
x11: Split drag and drop contexts

While doing so, turn the drop context into a GdkDrop subclass and no
longer pretend to be a GdkDragContext.

7 years agox11: Handle events on drag side differently
Benjamin Otte [Wed, 13 Jun 2018 19:36:23 +0000 (21:36 +0200)]
x11: Handle events on drag side differently

Instead of using the filters that the drop side uses, handle events in
the event filter installed by the DragContext.

7 years agox11: Change the way local Drop => Drag is shortcut
Benjamin Otte [Wed, 13 Jun 2018 13:30:43 +0000 (15:30 +0200)]
x11: Change the way local Drop => Drag is shortcut

This is one step further towards untangling drag and drop parts of X11
DND.

7 years agox11: Remove unused argument
Benjamin Otte [Wed, 13 Jun 2018 03:41:39 +0000 (05:41 +0200)]
x11: Remove unused argument

The propagate argument is always FALSE, so just use FALSE everywhere.

7 years agox11: switch a bunch of variable types
Benjamin Otte [Wed, 13 Jun 2018 03:32:08 +0000 (05:32 +0200)]
x11: switch a bunch of variable types

GdkDragContext => GdkDrop

This is all in preparation of separation of the drag and drop.

Also, don't check for GDK_DRAG_PROTO_XDND anymore - it's the only
possible value for the protocol on the target side.

7 years agobroadway: Remove unused variable
Benjamin Otte [Wed, 13 Jun 2018 02:54:27 +0000 (04:54 +0200)]
broadway: Remove unused variable

7 years agodnd: Remove gdk_drag_context_get_dest_surface()
Benjamin Otte [Wed, 6 Jun 2018 05:43:58 +0000 (07:43 +0200)]
dnd: Remove gdk_drag_context_get_dest_surface()

... and gdk_drag_context_get_source_surface().

In the backends, use direct access to the variables instead.

7 years agodnd: Implement gtk_drag_get_source_widget() differently
Benjamin Otte [Thu, 7 Jun 2018 03:18:52 +0000 (05:18 +0200)]
dnd: Implement gtk_drag_get_source_widget() differently

Instead of keeping a list of source contexts, just use the current
drag's info.

7 years agox11: Replace the hardcoded DND filter
Benjamin Otte [Wed, 6 Jun 2018 02:55:55 +0000 (04:55 +0200)]
x11: Replace the hardcoded DND filter

Use the new method of connecting to the xevent signal instead.

Also, don't consume the xevent, there might be other code listening for
it. And we don't use PropertyNotify in the generic code path anymore, so
it'll just be ignored there.

7 years agoGDK W32: Remove unused files
Руслан Ижбулатов [Tue, 5 Jun 2018 23:37:10 +0000 (23:37 +0000)]
GDK W32: Remove unused files

7 years agoGDK W32: Adapt to GdkDrop and GdkDragContext changes
Руслан Ижбулатов [Tue, 5 Jun 2018 23:03:51 +0000 (23:03 +0000)]
GDK W32: Adapt to GdkDrop and GdkDragContext changes

* Remove clipdrop->dnd_target_state, it's not used anymore
* Remove non-functioning _gdk_dropfiles_store(), store dropfiles
  list in GdkWin32Drop instead
* Fix multiple comment typos
* Fix _gdk_win32_get_clipboard_format_name_as_interned_mimetype() to
  leave names that look like mime/types alone
* Refactor _gdk_win32_add_w32format_to_pairs() to populate
  GdkContentFormatsBuilder directly, instead of making a GList
* Rename context -> drag (still using GdkDragContext type,
  but [almost?] all variables and comments say "drag" now)
* Rename GdkDropContext -> GdkDrop
* Rename some parameter names for clarity
* Rewrite local protocol to look more like OLE2 protocol
  instead of mirroring the structure of the X11 API.
* Add handle_events field to GdkWin32DragContext,
  to shut off event handling (temporary fix until GTK is patched up)
* Remove _gdk_win32_drag_context_find() - the drag object is stored
  in GdkDrop instead. Use _gdk_win32_find_drag_for_dest_surface()
  to get it initially.
* Remove target_ctx_for_window, droptarget context is stored
  in the surface instead.
* Call gdk_drag_context_set_cursor() just like wayland backend does
  (slightly broken for now)
* Clean up the action choosing code (filter source actions by using
  keyboard state, pass that to GTK, get all actions supported by GTK in
  response, match them up with filtered source actions, return the
  result, falling back to COPY in case of multiple actions)
* Check drag_win32->protocol instead of the use_ole2_dnd variable where
  possible
* Remove protocol checks from functions that are only used by the local
  protocol
* Use event state to manufacture the keyboard state for WM_MOUSEMOVE
* Change function names printed by GDK_NOTE to name the actual
  functions, not their theoretical generic GDK stack ancestors
* Consistently use drag_win32 and drop_win32 variables instead of a mix
  of that and win32_drag/win32_drop
* Return FALSE from button handler to ensure that GTK gets the button
  event to break implicit grab
* Emit leave event on failed idroptarget_drop() calls

7 years agodnd: Add read_value() and read_text() functions to GdkDrop
Benjamin Otte [Sat, 2 Jun 2018 04:24:23 +0000 (06:24 +0200)]
dnd: Add read_value() and read_text() functions to GdkDrop

These just copy what GdkClipboard does.

7 years agodrop: Implement shortcut for local DND
Benjamin Otte [Thu, 31 May 2018 19:45:22 +0000 (21:45 +0200)]
drop: Implement shortcut for local DND

Now that we have the drop->drag, we can use the same shortcut we use in
the clipboard code to shortcut DND operations.

7 years agox11: Pass the drag source when creating a drop context
Benjamin Otte [Thu, 31 May 2018 19:24:08 +0000 (21:24 +0200)]
x11: Pass the drag source when creating a drop context

7 years agox11: Find dest drops differently
Benjamin Otte [Thu, 31 May 2018 19:18:04 +0000 (21:18 +0200)]
x11: Find dest drops differently

Instead of looking at the list of contexts, just look at the current
drop context. There is only one, after all.

Then remove the is_source argument from gdk_drag_context_find().

7 years agowayland: Store the current drag operation
Benjamin Otte [Thu, 31 May 2018 19:15:59 +0000 (21:15 +0200)]
wayland: Store the current drag operation

Use it to detect local drags when creating drop objects.

7 years agodnd: Move GdkDragAction to gdktypes.h
Benjamin Otte [Wed, 30 May 2018 19:12:43 +0000 (21:12 +0200)]
dnd: Move GdkDragAction to gdktypes.h

That way, both gdkdrag.h and gdkdrop.h can use it without one having to
include the other.

7 years agogdk: Remove leftover type from autocleanup
Benjamin Otte [Wed, 30 May 2018 19:04:05 +0000 (21:04 +0200)]
gdk: Remove leftover type from autocleanup

7 years agowayland: Get rid of GdkWaylandSelection
Benjamin Otte [Wed, 30 May 2018 02:37:47 +0000 (04:37 +0200)]
wayland: Get rid of GdkWaylandSelection

Move data source handling into the DND code instead.

7 years agowayland: Split drop context into GdkWaylandDrop
Benjamin Otte [Wed, 30 May 2018 02:04:51 +0000 (04:04 +0200)]
wayland: Split drop context into GdkWaylandDrop

GdkWaylandDrop no longer inherits from GdkDragContext now.

7 years agowayland: Remove a bunch of unused functions
Benjamin Otte [Wed, 30 May 2018 02:04:39 +0000 (04:04 +0200)]
wayland: Remove a bunch of unused functions

7 years agoevents: Make GdkEventDND have a GdkDrop member
Benjamin Otte [Tue, 29 May 2018 18:49:41 +0000 (20:49 +0200)]
events: Make GdkEventDND have a GdkDrop member

... instead of a GdkDragContext.

7 years agox11: Refactor DND filter
Benjamin Otte [Tue, 29 May 2018 18:44:32 +0000 (20:44 +0200)]
x11: Refactor DND filter

The filters now return TRUE/FALSE and no longer a GdkFilterReturn. They
also don't conform to the GdkFilterFunc typedef anymore but instead take
the arguments that they need.

7 years agox11: Use new DND event emitters
Benjamin Otte [Tue, 29 May 2018 17:13:24 +0000 (19:13 +0200)]
x11: Use new DND event emitters

7 years agowin32: Use new DND event emitters
Benjamin Otte [Tue, 29 May 2018 17:00:10 +0000 (19:00 +0200)]
win32: Use new DND event emitters

7 years agowayland: Use new DND event emitters
Benjamin Otte [Wed, 23 May 2018 18:11:28 +0000 (20:11 +0200)]
wayland: Use new DND event emitters

7 years agodrop: Add private API for event emission
Benjamin Otte [Wed, 23 May 2018 17:41:54 +0000 (19:41 +0200)]
drop: Add private API for event emission

7 years agodrop: Add GdkDrop:surface property
Benjamin Otte [Wed, 23 May 2018 16:30:14 +0000 (18:30 +0200)]
drop: Add GdkDrop:surface property

This replaces gdk_drag_context_get_dest_surface().

7 years agodisplay: Don't wake up the main loop anymore
Benjamin Otte [Tue, 22 May 2018 17:43:43 +0000 (19:43 +0200)]
display: Don't wake up the main loop anymore

This is not needed because GTK must be run in the main thread these days,
which is the same one that runs the main loop. So when this function is
called, the main loop is awake.

https://bugzilla.gnome.org/show_bug.cgi?id=550989

7 years agox11: Don't sneakily allocate memory in initializers
Benjamin Otte [Tue, 22 May 2018 13:48:50 +0000 (15:48 +0200)]
x11: Don't sneakily allocate memory in initializers

7 years agodnd: Add gdk_event_get_drop()
Benjamin Otte [Tue, 22 May 2018 13:32:27 +0000 (15:32 +0200)]
dnd: Add gdk_event_get_drop()

And remove gdk_event_get_drag_context().

All GTK code now only uses GdkDrop for dropping.

7 years agowayland: Fix drop operations for new semantics
Benjamin Otte [Sun, 20 May 2018 18:22:02 +0000 (20:22 +0200)]
wayland: Fix drop operations for new semantics

7 years agodnd: Remove GdkDragContext::commit_drag_status() vfunc
Benjamin Otte [Sun, 20 May 2018 18:15:39 +0000 (20:15 +0200)]
dnd: Remove GdkDragContext::commit_drag_status() vfunc

The idea behind the vfunc doesn't work as status updates can happen
asynchronously.

A better solution needs to be found.

7 years agodnd: Make drag-motion and drag-drop signals use GdkDrop
Benjamin Otte [Thu, 17 May 2018 02:51:18 +0000 (04:51 +0200)]
dnd: Make drag-motion and drag-drop signals use GdkDrop

7 years agodnd: Make drag-data-received use a GdkDrop
Benjamin Otte [Wed, 16 May 2018 02:50:24 +0000 (04:50 +0200)]
dnd: Make drag-data-received use a GdkDrop

7 years agodrop: Add gdk_drop_get_drag()
Benjamin Otte [Wed, 16 May 2018 02:49:58 +0000 (04:49 +0200)]
drop: Add gdk_drop_get_drag()

For now, it'll always return NULL. We'll fix that later.

7 years agowidget: Make GtkWidgetClass::drag_leave() take a GdkDrop
Benjamin Otte [Tue, 15 May 2018 22:59:01 +0000 (00:59 +0200)]
widget: Make GtkWidgetClass::drag_leave() take a GdkDrop

Drag Contexts are on their way out!

7 years agodnd: Add gdk_drop_finish()
Benjamin Otte [Tue, 15 May 2018 03:45:06 +0000 (05:45 +0200)]
dnd: Add gdk_drop_finish()

and move the vfunc into GdkDrop.

7 years agodnd: Get rid of gtk_drag_finish()
Benjamin Otte [Mon, 14 May 2018 14:44:43 +0000 (16:44 +0200)]
dnd: Get rid of gtk_drag_finish()

It's just a wrapper around gdk_drag_finish(), so use that one instead.

7 years agodnd: Rename gdk_drop_finish() => gdk_drag_finish()
Benjamin Otte [Mon, 14 May 2018 13:09:42 +0000 (15:09 +0200)]
dnd: Rename gdk_drop_finish() => gdk_drag_finish()

This is a simple rename, so that we can reintroduce gdk_drop_finish()
with the GdkDrop object.

7 years agodnd: Move the gdk_drag_status() function
Benjamin Otte [Mon, 14 May 2018 02:16:25 +0000 (04:16 +0200)]
dnd: Move the gdk_drag_status() function

It's now gdk_drop_status().

Also clarify the intended semantics.

7 years agodnd: Add gdk_drop_get_actions()
Benjamin Otte [Mon, 14 May 2018 00:49:33 +0000 (02:49 +0200)]
dnd: Add gdk_drop_get_actions()

This uses the new method without GDK_ACTION_ASK:

Either it is a single action (queryable via gdk_drag_action_is_unique())
or it is not and then the drop target has to make a decision
(potentially by asking someone).

7 years agodnd: Make actions a private member variable
Benjamin Otte [Sun, 13 May 2018 15:03:57 +0000 (17:03 +0200)]
dnd: Make actions a private member variable

Use a setter in the backends.

7 years agox11: Remove unused variables
Benjamin Otte [Sun, 13 May 2018 00:38:31 +0000 (02:38 +0200)]
x11: Remove unused variables

7 years agowayland: Set correct variable
Benjamin Otte [Sat, 12 May 2018 21:43:01 +0000 (23:43 +0200)]
wayland: Set correct variable

This got messed up in commit 7f8a8f221d60bc5da23602e5e024eb91f8b0f758.

7 years agodnd: Add gdk_drag_action_is_unique()
Benjamin Otte [Fri, 11 May 2018 22:13:11 +0000 (00:13 +0200)]
dnd: Add gdk_drag_action_is_unique()

This will be necessary once we remove the ASK action.

7 years agodnd: Remove GDK_ACTION_DEFAULT and GDK_ACTION_PRIVATE
Benjamin Otte [Tue, 8 May 2018 11:56:08 +0000 (13:56 +0200)]
dnd: Remove GDK_ACTION_DEFAULT and GDK_ACTION_PRIVATE

They're unused and nobody knows what they're supposed to men anyway.

7 years agodrop: Move gdk_drop_read_async() to GdkDrop class
Benjamin Otte [Mon, 7 May 2018 22:47:26 +0000 (00:47 +0200)]
drop: Move gdk_drop_read_async() to GdkDrop class

7 years agodnd: Add GdkDrop base class for GdkDragContext
Benjamin Otte [Mon, 30 Apr 2018 12:10:44 +0000 (14:10 +0200)]
dnd: Add GdkDrop base class for GdkDragContext

The ultimate goal of this patch series is to split GdkDragContext into
GdkDrop + GdkDrag classes for the destination and source side of a dnd
operation.

The refactoring is meant to work something like this:
1. Introduce GdkDrop as a base class
2. Make all drop related code (like GdkEvent) use GdkDrop instead of
   GdkDragContext. Move/duplicate APIs to allow that.
3. Port all drop contexts in the backends from GdkDragContext to GdkDrop
4. Delete all APIs in GdkDragContext that aren't needed anymore.
5. Make GdkDragContext no longer a GdkDrop subclass
6. Rename GdkDragContext to GdkDrag

7 years agoMerge branch 'lrn/misc-gtk4-fixes' into 'master'
Matthias Clasen [Mon, 18 Jun 2018 21:37:42 +0000 (21:37 +0000)]
Merge branch 'lrn/misc-gtk4-fixes' into 'master'

Misc GTK4 fixes

See merge request GNOME/gtk!195

7 years agoMerge branch 'win32-filechooser-fix-file-list-order' into 'master'
Matthias Clasen [Mon, 18 Jun 2018 20:09:47 +0000 (20:09 +0000)]
Merge branch 'win32-filechooser-fix-file-list-order' into 'master'

win32 file chooser: add missing g_slist_reverse

See merge request GNOME/gtk!199

7 years agothemes: Don't handle box.linked special
Timm Bäder [Mon, 18 Jun 2018 17:39:32 +0000 (19:39 +0200)]
themes: Don't handle box.linked special

We don't reverse the css nodes anymore in RTL layouts.

7 years agofilechooserbutton: Remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 15:24:57 +0000 (17:24 +0200)]
filechooserbutton: Remove priv pointer

7 years agoGtkStyleContext: Remove the frame clock
Timm Bäder [Mon, 18 Jun 2018 13:25:25 +0000 (15:25 +0200)]
GtkStyleContext: Remove the frame clock

It's unused within GtkStyleContext.

7 years agodnd: Fix up a comment
Timm Bäder [Mon, 18 Jun 2018 13:04:00 +0000 (15:04 +0200)]
dnd: Fix up a comment

The below function does not take a GtkIconHelper anymore.

7 years agocolorscale: Remove priv pointer
Timm Bäder [Mon, 18 Jun 2018 12:28:19 +0000 (14:28 +0200)]
colorscale: Remove priv pointer