Nextcloud bot [Wed, 6 Mar 2024 06:54:44 +0000 (06:54 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Matthieu Gallien [Tue, 5 Mar 2024 16:19:50 +0000 (17:19 +0100)]
Merge pull request #6463 from nextcloud/bugfix/multipleMovesOfASingleFileid
when moving a file, checks that it exists at origin or destination
Matthieu Gallien [Tue, 5 Mar 2024 11:09:45 +0000 (12:09 +0100)]
fix missing tracking for some item rename operations
will fix mishandling of rename of a single file to multiple places
during discovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Mar 2024 07:55:13 +0000 (08:55 +0100)]
add new test to simulate the data loss scenario
this new test trigger the assert that a file is either in the old place
or the new place when we execute a MOVE instruction for a local file
in the test one file is discovered as in need of a local MOVE but will
be missing from the old and new places when running the propagation due
to a bug
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Mon, 19 Feb 2024 13:46:52 +0000 (14:46 +0100)]
when moving a file, checks that it exists at origin or destination
current automated tests are never breaking the rule that a file that
should be moved on client side (after a move was done server side)
exists either at teh original path or the destination path.
in practice it may happen (and I manually tested it) thet the sync
engine decides to move a single file in two distinct places
that decision will violate this rule and a debug build would then run
into the assert
Close #6462
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Matthieu Gallien [Tue, 5 Mar 2024 13:43:17 +0000 (14:43 +0100)]
Merge pull request #6491 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.9.1
Bump cpp-linter/cpp-linter-action from 2.8.0 to 2.9.1
dependabot[bot] [Mon, 26 Feb 2024 23:40:25 +0000 (23:40 +0000)]
Bump cpp-linter/cpp-linter-action from 2.8.0 to 2.9.1
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.8.0 to 2.9.1.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.8.0...v2.9.1)
---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Matthieu Gallien [Tue, 5 Mar 2024 11:17:12 +0000 (12:17 +0100)]
Merge pull request #6503 from nextcloud/bugfix/ignorelist-exclude-status-stuck
Bugfix. Exclude list. Fix stuck 'excluded' status in Windows Explorer after removing the exclude pattern.
alex-z [Mon, 4 Mar 2024 15:50:10 +0000 (16:50 +0100)]
Unit tests for ignorelist exclude status stuck.
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Sat, 2 Mar 2024 18:16:07 +0000 (19:16 +0100)]
Bugfix. Exclude list. Fix stuck 'excluded' status in Windows Explorer after removing the exclude pattern.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Matthieu Gallien [Tue, 5 Mar 2024 09:29:25 +0000 (10:29 +0100)]
Merge pull request #6502 from nextcloud/bugfix/federated-share-activity-actions
Bugfix. Federated share activity show 'Decline' action button.
alex-z [Mon, 4 Mar 2024 13:00:20 +0000 (14:00 +0100)]
Unit tests for federated share activity actions
Signed-off-by: alex-z <blackslayer4@gmail.com>
alex-z [Sat, 2 Mar 2024 14:11:38 +0000 (15:11 +0100)]
Bugfix. Federated share activity show 'Decline' action button.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Claudio Cambra [Tue, 5 Mar 2024 03:50:17 +0000 (11:50 +0800)]
Merge pull request #6490 from nextcloud/bugfix/expandable-folder-status-model
Bugfix/expandable folder status model
Claudio Cambra [Sun, 3 Mar 2024 18:19:05 +0000 (02:19 +0800)]
Ensure there is a return in case FolderPathRole of FolderStatusModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 3 Mar 2024 10:04:47 +0000 (18:04 +0800)]
Check parent variable nullness in folderstatusmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 3 Mar 2024 10:03:55 +0000 (18:03 +0800)]
Remove unneeded error variable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 3 Mar 2024 09:42:10 +0000 (17:42 +0800)]
Clean up and add braces for if statements in folderstatusmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 12:20:39 +0000 (20:20 +0800)]
Clarify role of idx in slotUpdateDirectories
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 09:45:53 +0000 (17:45 +0800)]
Automatically fetch first level of subfolders for root nodes in folder status model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 09:42:06 +0000 (17:42 +0800)]
Use braced initialiser where possible for folderstatusmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 09:41:46 +0000 (17:41 +0800)]
Const autofy where possible in folderstatusmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 09:38:53 +0000 (17:38 +0800)]
Avoid excessive single letter variables in FolderStatusModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 09:09:38 +0000 (17:09 +0800)]
Fix undecided lists in fodlerstatusmodel comment
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 26 Feb 2024 09:09:14 +0000 (17:09 +0800)]
Modernise and replace foreach loops with for in loops in folderstatusmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Nextcloud bot [Tue, 5 Mar 2024 02:39:45 +0000 (02:39 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 4 Mar 2024 02:39:35 +0000 (02:39 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 3 Mar 2024 02:37:18 +0000 (02:37 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sat, 2 Mar 2024 02:42:21 +0000 (02:42 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Fri, 1 Mar 2024 11:05:47 +0000 (11:05 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Thu, 29 Feb 2024 11:39:44 +0000 (12:39 +0100)]
Merge pull request #6484 from nextcloud/bugfix/fix-misleading-log
Bugfix. E2ee misleading log fix.
Nextcloud bot [Thu, 29 Feb 2024 02:38:45 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Wed, 28 Feb 2024 20:52:23 +0000 (21:52 +0100)]
Merge pull request #6486 from nextcloud/bugfix/e2ee-v2-nonroot-sync
Bugfix/e2ee v2 non-root sync
alex-z [Sat, 24 Feb 2024 16:47:03 +0000 (17:47 +0100)]
Bugfix. E2EE V2. Fix incorrect root e2ee folder path search in local db.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Wed, 28 Feb 2024 13:56:29 +0000 (14:56 +0100)]
Merge pull request #6479 from nextcloud/bugfix/client-status-reporting-remove-desktop-specific-entries
Client Status Reporting. Only report statuses listed on the server.
alex-z [Mon, 19 Feb 2024 19:37:34 +0000 (20:37 +0100)]
Client Status Reporting. Only report statuses listed on the server.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Wed, 28 Feb 2024 02:48:32 +0000 (02:48 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 27 Feb 2024 02:38:50 +0000 (02:38 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Mon, 26 Feb 2024 02:35:29 +0000 (02:35 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Sun, 25 Feb 2024 02:40:03 +0000 (02:40 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
alex-z [Sat, 24 Feb 2024 13:36:45 +0000 (14:36 +0100)]
Bugfix. E2ee misleading log fix.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Sat, 24 Feb 2024 02:59:39 +0000 (02:59 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Fri, 23 Feb 2024 12:00:17 +0000 (13:00 +0100)]
Merge pull request #6454 from nextcloud/bugfix/fix-crash-syncfolder-remove
Fix crash when deleting a local sync folder during sync.
alex-z [Sat, 17 Feb 2024 13:55:38 +0000 (14:55 +0100)]
Fix crash when deleting a local sync folder during sync.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Fri, 23 Feb 2024 02:36:37 +0000 (02:36 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
allexzander [Thu, 22 Feb 2024 19:08:24 +0000 (20:08 +0100)]
Merge pull request #6471 from nextcloud/bugfix/e2ee-v1-deryption
E2EE. Allow decryption v1.0 and v1.1 folders.
alex-z [Tue, 20 Feb 2024 15:37:09 +0000 (16:37 +0100)]
E2EE. Allow decryption v1.0 and v1.1 folders.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Thu, 22 Feb 2024 17:37:19 +0000 (18:37 +0100)]
Merge pull request #6456 from nextcloud/feature/vfs-cfapi-detailed-error-message-for-leading-hash
VFS. CfAPI. Provide detailed error message for leading '#' placeholder update failure.
alex-z [Fri, 16 Feb 2024 15:25:06 +0000 (16:25 +0100)]
VFS. CfAPI. Provide detailed error message for leading '#' placeholder update failure.
Signed-off-by: alex-z <blackslayer4@gmail.com>
allexzander [Thu, 22 Feb 2024 11:37:05 +0000 (12:37 +0100)]
Merge pull request #6458 from nextcloud/bugfix/caseclashconflict-dialog-vfsmode-freeze
Use 'FindMimeFromData' from Win API instead of QMimeDatabase() functions to get the mimetype. Prevents freeze from VFS placeholders.
alex-z [Sat, 17 Feb 2024 20:04:27 +0000 (21:04 +0100)]
Only match file extension not its content for mimetype. Prevents freeze from VFS placeholders.
Signed-off-by: alex-z <blackslayer4@gmail.com>
Nextcloud bot [Thu, 22 Feb 2024 02:40:30 +0000 (02:40 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Wed, 21 Feb 2024 02:36:42 +0000 (02:36 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Nextcloud bot [Tue, 20 Feb 2024 02:35:56 +0000 (02:35 +0000)]
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
Claudio Cambra [Mon, 19 Feb 2024 14:46:45 +0000 (22:46 +0800)]
Merge pull request #6351 from nextcloud/feature/file-provider-config-ui
Add a configuration interface for macOS File Provider virtual files
Claudio Cambra [Mon, 19 Feb 2024 06:12:34 +0000 (14:12 +0800)]
Temporarily remove eviction dialog button until eviction works on extension side
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Jan 2024 09:17:26 +0000 (17:17 +0800)]
Mark MacImplementation for FileProviderSettings destructor as override
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 16 Jan 2024 08:57:43 +0000 (16:57 +0800)]
Ensure [[nodiscard]] in new file provider classes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Jan 2024 09:27:19 +0000 (17:27 +0800)]
Limit gigabyte sizing string to two decimal figures in file provider storage info
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Jan 2024 09:18:55 +0000 (17:18 +0800)]
Use NCProgressBar for file provider sync status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Jan 2024 09:15:11 +0000 (17:15 +0800)]
Adjust alignment and sizing of file provider sync status icon
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Jan 2024 09:14:52 +0000 (17:14 +0800)]
Use font sizes in Style.qml in FileProviderSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Jan 2024 09:08:11 +0000 (17:08 +0800)]
Add useful font sizes to Style.qml
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Mon, 15 Jan 2024 08:35:49 +0000 (16:35 +0800)]
Provide correct sync state icon in file provider domain sync status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 18:45:41 +0000 (02:45 +0800)]
Bolden sync state text for fp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 18:45:27 +0000 (02:45 +0800)]
Add separator to dynamically loaded fp settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 18:28:09 +0000 (02:28 +0800)]
Fix grid layout for sync status of file provider
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 18:20:22 +0000 (02:20 +0800)]
Extract File Provider storage settings to separate file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 18:06:21 +0000 (02:06 +0800)]
Extract sync status layout to separate file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 17:51:28 +0000 (01:51 +0800)]
Only load file provider settings items if domain is enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 17:38:31 +0000 (01:38 +0800)]
Add current sync status UI to file provider settings view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Sun, 14 Jan 2024 17:28:11 +0000 (01:28 +0800)]
Enable use of domain sync status class in QML
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 10 Jan 2024 07:42:33 +0000 (15:42 +0800)]
Fix crash on state change in file provider domain sync status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 18:19:02 +0000 (02:19 +0800)]
Add method to acquire domain sync status in settings controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 18:18:32 +0000 (02:18 +0800)]
Setup domain sync statuses in settings controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 18:16:28 +0000 (02:16 +0800)]
Make mac implementation of file provider settings controller a QObject
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 18:15:32 +0000 (02:15 +0800)]
Fix unique ptr compile issue in domain sync status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 18:15:17 +0000 (02:15 +0800)]
Fix parameter name shadowing in fraction completed methods of domain sync status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 17:07:49 +0000 (01:07 +0800)]
Update properties via ProgressObserver on FileProviderDomainSyncStatus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 17:04:52 +0000 (01:04 +0800)]
Add main properties to FileProviderDomainSyncStatus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 16:25:55 +0000 (00:25 +0800)]
Add observing for important properties of nsprogress in progresshandler
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 16:18:20 +0000 (00:18 +0800)]
Add ProgressKVOChangeHandler property to ProgressObserver
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 16:16:15 +0000 (00:16 +0800)]
Acquire upload/download progress in domain sync status
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 16:15:37 +0000 (00:15 +0800)]
Add a starter ProgressObserver Objective-C class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 15:32:53 +0000 (23:32 +0800)]
Add q pointer to MacImplementation for FileProviderDomainSyncStatus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 15:30:27 +0000 (23:30 +0800)]
Define basic FileProviderDomainSyncStatus private implementation
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 15:02:41 +0000 (23:02 +0800)]
Add starter FileProviderDomainSyncStatus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 14:49:22 +0000 (22:49 +0800)]
Add UI button to signal file provider domain
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 9 Jan 2024 14:48:59 +0000 (22:48 +0800)]
Add method to signal file provider domain via file provider settings controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Jan 2024 13:21:10 +0000 (21:21 +0800)]
Always perform fallback document size discovery in fileprovideritemmetadata
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Jan 2024 13:11:33 +0000 (21:11 +0800)]
Remove unused usage property from enumeration observer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Jan 2024 13:11:18 +0000 (21:11 +0800)]
Directly generate file provider item metadatas and cache
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Jan 2024 13:07:46 +0000 (21:07 +0800)]
Mark MacImplementation constructor for FileProviderSettingsController as explicit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Jan 2024 09:16:10 +0000 (17:16 +0800)]
Create debug archive on client side
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Wed, 3 Jan 2024 09:16:00 +0000 (17:16 +0800)]
Replace handling of debug archive creation in clientcommunicationservice with simple retrieval of debug string
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Jan 2024 12:45:29 +0000 (20:45 +0800)]
Directly provide text file path to logger for debug archive creation
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Jan 2024 12:11:33 +0000 (20:11 +0800)]
Replace old and now broken socket based debug archive command with command over XPC
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 2 Jan 2024 12:11:05 +0000 (20:11 +0800)]
Implement creating debug archive in client communication service
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 14 Nov 2023 10:10:14 +0000 (18:10 +0800)]
Add button to create debug archive
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Claudio Cambra [Tue, 14 Nov 2023 09:12:30 +0000 (17:12 +0800)]
Add createFileProvider slot to FileProviderSettingsController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>