Stas Solovey [Tue, 12 Sep 2017 19:30:36 +0000 (19:30 +0000)]
Update Russian translation
Stas Solovey [Tue, 12 Sep 2017 19:15:22 +0000 (19:15 +0000)]
Update Russian translation
Cheng-Chia Tseng [Tue, 12 Sep 2017 17:24:00 +0000 (17:24 +0000)]
Update Chinese (Taiwan) translation
Cheng-Chia Tseng [Tue, 12 Sep 2017 17:07:41 +0000 (17:07 +0000)]
Update Chinese (Taiwan) translation
hanniedu [Tue, 12 Sep 2017 10:38:19 +0000 (12:38 +0200)]
Updated Dutch translation 3.22
Matthias Clasen [Mon, 11 Sep 2017 14:49:52 +0000 (10:49 -0400)]
3.22.21
Matthias Clasen [Mon, 11 Sep 2017 15:17:41 +0000 (11:17 -0400)]
Fix a corner-case for emoji input
As reported in https://github.com/ibus/ibus/issues/1944,
typing u201e while holding Ctrl+Shift used to give a „
when letting go of Ctrl+Shift. This broke when we introduced
Ctrl+Shift+e to start Emoji sequences. Fix this by only
looking for Ctrl+Shift+e if we are not already in a hex
sequence.
Daniel Mustieles [Mon, 11 Sep 2017 13:57:21 +0000 (13:57 +0000)]
Update Spanish translation
Ask Hjorth Larsen [Sun, 10 Sep 2017 16:16:33 +0000 (18:16 +0200)]
Updated Danish translation
Ask Hjorth Larsen [Sun, 10 Sep 2017 16:15:01 +0000 (18:15 +0200)]
Updated Danish translation
Muhammet Kara [Sun, 10 Sep 2017 15:09:31 +0000 (15:09 +0000)]
Update Turkish translation
Jordi Mas [Sun, 10 Sep 2017 06:22:12 +0000 (08:22 +0200)]
Fixes to Catalan translation
Inaki Larranaga Murgoitio [Sat, 9 Sep 2017 15:54:59 +0000 (17:54 +0200)]
Update Basque language
Inaki Larranaga Murgoitio [Sat, 9 Sep 2017 15:54:30 +0000 (17:54 +0200)]
Update Basque language
Matej Urbančič [Fri, 8 Sep 2017 09:02:10 +0000 (11:02 +0200)]
Updated Slovenian translation
gogo [Thu, 7 Sep 2017 18:35:09 +0000 (18:35 +0000)]
Update Croatian translation
Daniel Boles [Thu, 7 Sep 2017 13:53:59 +0000 (14:53 +0100)]
Entry: Fix leak of text in ensure_has_tooltip()
Thanks to Mohammed Sadiq for noticing this. I guess I got
Widget.get_tooltip_text() confused with Label.get_label().
https://bugzilla.gnome.org/show_bug.cgi?id=787410
Jiri Grönroos [Thu, 7 Sep 2017 08:41:41 +0000 (08:41 +0000)]
Update Finnish translation
Piotr Drąg [Wed, 6 Sep 2017 18:14:41 +0000 (20:14 +0200)]
Update Polish translation
Çağatay Yiğit Şahin [Wed, 6 Sep 2017 06:48:16 +0000 (06:48 +0000)]
Update Turkish translation
Mario Blättermann [Tue, 5 Sep 2017 17:48:13 +0000 (17:48 +0000)]
Update German translation
Marek Cernocky [Tue, 5 Sep 2017 14:37:09 +0000 (16:37 +0200)]
Updated Czech translation
Jakub Steiner [Wed, 23 Aug 2017 20:26:06 +0000 (22:26 +0200)]
adwaita: use generic sidebar icon style
https://bugzilla.gnome.org/show_bug.cgi?id=786613
Daniel Mustieles [Tue, 5 Sep 2017 10:36:15 +0000 (10:36 +0000)]
Update Spanish translation
Daniel Boles [Tue, 5 Sep 2017 00:38:35 +0000 (01:38 +0100)]
Adwaita: Leave fg color of hovered emoji alone
Only HighContrast has a clear problem, and this avoids some probably
unwanted changes of certain colours in the weird greyscale emoji I have
available to test here.
Daniel Boles [Mon, 4 Sep 2017 23:48:06 +0000 (00:48 +0100)]
themes: Use $selected_fg_color for :hovered emoji
This is much needed for HighContrast as otherwise emoji are invisible
(or nearly in Inverse). It also syncs up with hovered menu items, etc.
https://bugzilla.gnome.org/show_bug.cgi?id=787279
Daniel Boles [Mon, 4 Sep 2017 23:58:00 +0000 (00:58 +0100)]
HighContrast: Kill abominable headerbar vseparator
Commit
70b61973fc0214dab7771fd2b339103592e7358f fixed a syntax error and
unwittingly released this bizarre mutant.
https://bugzilla.gnome.org/show_bug.cgi?id=787280
Daniel Boles [Mon, 4 Sep 2017 22:41:53 +0000 (23:41 +0100)]
ComboBox: Don’t popdown if releasing on scrollbar
On button release, we were popping down if the event widget was anything
but priv->button. This broke scrolling by clicking a mouse button, i.e.
when releasing a click in the trough or finishing a drag of either bar.
That’s unexpected, inconvenient, and pointless. So, let’s stop doing it.
https://bugzilla.gnome.org/show_bug.cgi?id=738893
Anders Jonsson [Mon, 4 Sep 2017 22:16:39 +0000 (22:16 +0000)]
Update Swedish translation
Daniel Boles [Mon, 4 Sep 2017 18:56:47 +0000 (19:56 +0100)]
EmojiChooser: Ensure always have a selected button
We were only selecting a section’s button if the adjustment y coord was
within its heading, so scrolling slightly into it unchecked all buttons.
This also fixes how we could end up with the first 2 selected, somehow.
https://bugzilla.gnome.org/show_bug.cgi?id=787172
Daniel Boles [Sat, 2 Sep 2017 17:47:47 +0000 (18:47 +0100)]
EmojiChooser: Check the 1st button before 1st show
We scroll to the top in show() but only ever selected a button when the
adjustment changed, which doesn’t happen in init(). Check it manually.
https://bugzilla.gnome.org/show_bug.cgi?id=787172
Timm Bäder [Wed, 26 Apr 2017 09:37:58 +0000 (11:37 +0200)]
sidebarrow: Remove useless size group
Nice try, but size groups don't work with invisible widgets anyway.
Invisible widgets request 0×0.
[reapplying after accidental reintroduction in the cloudproviders patch;
see https://bugzilla.gnome.org/show_bug.cgi?id=786123#c39]
Matthias Clasen [Mon, 4 Sep 2017 17:02:58 +0000 (13:02 -0400)]
3.22.20
Baurzhan Muftakhidinov [Mon, 4 Sep 2017 15:48:15 +0000 (15:48 +0000)]
Update Kazakh translation
Matthias Clasen [Mon, 4 Sep 2017 15:29:19 +0000 (11:29 -0400)]
3.22.20
Julius Härtl [Fri, 1 Sep 2017 19:43:39 +0000 (21:43 +0200)]
gtkplacessidebar: adapt libcloudproviders api rename
https://bugzilla.gnome.org/show_bug.cgi?id=786123
Daniel Boles [Sat, 2 Sep 2017 16:41:59 +0000 (17:41 +0100)]
HighContrast: basic port of emoji CSS from Adwaita
This is better than nothing: without specific CSS, the Chooser was too
large, the emoji were too small, and the buttons were generally ugly.
https://bugzilla.gnome.org/show_bug.cgi?id=786956
Daniel Boles [Sat, 2 Sep 2017 15:54:47 +0000 (16:54 +0100)]
Adwaita: proper colours for inactive emoji buttons
Use opacity to differentiate unselected/hovered/selected buttons. It had
assumed bg < border < fg colours, which may be false, as in Adwaita:dark
This also means we do not need to special-case for the backdrop state.
https://bugzilla.gnome.org/show_bug.cgi?id=786956
Daniel Boles [Sat, 2 Sep 2017 15:56:14 +0000 (16:56 +0100)]
Adwaita: Make use of SASS syntax for emoji stuff
This makes the theme easier to maintain.
https://bugzilla.gnome.org/show_bug.cgi?id=786956
Matthias Clasen [Mon, 4 Sep 2017 13:56:24 +0000 (09:56 -0400)]
Updates
Milo Casagrande [Mon, 4 Sep 2017 11:43:05 +0000 (11:43 +0000)]
Update Italian translation
Aurimas Černius [Sun, 3 Sep 2017 20:37:27 +0000 (23:37 +0300)]
Updated Lithuanian translation
Balázs Úr [Sun, 3 Sep 2017 16:51:46 +0000 (16:51 +0000)]
Update Hungarian translation
Rūdolfs Mazurs [Sun, 3 Sep 2017 16:27:50 +0000 (19:27 +0300)]
Update Latvian translation
Daniel Boles [Sun, 3 Sep 2017 12:53:48 +0000 (13:53 +0100)]
Adwaita: Fix ineffective theming of switch slider
in a specific case, which was applying .slider as a class on the parent
switch, instead of correctly selecting on its child node named slider.
This makes the border on the outside of a switch in a selected listbox
row look better in the light variant. Since the code was never removed,
it was clearly meant to work, and making it work is a clear improvement.
Daniel Boles [Sun, 3 Sep 2017 12:32:14 +0000 (13:32 +0100)]
HighContrast: Fix outdated name for headerbar box
Daniel Boles [Sun, 3 Sep 2017 12:10:50 +0000 (13:10 +0100)]
Adwaita: Fix outdated name of selection-menu arrow
Daniel Boles [Sun, 3 Sep 2017 11:07:35 +0000 (12:07 +0100)]
docs: css-overview: Don’t recommend broken syntax
Using this produced warnings about the Pango syntax of <Family> <size>
being deprecated, and the size being invalid due to no unit specified.
Also, that multi-word font family presumably wouldn’t work as expected.
Timm Bäder [Mon, 3 Oct 2016 07:31:44 +0000 (09:31 +0200)]
testgtk: fix css
Daniel Boles [Sun, 3 Sep 2017 10:04:48 +0000 (11:04 +0100)]
Toolbar: Clarify set_show_arrow() a bit more
Daniel Boles [Sun, 3 Sep 2017 09:41:56 +0000 (10:41 +0100)]
Toolbar: Clarify how the arrow overflow menu works
The fact it affects the preferred size, and only works with ToolItems
that return a menu proxy item, was unclear unless deduced from other
sources, and this led to users thinking it was broken, for example:
https://stackoverflow.com/q/
44644642/
2757035
https://bugzilla.gnome.org/show_bug.cgi?id=787158
https://bugzilla.gnome.org/show_bug.cgi?id=787195
Daniel Boles [Sun, 3 Sep 2017 09:41:24 +0000 (10:41 +0100)]
ToolItem: Add see-also from proxy setter to signal
Daniel Boles [Sun, 3 Sep 2017 09:39:58 +0000 (10:39 +0100)]
ToolItem: Annotate menu proxy item as nullable
It can be NULL. ::create-menu-proxy gave an example of when a NULL proxy
menu item could be useful, but the accessors did not annotate it as such.
Rafael Fontenelle [Sat, 2 Sep 2017 20:51:14 +0000 (20:51 +0000)]
Update Brazilian Portuguese translation
Daniel Boles [Sat, 2 Sep 2017 15:11:06 +0000 (16:11 +0100)]
Revert "sk.po: Consistently translate “Insert”"
This reverts commit
d09bc2b108be1643f29bb5a917da06e2a22f975c.
As an English-speaker, I know nothing about complex grammar, and it’s
been brought to my attention that some languages might differ in the
translation of the same command depending on where it appears.
So, I’d better assume everyone else knows better than me. Apologies!
Daniel Boles [Sat, 2 Sep 2017 15:00:08 +0000 (16:00 +0100)]
Adwaita: Fix colour mixing of emoji section button
when hovered, by using %, since SASS does not handle decimal mixes.
Daniel Boles [Sat, 2 Sep 2017 10:56:44 +0000 (11:56 +0100)]
sk.po: Consistently translate “Insert”
The two occurrences disagreed on the translation, and my amateur
investigation indicates this one is correct.
Daniel Boles [Sat, 2 Sep 2017 10:52:45 +0000 (11:52 +0100)]
gl.po: Consistently translate/capitalise “Emoji”
GTK+ 3 and 4 disagreed on capitalisation and the translation of “Emoji”.
Use sentence case as elsewhere & the most common translation: emoticono.
Jordi Mas [Sat, 2 Sep 2017 14:21:10 +0000 (16:21 +0200)]
Update Catalan translation
Jordi Mas [Sat, 2 Sep 2017 14:20:07 +0000 (16:20 +0200)]
Update Catalan translation
Jordi Mas [Sat, 2 Sep 2017 14:16:12 +0000 (16:16 +0200)]
Update Catalan translation
Matthias Clasen [Sat, 2 Sep 2017 12:45:51 +0000 (08:45 -0400)]
emoji chooser: No emoji in the search entry
Recursion is fun, but better avoided in the ui.
https://bugzilla.gnome.org/show_bug.cgi?id=786960
Matthias Clasen [Sat, 2 Sep 2017 12:42:52 +0000 (08:42 -0400)]
entry: Consider input hints for Emoji support
Don't show "insert emoji" in the context menu if input
hints indicate that Emoji input is not useful.
Matthias Clasen [Sat, 2 Sep 2017 12:42:18 +0000 (08:42 -0400)]
Add input hints for Emoji input
Allow hinting input methods about whether Emoji support is
useful or not.
Fran Dieguez [Sat, 2 Sep 2017 10:07:51 +0000 (10:07 +0000)]
Update Galician translation
Dušan Kazik [Sat, 2 Sep 2017 08:06:18 +0000 (08:06 +0000)]
Update Slovak translation
Dušan Kazik [Sat, 2 Sep 2017 08:02:39 +0000 (08:02 +0000)]
Update Slovak translation
Andika Triwidada [Sat, 2 Sep 2017 00:58:14 +0000 (00:58 +0000)]
Update Indonesian translation
Matthias Clasen [Fri, 1 Sep 2017 23:51:17 +0000 (19:51 -0400)]
emoji chooser: Avoid a crash
The emoji chooser gets disposed already, because it is attached
to the toplevel as a popover. Doing it again when the object data
is cleared is leading to a crash.
https://bugzilla.gnome.org/show_bug.cgi?id=787103
Piotr Drąg [Fri, 1 Sep 2017 23:50:34 +0000 (01:50 +0200)]
Update Polish translation
Mohammed Sadiq [Wed, 30 Aug 2017 17:55:59 +0000 (23:25 +0530)]
emoji-chooser: fix subsequent scroll
Event handlers on scroll window should only be run once the widget
is shown.
https://bugzilla.gnome.org/show_bug.cgi?id=786964
Daniel Boles [Wed, 30 Aug 2017 11:48:23 +0000 (12:48 +0100)]
Entry: Set tooltip text on icon for emoji chooser
https://bugzilla.gnome.org/show_bug.cgi?id=786885
gogo [Fri, 1 Sep 2017 21:55:48 +0000 (21:55 +0000)]
Update Croatian translation
Daniel Boles [Fri, 1 Sep 2017 19:17:11 +0000 (20:17 +0100)]
ComboBox: Dodge possible surplus disconnects
in case anyone connected any other signal on the model to this ComboBox.
Daniel Boles [Fri, 1 Sep 2017 15:03:36 +0000 (16:03 +0100)]
ScrolledWindow: Dodge possible surplus disconnects
In case the outgoing Adjustment for whatever reason has other handlers
referring to this SW, be sure to avoid disconnecting any but our own.
Daniel Boles [Fri, 1 Sep 2017 10:44:15 +0000 (11:44 +0100)]
ComboBox: Remove pointless signal ID member fields
We don’t need to store these for disconnection, as we can just use
g_signal_handlers_disconnect_by_data(). Also, merge redundant ifs.
Daniel Boles [Fri, 1 Sep 2017 10:43:44 +0000 (11:43 +0100)]
ComboBox: Clean up handler disconnection some more
Dušan Kazik [Fri, 1 Sep 2017 14:19:10 +0000 (14:19 +0000)]
Update Slovak translation
Daniel Boles [Thu, 31 Aug 2017 22:17:03 +0000 (23:17 +0100)]
ScrolledWindow: Fix non-disconnection of handlers
• Use disconnect_by_data() to catch both _adjustment_changed() and now
_adjustment_value_changed(), as the latter had been missed until now.
• Also disconnect from indicator_value_changed(), which was not done in
destroy() due to indicator_reset() and remove_indicator() disagreeing.
https://bugzilla.gnome.org/show_bug.cgi?id=775074
Timm Bäder [Sat, 27 May 2017 07:47:56 +0000 (09:47 +0200)]
scrolledwindow: Properly remove scrollbars
Instead of keeping an extra ref, then unparent+destroy+unref, don't keep
an extra ref and just unparent the scrollbar when appropriate.
Daniel Boles [Thu, 31 Aug 2017 19:19:58 +0000 (20:19 +0100)]
Window: Connect screen signals properly in init()
Do not connect to get_settings_for_screen() if we have no screen…
Use g_signal_connect(), not connect_object(), to match how set_screen()
makes these same connections, and how finalize() already disconnects.
https://bugzilla.gnome.org/show_bug.cgi?id=705640
Daniel Boles [Thu, 31 Aug 2017 18:58:15 +0000 (19:58 +0100)]
FileChooserWidget: Remove an unused #include
Daniel Boles [Wed, 30 Aug 2017 20:12:56 +0000 (21:12 +0100)]
Entry: Rename int helper to gtk_entry_clear_icon()
It was called gtk_entry_clear(), which was unnecessarily vague.
Daniel Boles [Sat, 5 Aug 2017 22:48:29 +0000 (23:48 +0100)]
Entry: Fix Shift-click → extend/truncate selection
Since the move from button-press to gesture events, Shift-clicking did
not work to start a selection (from none) or truncate an existing one.
This was due to the code being copy-pasted around and some logic being
broken in the process. This makes both of those work as they should, by
shuffling it again so the end result is the same as before. Highlights:
(1) ::button-press if extending due to a single press would call
set_positions(tmp_pos, tmp_pos), which is what made the Shift+click to
create a selection work. That was lost. Add it back to make that work.
(2) ::button-press in the “Truncate current selection” branch would not
execute all the stuff around “extend_to_left”, as that was the else
case. So, set extend_selection = FALSE so we skip over that later on.
(3) BUT! This Truncate case never fired because it was in the else
branch of if (in_selection())! Of course, it must be in the true branch.
(4) The IM context was not reset if the Shift-click occurred within an
existing selection, only if it did not. In ::button-press this was the
first thing done if extending a selection, regardless. Make it so again.
https://bugzilla.gnome.org/show_bug.cgi?id=780750
Daniel Boles [Wed, 30 Aug 2017 13:22:54 +0000 (14:22 +0100)]
gl.po: Remove mnemonic underlines from tooltips
It looks like these were copy-paste errors from the corresponding labels
for buttons, which should have mnemonics. Of course, tooltips cannot.
Matthias Clasen [Wed, 30 Aug 2017 12:36:56 +0000 (08:36 -0400)]
Avoid empty space in the emoji chooser
We need to hide the empty flow boxes as well, to avoid
spacing between them.
https://bugzilla.gnome.org/show_bug.cgi?id=786966
Fran Dieguez [Wed, 30 Aug 2017 13:10:56 +0000 (13:10 +0000)]
Update Galician translation
Fabio Tomat [Wed, 30 Aug 2017 09:22:45 +0000 (09:22 +0000)]
Update Friulian translation
Daniel Boles [Tue, 29 Aug 2017 19:04:45 +0000 (20:04 +0100)]
PlacesSidebar: Reuse strings, mark for translation
The new menu items were not marked for translation, had no mnemonics,
and were not title-cased. Reuse the strings that we already had for the
buttons shortly down the file, and mark these for translation.
https://bugzilla.gnome.org/show_bug.cgi?id=786123
Nelson Benítez León [Wed, 2 Aug 2017 14:03:28 +0000 (19:03 +0500)]
textview: fix bug on DnD displaced limits of selection
The fix of commit
f2fd655754407103f8fb9b2c3e7586fb595ab917
should be confined to DnD coords only, because otherwise
it causes the start and end of the selection to be displaced.
https://bugzilla.gnome.org/show_bug.cgi?id=785736
Daniel Boles [Tue, 29 Aug 2017 18:00:03 +0000 (19:00 +0100)]
TextView: :border-width broke window→widget coords
Do the converse of commit
bd7c87c762c75bbb8dfb5fed23964651188ef206 so
that a TextView with Container:border-width > 0 does not get its handles
and magnified region shifted up/left from where they should be.
https://bugzilla.gnome.org/show_bug.cgi?id=786986
Daniel Boles [Tue, 29 Aug 2017 10:24:19 +0000 (11:24 +0100)]
Expander: Don’t set event_window over whole widget
realize() gave the event_window the allocation of the whole widget. This
was wrong; it should be that of the title_gadget, as in size_allocate().
This broke expanders in which :expanded is TRUE before showing: Input
over the entire widget was sent to the title, making the child unable to
receive it. Clicking the child unexpectedly collapsed it. Once expanded
again, things fixed themselves as size_allocate() fixed the event_window
alloc. So, queuing a reallocate or resize after show() was a workaround.
Fix by giving event_window the allocation of the title_gadget, to match
what size_allocate() does. That is symmetrical and just plain correct.
https://bugzilla.gnome.org/show_bug.cgi?id=774134
Debarshi Ray [Mon, 28 Aug 2017 16:58:50 +0000 (18:58 +0200)]
GtkBuilder: Prefer "type-func" over "class" when looking for the GType
https://bugzilla.gnome.org/show_bug.cgi?id=786932
Aurimas Černius [Tue, 29 Aug 2017 12:49:02 +0000 (15:49 +0300)]
Updated Lithuanian translation
Rūdolfs Mazurs [Tue, 29 Aug 2017 09:17:44 +0000 (12:17 +0300)]
Update Latvian translation
Chun-wei Fan [Tue, 29 Aug 2017 05:05:52 +0000 (13:05 +0800)]
build: Install Emoji chooser GSettings files in MSVC projects
This is needed for the Emoji chooser to work on Visual Studio builds.
Daniel Boles [Sat, 12 Aug 2017 14:51:45 +0000 (15:51 +0100)]
LevelBar: Really fix underallocation of blocks
Themes should not enforce min sizes on blocks in continuous mode; in
this case, the filled block should be as large as it needs to be to
reflect the current value, and no larger or smaller than that. So, the
fact that the minimal size was selected on just levelbar block is wrong:
we should also require the levelbar.discrete class to apply min sizes.
The widget should enforce whatever correct minimum size results from the
above fix, by reapplying commit
78b4885fe8850e132d8bb06df8ab90ac6c2033e0
Except: we should not allocate/draw the filled block if the value is 0,
as in this case, the LevelBar should be empty, not have a min-size fill.
https://bugzilla.gnome.org/show_bug.cgi?id=783649
Daniel Boles [Mon, 28 Aug 2017 20:56:06 +0000 (21:56 +0100)]
TextView: Fix gesture coords with :border-width >0
Container:border-width caused the x/y coords converted to iters to be
offset inwards by that width, breaking positioning/selecting by gesture.
So, subtract :border-width in widget_to_text_window_coords(). This fixes
gesture positions, & plays fine with :margin & CSS margin/border/padding
N.B.: This is not to endorse :border-width. It’s gone in GTK+ 4 & weird
on a TextView: it’d be more intuitive to – if you must! – set it on the
TV parent. Really, please just use CSS instead. Still, it’s easy to fix.
https://bugzilla.gnome.org/show_bug.cgi?id=759725
gogo [Mon, 28 Aug 2017 21:12:23 +0000 (21:12 +0000)]
Update Croatian translation
Daniel Boles [Mon, 28 Aug 2017 19:35:47 +0000 (20:35 +0100)]
Entry: Handle :show-emoji-icon becoming false
Disconnect the now-unwanted signal handler, and hide the icon.
https://bugzilla.gnome.org/show_bug.cgi?id=786940