Ernestas Kulik [Tue, 29 May 2018 11:48:41 +0000 (14:48 +0300)]
gesture: Fix code snippet
GTK_EVENT_SEQUENCE_ACCEPTED seems to never have been a valid enumeration
value. GTK_EVENT_SEQUENCE_CLAIMED is the closest in meaning.
Ernestas Kulik [Tue, 29 May 2018 10:59:06 +0000 (13:59 +0300)]
gesture: Fix get_last_event() docs
Querying the event sequence of a gesture will always yield NULL for
non-touch events, but passing NULL in to calls to
gtk_gesture_get_last_event() is a perfectly valid use case.
Matthias Clasen [Sun, 27 May 2018 15:56:21 +0000 (11:56 -0400)]
Remove an unused struct
Positive side-effect: visual c no longer has an empty struct
to complain about.
Timm Bäder [Sun, 27 May 2018 15:44:31 +0000 (17:44 +0200)]
popover: Fix setting priv->button_pressed in ::event handler
There were two cases in that if/else cascade handling the
event_type == GDK_BUTTON_PRESS case, so priv->button_pressed never got
set.
Timm Bäder [Sun, 27 May 2018 15:44:12 +0000 (17:44 +0200)]
gdkscreen-x11: Remove redundant typedef
Causes warnings with clang.
Timm Bäder [Sun, 27 May 2018 15:37:22 +0000 (17:37 +0200)]
gl renderer: Remove an outdated comment
Matthias Clasen [Sun, 27 May 2018 15:50:17 +0000 (15:50 +0000)]
Merge branch 'master' into 'master'
icontheme: Keep dir_mtimes in order
Closes #1115
See merge request GNOME/gtk!161
Timm Bäder [Sun, 27 May 2018 12:40:07 +0000 (14:40 +0200)]
filechooserwidget: Don't chain up in ::event
GtkWidgetClass.event is NULL.
Timm Bäder [Sun, 27 May 2018 12:41:56 +0000 (14:41 +0200)]
gl renderer: Use offsets for more node types
Piotr Drąg [Sun, 27 May 2018 05:58:25 +0000 (07:58 +0200)]
Update Polish translation
Matthias Clasen [Fri, 25 May 2018 22:25:29 +0000 (18:25 -0400)]
a11y: Stop using ::event
We can just as well use notify::has-focus for the purpose of
focus tracking, and we can at the same time avoid emitting the
deprecated AtkObject::focus-event signal.
Christoph Reiter [Sat, 26 May 2018 12:23:58 +0000 (14:23 +0200)]
ci/msys2: force disable vulkan
A recent dependency change in MSYS2 made it pull in vulkan, which made
meson think it's available but it somehow links against the system vulkan dll
instead.
Disable vulkan for now.
Daniel Boles [Sat, 26 May 2018 00:06:00 +0000 (01:06 +0100)]
SpinButton: Fix an obviously wrong arg description
:climb-rate is not about what you get when you single-click on a button,
as this implied: it's what happens if you hold down a button or a key.
Fix the description of @climb_rate to new(), and while here, mention the
key in the blurb of :climb-rate itself.
Jan Alexander Steffens (heftig) [Wed, 23 May 2018 18:06:01 +0000 (20:06 +0200)]
icontheme: Keep dir_mtimes in order
Don't reverse the order each time we insert a theme. Reverse it only
once, after all themes have been loaded.
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/1115
Matthias Clasen [Wed, 23 May 2018 01:55:05 +0000 (01:55 +0000)]
Merge branch 'kill-key-events' into 'master'
Kill key events
See merge request GNOME/gtk!160
Carlos Garnacho [Tue, 22 May 2018 11:10:26 +0000 (11:10 +0000)]
Merge branch 'issue792' into 'master'
wayland: check native surface for crossing events
Closes #792
See merge request GNOME/gtk!148
Matthias Clasen [Mon, 21 May 2018 15:42:54 +0000 (11:42 -0400)]
Drop the ::key-press/release-event signals
These are the last event-type specific signals,
we are just relying on the generic ::event signal now.
Matthias Clasen [Sun, 20 May 2018 15:35:48 +0000 (11:35 -0400)]
treeview: Stop using ::key-press-event
Use a generic ::event handler instead.
Matthias Clasen [Mon, 21 May 2018 15:38:59 +0000 (11:38 -0400)]
spin button: Stop using ::key-release-event
Just use the generic ::event signal.
Matthias Clasen [Sun, 20 May 2018 16:00:22 +0000 (12:00 -0400)]
font chooser dialog: Stop using ::key-press-event
Use the generic ::event instead.
Matthias Clasen [Sun, 20 May 2018 15:48:09 +0000 (11:48 -0400)]
button: Stop using ::key-release-event
Use the generic ::event signal instead.
Matthias Clasen [Sun, 20 May 2018 15:25:28 +0000 (11:25 -0400)]
file chooser widget: Stop using ::key-press-event
Use a generic ::event handler instead.
Matthias Clasen [Sun, 20 May 2018 14:51:33 +0000 (10:51 -0400)]
file chooser entry: Stop using key-press-event
Just use the generic ::event signal for now.
Matthias Clasen [Sun, 20 May 2018 03:41:56 +0000 (23:41 -0400)]
entry: Stop using ::key-press-event
Use a generic ::event handler instead.
Daniel Boles [Mon, 21 May 2018 22:38:54 +0000 (23:38 +0100)]
StyleContext: Don't advise using invalidate()
It doesn't exist anymore! Also, set_display() is not needed/used in the
demo cited, and we were still referring to gtk3-demo, not gtk4-demo.
Daniel Boles [Mon, 21 May 2018 18:42:57 +0000 (19:42 +0100)]
Range: Up should only mean ++ if we are a GtkScale
The last round of patches to get the desired direction of value move in
response to scrolls/keypresses on scales had the inadvertent side effect
of giving the opposite direction on scrollbars. Seeing as gtkrange.c is
already a collection of hacks, add another so that fix only holds if the
instance is a GtkScale, since that is what those patches were aimed at.
Close https://gitlab.gnome.org/GNOME/gtk/issues/1065
Matthias Clasen [Sun, 20 May 2018 03:36:10 +0000 (23:36 -0400)]
emoji completion: Stop using key-press-event
The generic ::event signal will do.
Matthias Clasen [Sun, 20 May 2018 03:35:23 +0000 (23:35 -0400)]
Remove key-press-event from more docs
This signal will be going away, so stop mentioning it so much.
Matthias Clasen [Sun, 20 May 2018 03:28:44 +0000 (23:28 -0400)]
gtk-demo: Avoid key-press-event
Matthias Clasen [Sun, 20 May 2018 03:20:53 +0000 (23:20 -0400)]
popover: Drop key_press_event handler
We can do the same in the generic ::event handler.
Matthias Clasen [Thu, 17 May 2018 15:48:34 +0000 (16:48 +0100)]
emoji: Hide recent section when empty
This is part of https://gitlab.gnome.org/GNOME/gtk/merge_requests/143
by Julian Sperber.
Timm Bäder [Sat, 19 May 2018 21:03:32 +0000 (23:03 +0200)]
widget: Properly remove event controllers in finalize
We were mutating the list while iterating over it. This was not a
problem before since remove_controller just set the controller pointer
to NULL instead of actually removing it from the list of controllers.
Timm Bäder [Sat, 19 May 2018 10:38:01 +0000 (12:38 +0200)]
Add GtkEventControllerKey to the docs
Timm Bäder [Mon, 14 May 2018 17:03:17 +0000 (19:03 +0200)]
widget: Remove controller sequence-state-changed signal connection
We can avoid a signal connection per event controller (and the
EventControllerData struct) since every event controller knows the
widget it's attached to.
Timm Bäder [Wed, 16 May 2018 15:56:34 +0000 (17:56 +0200)]
Add basic searchbar set_key_capture_widget tests
Make sure we're correctly resetting the internal key capture widget
pointer when the widget goes away.
Timm Bäder [Wed, 16 May 2018 15:56:08 +0000 (17:56 +0200)]
searchbar: Add missing GDK_AVAILABLE_IN_ALL marker
Timm Bäder [Wed, 16 May 2018 12:31:24 +0000 (14:31 +0200)]
snapshot: Remove superfluous typedef
We're already doing this in gtktypes.h
Fixes #214
Timm Bäder [Mon, 14 May 2018 16:19:44 +0000 (18:19 +0200)]
widget: Directly notify gestures of grab
Since each widget has a list of event controllers now, we don't need to
connect to ::grab-notify of the widget for every controller.
Timm Bäder [Sat, 12 May 2018 05:50:24 +0000 (07:50 +0200)]
widget: Fix measure docs
Fix a typo and don't ever pass NULL to a ::measure() implementation.
Timm Bäder [Sat, 12 May 2018 04:57:59 +0000 (06:57 +0200)]
gl renderer: Add helper for printing a render node tree
Timm Bäder [Thu, 10 May 2018 18:00:17 +0000 (20:00 +0200)]
gestures demo: widget property is not writable
Use gtk_widget_add_controller instead.
Timm Bäder [Wed, 16 May 2018 12:08:19 +0000 (14:08 +0200)]
scrollbar: Remove get_wheel_delta
Unused and undocumented.
Timm Bäder [Thu, 10 May 2018 11:56:54 +0000 (13:56 +0200)]
cssvalue: Remove typechecks
This path is more than hot and those type checks ruin any kind of real
life profiling.
Fabio Tomat [Fri, 18 May 2018 16:19:35 +0000 (16:19 +0000)]
Update Friulian translation
Matthias Clasen [Thu, 17 May 2018 15:37:26 +0000 (16:37 +0100)]
emoji: Improve section scrolling
Leave some space above the section heading when scrolling.
This is a part of https://gitlab.gnome.org/GNOME/gtk/merge_requests/143
by Julian Sperber.
Matthias Clasen [Thu, 17 May 2018 09:59:45 +0000 (09:59 +0000)]
Merge branch 'wip/restart-cursor-animation' into 'master'
wayland: Fix restarting cursor animation
See merge request GNOME/gtk!149
Matthias Clasen [Thu, 17 May 2018 09:48:36 +0000 (09:48 +0000)]
Merge branch 'paste-scrolling' into 'master'
textview: Don't scroll for pastes in another view
See merge request GNOME/gtk!152
Emmanuele Bassi [Tue, 15 May 2018 08:51:37 +0000 (08:51 +0000)]
Merge branch 'pages-docs' into 'master'
Publish master docs with gitlab pages.
See merge request GNOME/gtk!135
Chun-wei Fan [Tue, 15 May 2018 05:28:08 +0000 (13:28 +0800)]
gtkemojicompletion.c: Don't use g_autoptr()
This code is also built with non-GCC/non-CLang compilers, so don't use a
GCCism here.
Chun-wei Fan [Tue, 15 May 2018 05:27:10 +0000 (13:27 +0800)]
gdkcairocontext*.h: Include cairo.h consistently
The other sources include cairo.h by just using #include <cairo.h>, so
do likewise here.
Matthias Clasen [Mon, 14 May 2018 12:03:34 +0000 (13:03 +0100)]
textview: Don't scroll for pastes in another view
GtkTextView scrolls to the insertion point when the text
buffer signals a paste is done. This is wrong when there
are multiple views on the same buffer, and the paste
happened in another view.
To fix this, flip the handling of the scroll_after_paste
boolean to only be TRUE if we know that we want to scroll.
Fabio Tomat [Mon, 14 May 2018 11:12:37 +0000 (11:12 +0000)]
Update Friulian translation
Fabio Tomat [Mon, 14 May 2018 05:21:23 +0000 (05:21 +0000)]
Update Friulian translation
Mohammed Sadiq [Sun, 13 May 2018 07:57:07 +0000 (13:27 +0530)]
appchooserdialog: Fix memory leak
Mohammed Sadiq [Sun, 13 May 2018 07:51:06 +0000 (13:21 +0530)]
appchooserdialog: Don't fire notify::heading twice
The gtk_app_chooser_dialog_set_heading() function do emit
notify::heading. Since the setter simply calls the function,
the setter itself shouldn't emit a notify signal by itself.
Mohammed Sadiq [Sun, 13 May 2018 05:29:34 +0000 (10:59 +0530)]
aboutdialog: Fix memory leak
Mohammed Sadiq [Sun, 13 May 2018 02:53:53 +0000 (08:23 +0530)]
video: Fix memory leak
Mohammed Sadiq [Sat, 12 May 2018 12:02:16 +0000 (17:32 +0530)]
examples: Remove unused variables
Mohammed Sadiq [Sat, 12 May 2018 04:01:32 +0000 (09:31 +0530)]
snapshot: Fix typo in documentation comment
Mohammed Sadiq [Fri, 11 May 2018 06:28:34 +0000 (11:58 +0530)]
label: Rearrange struct members
Rearranging so can save us 8 bytes per GtkLabel
on 32/64 bit aligned memory.
Not a big count, but we get it for free.
Mohammed Sadiq [Fri, 11 May 2018 04:49:09 +0000 (10:19 +0530)]
textview: Always show select-all button in touch popup
"Select all" action is possible regardless of the text selection state
or if the text is editable or not.
Mohammed Sadiq [Fri, 11 May 2018 04:10:48 +0000 (09:40 +0530)]
textview: Reset bubble source id once run
The bubble_timeout_id was reset only on some special case.
And so warnings were shown when the source is being tried
to be removed with the already removed id.
Fix this by unconditionally resetting the id on start of the function.
Mohammed Sadiq [Fri, 11 May 2018 03:17:56 +0000 (08:47 +0530)]
textview: Simplify creating bubble action buttons
Buttons can be created simply with gtk_button_new_from_icon_name().
Mohammed Sadiq [Fri, 11 May 2018 01:39:45 +0000 (07:09 +0530)]
widget: Avoid an unnecessary check
The preceding loop terminates when either the widget is NULL,
or if their type matches. There is no reason to check that again
Jonas Ådahl [Wed, 9 May 2018 20:13:10 +0000 (22:13 +0200)]
wayland: Fix restarting cursor animation
When an animated cursor was set and the previous cursor animation delay
happened to be the same, we wouldn't restart the animation timeout and
just return G_SOURCE_CONTINUE assuming the timer would continue. This
assumption is however only valid if the function was called from the
timeout, which is not the case.
Instead also arm the timer also if there is no previous timer active.
Olivier Fourdan [Thu, 19 Apr 2018 12:22:04 +0000 (14:22 +0200)]
wayland: check native surface for crossing events
gdk_wayland_*_grab()/ungrab() would emit crossing events which translate
as focus_in/focus_out events for keyboard.
However, the ungrab() functions compare the native toplevel as this is
what gets the Wayland pointer enter/leave events with the grab surface,
so if the grab is issued on a child gdk surface, those won't match and
we would emit more focus_out events than focus_in.
This means that a widget such as spice-gtk which issues a keyboard grab
whenever the pointer enters the surface and releases the grab when it
leaves the surface would get uneven numbers of focus_in/focus_out
events.
Also, gdk_wayland_seat_ungrab() would not emit crossing events for
keyboard devices, whereas gdk_wayland_device_ungrab() does, which adds
even more potential discrepancies between focus_in/focus_out events.
To solve this problem, introduce two new helper functions which check
the relevant native surfaces to emit crossing events when needed that
get called evenly from both gdk_wayland_seat_grab()/ungrab() and gdk
_wayland_device_grab()/ungrab() APIs.
Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=780422
Closes https://gitlab.gnome.org/GNOME/gtk/issues/792
Mohammed Sadiq [Wed, 9 May 2018 01:53:05 +0000 (07:23 +0530)]
examples: Use icon-name property to set button icons
Gtk4 added an icon-name property for GtkButton.
Mohammed Sadiq [Tue, 8 May 2018 15:54:29 +0000 (21:24 +0530)]
examples: Simplify counting buffer lines
We do have a gtk_text_buffer_get_line_count() function
to get the line count.
Mohammed Sadiq [Tue, 8 May 2018 14:23:27 +0000 (19:53 +0530)]
examples: Remove explicit gtk_widget_show()
In gtk4, widgets are visible by default.
Robert Ancell [Tue, 8 May 2018 23:28:53 +0000 (11:28 +1200)]
Fix comment typo introduced in
a32725bc9ab
Marek Cernocky [Tue, 8 May 2018 20:55:59 +0000 (22:55 +0200)]
Updated Czech translation
Mohammed Sadiq [Tue, 8 May 2018 12:47:54 +0000 (18:17 +0530)]
examples: Take advantage of user_data passed
The last parameter of the signal callback from .ui
is the template's object from which the class is
derived.
And so, we already have access to the window object.
Let's just use it.
Emmanuele Bassi [Tue, 8 May 2018 08:49:27 +0000 (09:49 +0100)]
ci: Disable tests when building Graphene
Our flatpak-builder manifests include building Graphene from Git; since
we're building the GTK demos, it's pointless to build the Graphene tests
as well. Disabling tests and benchmarks avoids pointless installations
inside the Flatpak build repo that will just be removed by the time we
bundle the demo.
Emmanuele Bassi [Tue, 8 May 2018 13:18:50 +0000 (14:18 +0100)]
docs: List private headers for gtk-doc to ignore
We have a lot of private headers that should not be used by gtk-doc when
scanning for symbols.
Emmanuele Bassi [Thu, 3 May 2018 11:58:33 +0000 (12:58 +0100)]
Avoid absolute paths when building the API reference
We should always use relative paths, or include_directories objects, to
allow using GTK as a subproject.
Daniel Mustieles [Tue, 8 May 2018 13:12:45 +0000 (15:12 +0200)]
Updated Spanish translation
Daniel Mustieles [Tue, 8 May 2018 13:06:32 +0000 (15:06 +0200)]
Updated Spanish translation
Mohammed Sadiq [Tue, 8 May 2018 09:04:03 +0000 (14:34 +0530)]
examples: Don't use private members for final classes
Only derivable classes are required to have private members
so that derived classes can't override them.
Mohammed Sadiq [Mon, 7 May 2018 18:43:18 +0000 (00:13 +0530)]
reference: Replace reference to gtk3 with gtk4
Mohammed Sadiq [Mon, 7 May 2018 18:22:18 +0000 (23:52 +0530)]
reference: Use gtk+-4 for compilation in examples
Mohammed Sadiq [Mon, 7 May 2018 16:42:09 +0000 (22:12 +0530)]
examples: Simplify .ui files
Run gtk4-builder-tool recursively
Mohammed Sadiq [Mon, 7 May 2018 16:32:10 +0000 (22:02 +0530)]
examples: Fix Makefiles to use gtk4 for build
Benjamin Otte [Mon, 7 May 2018 15:31:26 +0000 (17:31 +0200)]
dnd: Make "formats" a construct-only property
... and hide the member variable inside the DragContextPrivate.
Benjamin Otte [Mon, 7 May 2018 15:16:29 +0000 (17:16 +0200)]
wayland: Remove stray if
Leftover from
d056be4ea238e6f4371230b1a892ed0100770848.
I need more sleep when I need to fixup the fixups of my fixups now.
Benjamin Otte [Mon, 7 May 2018 15:14:52 +0000 (17:14 +0200)]
win32: Remove unused file
Benjamin Otte [Mon, 7 May 2018 15:54:26 +0000 (15:54 +0000)]
Merge branch 'wip/sadiq/fixes' into 'master'
icon-browser: Fix typo in description
See merge request GNOME/gtk!138
Mohammed Sadiq [Mon, 7 May 2018 15:19:12 +0000 (20:49 +0530)]
icon-browser: Fix typo in description
This is shown as tooltip-text
Benjamin Otte [Mon, 7 May 2018 14:45:32 +0000 (16:45 +0200)]
gsk: Improve GSK_RENDERER behavior
1. Include the broadway renderer (so we can test it properly fails on
Wayland or X11)
2. List all potential renderers, print useful information when Vulkan
is not compiled in instea dof omitting it
3. Improve docs
Benjamin Otte [Sun, 6 May 2018 15:06:57 +0000 (17:06 +0200)]
wayland: Fix memleak
7f8a8f221d60bc5da23602e5e024eb91f8b0f758 forgot to free the data offer
passed to it.
Matthias Clasen [Mon, 7 May 2018 02:45:36 +0000 (22:45 -0400)]
Update docs for debug environment variables
Just the usual pre-release doc fixups.
Matthias Clasen [Mon, 7 May 2018 02:06:35 +0000 (22:06 -0400)]
Document the GSK_RENDERER environment variable
Just the usual pre-release doc fixups.
Matthias Clasen [Mon, 7 May 2018 01:58:53 +0000 (21:58 -0400)]
Update build docs
Just the usual pre-release doc fixups.
Matthias Clasen [Mon, 7 May 2018 01:21:43 +0000 (21:21 -0400)]
Miscellaneous docs improvements
Just the usual pre-release doc fixups.
Matthias Clasen [Mon, 7 May 2018 00:42:12 +0000 (20:42 -0400)]
Add GtkWidgetPaintable to the docs
Just the usual pre-release doc fixups.
Matthias Clasen [Mon, 7 May 2018 00:34:31 +0000 (20:34 -0400)]
Add GdkPaintable to the docs
Just the usual pre-release doc fixups.
Daniel Boles [Sun, 6 May 2018 20:41:57 +0000 (21:41 +0100)]
MediaStream: Fix capitalisation of two new %TRUEs
Matthias Clasen [Sun, 6 May 2018 19:37:13 +0000 (15:37 -0400)]
Add more media docs
Jordan Petridis [Mon, 30 Apr 2018 14:12:20 +0000 (17:12 +0300)]
gitlabci: Build and publish docs with gitlab pages.
Benjamin Otte [Sun, 6 May 2018 00:06:53 +0000 (02:06 +0200)]
wayland: Redo DND offer handling
Instead of tracking offers in GdkWaylandSelection objects, track the
pending offer in the GdkWaylandSeat and pass it to the GdkDragContext
once we get an enter event.
Benjamin Otte [Sat, 5 May 2018 18:36:12 +0000 (20:36 +0200)]
gdk: Remove unnecessary assignments
The variable is never read again.