Start working on mac builder script

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6780 from nextcloud/bugfix/groupfolder-rename

Check if sync item is actually a folder before processing it

Fix renaming tests for files under group folders.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Only check for external storage permissions when it is a folder.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove commented out code.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Improve logs for rename check.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add test to detect file renames in external storage.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Check if file is already in database before processing rename.

- The rename check was not happening since it was hitting error "Move without permission to rename base file"
- The file was then processed as a new file
- Also check #6535.

Possible workaround for #6549.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6790 from nextcloud/feature/update-channel-2

 Add new update channels part 2.

Translate enterprise channel explanation string.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use NEXTCLOUD_DEV to check if client is branded instead of checking for string.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove const from POD in method declaration.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove resolved TO DO comment.

Subscription and channel are supposed to be a general setting, not per user.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Extend capabilities test to include desktopEnterpriseChannel check.

Signed-off-by: Camila Ayres <hello@camilasan.com>

If the client is branded the default update channel is stable.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Separate the list of valid update channels for enterprise and non-enterprise.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix the logic to determine update channels available, default value and what info to show the user.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Update desktopEnterpriseChannel value when capabilities change.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Save desktopEnterpriseChannel value in the config file.

The default should be what is returned by defaultUpdateChannel()
when desktopEnterpriseChannel is not available.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add desktopEnterpriseChannel to the capabilities check.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Only list enterprise for customers not running branded clients.

Signed-off-by: Camila Ayres <hello@camilasan.com>

NextcloudDev is not a branded client.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add enterprise explanation to message shown when user changes update channel.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Do not show enterprise channel for branded clients.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Extend Capabilities tests.

Signed-off-by: Camila Ayres <hello@camilasan.com>

List enterprise update channel when available.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Update server hasValidSubscription if capabilities change for account.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add user specific setting for server hasValidScriptionValue.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add general config setting for server hasValidSubscription.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Check if server has valid subcription.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6658 from nextcloud/feature/update-channel

Add daily update channel.

Enable RVO (return value optimization).

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove unused updatesegment option from updater query.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use only const auto in obvious pointer.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use default in switch.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Rename var in configfile.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Remove commented out line.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Improve text displayed when user switches update channel.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Enforce the update channel based on the current client installed.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add versionSuffix function to Theme.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use the value from MIRALL_VERSION_SUFFIX as the default update channel.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Change the default MIRALL_VERSION_SUFFIX from "git" to "daily".

Signed-off-by: Camila Ayres <hello@camilasan.com>

List daily update channel in the general settings view.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Clean up code in GeneralSettings.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Adds info about daily builds to message shown if user changes update channel.

- Also makes the explanation more concise.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Modernize ConfigFile::updateChannel and Updater::getQueryParams.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add daily update channel.

- Set update channel options list in slotUpdateInfo.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6868 from nextcloud/bugfix/avoidDeadlockWithImplicitHydrationSelfRequests

avoid deadlock: cancel hydration requests coming from itself

avoid deadlock: cancel hydration requests coming from itself

our current infrastructure will cause a deadlock for any hydration
requests coming from desktop files client itself

the main thread is responsible for executing the hydration request but
if the same thread is already blocked waiting for the hydration to
happen, both (open system call and hydration request handling) process
will never be completed and wait for each over in a stuck cycle

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6864 from nextcloud/bugfix/fixHydrationLogs

avoid logs too verbose and with binary data

avoid logs too verbose and with binary data

with those logs, hydrating is causing too much log to be written and
after some time (with big fixles), hydration is failing

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6802 from nextcloud/bugfix/share-suffix-fix

Fix sharePath for virtual paths using suffix vfs mode

Fix sharePath for virtual paths using suffix vfs mode

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6773 from nextcloud/bugfix/cmd-sync

Bugfix nextcloudcmd when syncing results in deleting all files

Add tests to remove all files when sycing with or without nextcloudcmd.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add sync option for nextcloudcmd.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Use readable variable names.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Make warning text before deleting all files more clear and concise.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix #3144: check for promptDeleteAllFiles config setting before emitting signal to display warning.

The signal is not connected to any slot when running nextcloudcmd.
The callback to finish the sync was never being called because the check for the config was done in the slot,
which was never called.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6821 from nextcloud/bugfix/undeletable-vfs-suffic-files

Allow deletion of virtual suffix placeholder files

Properly reset fakefolder test state post-placeholder file delete in testsyncvirtualfiles

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ensure stripping of suffix vfs placeholder file's suffix when issuing delete command to server

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Amend behaviour of suffix virtual files test to reflect new expected behaviour

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Allow deletion of virtual suffix placeholder files

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6839 from nextcloud/bugfix/rw-folders-broken

Bugfix/rw folders broken

Do not wrap macOS ifdefs in filesystem when parent function already wrapped in ifdef

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not re-generate standard string path twice

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Ensure we are re-adding same permissions as removed

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6846 from nextcloud/enh/add-cfapi-debug-logs

Add cfapi debug logs

Print desktop client process id.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add new cfapi callbacks for logging.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add more logs to track file hydration.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6841 from nextcloud/bugfix/updateEncryptionStateWhenServerChange

Bugfix/update encryption state when server change

ignore encrypted items during discovery when encryption is disabled

when we know a folder should be encrypted but encryption client side app
is disabled, ignore any items in the encrypted folders

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

do not allow to select e2ee folders if the server support is missing

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

maintain e2ee state even if the server does not support e2ee

might be that the server previously supported e2ee and e2ee folders
exist

so we have to fetch the info to properly handle it on client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6833 from nextcloud/bugfix/fp-account-crash

Fix crash when updating enabled File Provider domains (macOS VFS)

Remove no longer existing account id from configured vfs accounts list

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Prevent crash when updating file provider domains if the account for which a file provider domain was configured no longer exists

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use accountfwd header for account forward declaration in account header itself, preventing conflicting decls

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Assert validity of accountstate and its accountptr when adding it

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove overwrought loadFromSettings method from AccountState

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Take AccountPtr by reference in accountstate constructor

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #6637 from nextcloud/feature/nc-assistance

Display the NC assistant in the main Window

Move the logic for handling the featured app qml to cpp.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Display the Nextcloud assistant icon in the main window.

- If NC assistant is enabled in the server, display the icon
to open it instead of Talk. Talk is then displayed in the
list with the other apps.
- The direct link is only available in the assistant app >= 1.0.9.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #6832 from nextcloud/ci/testIsMountRootProperty

Ci/test is mount root property

automated test: allow rename of the child items of a mount point

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>