nextcloud-desktop.git
22 months agoDisplay more verbose share display names for shares that have sharees with identical...
Claudio Cambra [Thu, 17 Oct 2024 06:00:58 +0000 (14:00 +0800)]
Display more verbose share display names for shares that have sharees with identical display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoCheck for and store indices of shares with duplicate display names
Claudio Cambra [Thu, 17 Oct 2024 06:00:15 +0000 (14:00 +0800)]
Check for and store indices of shares with duplicate display names

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoAdd ability to make share sharee displayname more verbose
Claudio Cambra [Thu, 17 Oct 2024 05:59:23 +0000 (13:59 +0800)]
Add ability to make share sharee displayname more verbose

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #6752 from nextcloud/bugfix/locally-available-folders-open-in...
Matthieu Gallien [Fri, 18 Oct 2024 08:59:32 +0000 (10:59 +0200)]
Merge pull request #6752 from nextcloud/bugfix/locally-available-folders-open-in-browser-tray-header

Fix opening of locally available groupfolders in web browser from tray drop-down

22 months agoTake reference to folder in folder map within User::getFolder
Claudio Cambra [Wed, 16 Oct 2024 02:10:54 +0000 (10:10 +0800)]
Take reference to folder in folder map within User::getFolder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoPrevent double slashes in group folder path parsing
Claudio Cambra [Fri, 10 May 2024 05:13:38 +0000 (13:13 +0800)]
Prevent double slashes in group folder path parsing

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoUse for : loop in getFolder
Claudio Cambra [Fri, 10 May 2024 05:11:27 +0000 (13:11 +0800)]
Use for : loop in getFolder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoConstify openLocalFolder
Claudio Cambra [Fri, 10 May 2024 05:10:43 +0000 (13:10 +0800)]
Constify openLocalFolder

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #7360 from nextcloud/bugfix/mac-vfs-storage-use-elide
Claudio Cambra [Fri, 18 Oct 2024 08:18:13 +0000 (16:18 +0800)]
Merge pull request #7360 from nextcloud/bugfix/mac-vfs-storage-use-elide

Make sure storage headers do not collide with each other in macOS VFS settings

22 months agoMake sure storage headers do not collide with each other in macOS VFS settings
Claudio Cambra [Fri, 18 Oct 2024 08:11:31 +0000 (16:11 +0800)]
Make sure storage headers do not collide with each other in macOS VFS settings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #7323 from nextcloud/bugfix/mac-vfs-ci-swift6
Claudio Cambra [Fri, 18 Oct 2024 06:20:42 +0000 (14:20 +0800)]
Merge pull request #7323 from nextcloud/bugfix/mac-vfs-ci-swift6

Fix Swift 6-related CI errors with macOS VFS module

22 months agoRun post-auth state check with main actor task
Claudio Cambra [Tue, 15 Oct 2024 06:21:03 +0000 (14:21 +0800)]
Run post-auth state check with main actor task

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoFix swift 6 concurrency error regarding use of authAttemptState
Claudio Cambra [Tue, 15 Oct 2024 06:17:56 +0000 (14:17 +0800)]
Fix swift 6 concurrency error regarding use of authAttemptState

Cannot pass a local variable into a concurrently executing Task. It's
not a real issue as we are using a semaphore to wait before using this
variable for anything outside of the Task block, but still.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #7328 from nextcloud/bugfix/global-progress-vfs-bigsur
Claudio Cambra [Fri, 18 Oct 2024 06:00:29 +0000 (14:00 +0800)]
Merge pull request #7328 from nextcloud/bugfix/global-progress-vfs-bigsur

Check for availability of Big Sur (under 11.3) before using VFS progress tracking method

22 months agoWrap use of NSFileProviderManager globalProgress in availability check
Claudio Cambra [Wed, 16 Oct 2024 06:13:00 +0000 (14:13 +0800)]
Wrap use of NSFileProviderManager globalProgress in availability check

This selector was only made available on macOS 11.3
Just to be safe we should check for the availability

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #6123 from nextcloud/bugfix/docs-format
Claudio Cambra [Fri, 18 Oct 2024 05:34:09 +0000 (13:34 +0800)]
Merge pull request #6123 from nextcloud/bugfix/docs-format

Fix issues on manpages

22 months agoIncorporate doc fixes from pull request #6122
Claudio Cambra [Mon, 9 Oct 2023 02:34:40 +0000 (10:34 +0800)]
Incorporate doc fixes from pull request #6122

Fix issues on manpages

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Fri, 18 Oct 2024 02:52:09 +0000 (02:52 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7351 from nextcloud/bugfix/alwaysRecordMovedItemsAfterServerReplied
Claudio Cambra [Fri, 18 Oct 2024 02:22:09 +0000 (10:22 +0800)]
Merge pull request #7351 from nextcloud/bugfix/alwaysRecordMovedItemsAfterServerReplied

on receiving reply of a remote MOVE: always record it

22 months agoon receiving reply of a remote MOVE: always record it
Matthieu Gallien [Thu, 17 Oct 2024 15:58:37 +0000 (17:58 +0200)]
on receiving reply of a remote MOVE: always record it

even if local item has disappeared, record the result of a remote MOVE
when receiving the reply

enable better state tracking when syncing rename or move operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7346 from nextcloud/Rello-patch-1
Claudio Cambra [Fri, 18 Oct 2024 02:07:58 +0000 (10:07 +0800)]
Merge pull request #7346 from nextcloud/Rello-patch-1

remove ownCloud wording in logging

22 months agoremove ownCloud wording in logging
Rello [Thu, 17 Oct 2024 07:47:16 +0000 (09:47 +0200)]
remove ownCloud wording in logging

remove ownCloud wording in logging

Signed-off-by: Rello <Rello@users.noreply.github.com>
22 months agoMerge pull request #3014 from nextcloud/foreground-background
Claudio Cambra [Thu, 17 Oct 2024 08:45:17 +0000 (16:45 +0800)]
Merge pull request #3014 from nextcloud/foreground-background

Show/Hide Menubar and Dock Icon on macOS

22 months agoShow/Hide Menubar and Dock Icon
Elsie Hupp [Sat, 8 May 2021 15:56:42 +0000 (11:56 -0400)]
Show/Hide Menubar and Dock Icon

Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>
22 months agoMerge pull request #4367 from nextcloud/finder-sidebar-icon-fix
Claudio Cambra [Thu, 17 Oct 2024 07:55:13 +0000 (15:55 +0800)]
Merge pull request #4367 from nextcloud/finder-sidebar-icon-fix

Fix Finder sidebar icon to work as a "template" image

22 months agoFix Finder sidebar icon to work as a "template" image and change to SF Symbols linewe...
Elsie Hupp [Mon, 27 Jun 2022 23:18:25 +0000 (19:18 -0400)]
Fix Finder sidebar icon to work as a "template" image and change to SF Symbols lineweights

Signed-off-by: Elsie Hupp <github@elsiehupp.com>
22 months agoMerge pull request #7321 from nextcloud/dependabot/github_actions/cpp-linter/cpp...
Matthieu Gallien [Thu, 17 Oct 2024 07:53:13 +0000 (09:53 +0200)]
Merge pull request #7321 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.13.2

Bump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2

22 months agoBump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2
dependabot[bot] [Mon, 14 Oct 2024 23:36:26 +0000 (23:36 +0000)]
Bump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2

Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.13.1 to 2.13.2.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.13.1...v2.13.2)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
22 months agoMerge pull request #7334 from nextcloud/bugfix/useFileIdToTrackRenamedItems
Matthieu Gallien [Thu, 17 Oct 2024 07:46:17 +0000 (09:46 +0200)]
Merge pull request #7334 from nextcloud/bugfix/useFileIdToTrackRenamedItems

Bugfix/use file id to track renamed items

22 months agoremove the enforcement of identical etag for a server side item MOVE
Matthieu Gallien [Wed, 16 Oct 2024 10:10:10 +0000 (12:10 +0200)]
remove the enforcement of identical etag for a server side item MOVE

orignally added by https://github.com/owncloud/client/pull/6632

most probably a too strong assumption on the behavior of the Nextcloud
server

better check real item metadata like fileid, size or modification time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agohandle NEW/NEW conflicts by being real conflicts
Matthieu Gallien [Wed, 16 Oct 2024 13:06:13 +0000 (15:06 +0200)]
handle NEW/NEW conflicts by being real conflicts

NEW/NEW conflicts could sometime be ignored and replaced by update
metadata instructions

we stop doing this and handle them like any other conflicts

that would cause more download from the server

those conflicts would be solved automatically in case this is not a real
conflict but the client was missing the server reply with the updated
metadata

will enable more changes to improve MOVE detection from server side

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoin automated tests, update modtime when modifying the content of a file
Matthieu Gallien [Wed, 16 Oct 2024 11:12:43 +0000 (13:12 +0200)]
in automated tests, update modtime when modifying the content of a file

why one would not update the modification time when modifying a remote
file during automated tests

there is no reason to not update the modification time as this is what
is done by the server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7291 from nextcloud/bugfix/improveLocalDiscoveryLogs
Matthieu Gallien [Thu, 17 Oct 2024 06:52:36 +0000 (08:52 +0200)]
Merge pull request #7291 from nextcloud/bugfix/improveLocalDiscoveryLogs

better logs to understand when a folder is locally discovered

22 months agobetter logs tounderstand when a folder is local scanned
Matthieu Gallien [Thu, 10 Oct 2024 12:24:35 +0000 (14:24 +0200)]
better logs tounderstand when a folder is local scanned

should hopefully allows to understand when local file system discovery
is done or omitted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7285 from nextcloud/bugfix/catchFilesystemExceptions
Matthieu Gallien [Thu, 17 Oct 2024 06:51:47 +0000 (08:51 +0200)]
Merge pull request #7285 from nextcloud/bugfix/catchFilesystemExceptions

test syncing of read-only .lnk windows shorcuts

22 months agotest syncing of read-only .lnk windows shorcuts
Matthieu Gallien [Tue, 8 Oct 2024 12:46:59 +0000 (14:46 +0200)]
test syncing of read-only .lnk windows shorcuts

related to https://github.com/nextcloud/desktop/pull/7282

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Thu, 17 Oct 2024 02:52:33 +0000 (02:52 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7333 from nextcloud/bugfix/signature
Matthieu Gallien [Wed, 16 Oct 2024 13:22:21 +0000 (15:22 +0200)]
Merge pull request #7333 from nextcloud/bugfix/signature

Bugfix/signature

22 months agoFail with error before calling folder metada setup when received empty signature.
Camila Ayres [Mon, 14 Oct 2024 14:36:38 +0000 (16:36 +0200)]
Fail with error before calling folder metada setup when received empty signature.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoReport client status error when signature is empty.
Camila Ayres [Thu, 26 Sep 2024 17:16:40 +0000 (19:16 +0200)]
Report client status error when signature is empty.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoAdd test testFolderMetadataWithEmptySignatureDecryptFails.
Camila Ayres [Tue, 16 Jul 2024 18:29:07 +0000 (20:29 +0200)]
Add test testFolderMetadataWithEmptySignatureDecryptFails.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoCheck if signature is empty.
Camila Ayres [Tue, 16 Jul 2024 12:56:20 +0000 (14:56 +0200)]
Check if signature is empty.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoMerge pull request #7322 from nextcloud/bugfix/vfs-crash-socketcontroller
Claudio Cambra [Wed, 16 Oct 2024 08:09:05 +0000 (16:09 +0800)]
Merge pull request #7322 from nextcloud/bugfix/vfs-crash-socketcontroller

Fix crash caused due to null accountstate in FileProviderSocketController

22 months agoFix crash caused by null accountstate due to bad domain identifier parsed from FPExt
Claudio Cambra [Tue, 15 Oct 2024 03:30:54 +0000 (11:30 +0800)]
Fix crash caused by null accountstate due to bad domain identifier parsed from FPExt

Turns out since we are forced to replace colons with hyphens we need to
replace them back to colons when we receive the domain identifier from
the file provider extension. If we do not then we get a null
accountState pointer in the socket controller and this causes a crash

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #7319 from nextcloud/bugfix/betterMessageForFilesDeletionDetection
Matthieu Gallien [Wed, 16 Oct 2024 07:45:11 +0000 (09:45 +0200)]
Merge pull request #7319 from nextcloud/bugfix/betterMessageForFilesDeletionDetection

improve wordings of confirmation dialog when many files are deleted

22 months agoimprove wordings of confirmation dialog when many files are deleted
Matthieu Gallien [Mon, 14 Oct 2024 13:50:18 +0000 (15:50 +0200)]
improve wordings of confirmation dialog when many files are deleted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Wed, 16 Oct 2024 02:57:54 +0000 (02:57 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7320 from nextcloud/bugfix/text
Matthieu Gallien [Tue, 15 Oct 2024 06:55:55 +0000 (08:55 +0200)]
Merge pull request #7320 from nextcloud/bugfix/text

Make string more readable for translators.

22 months agoMake string more readable for translators.
Camila Ayres [Mon, 14 Oct 2024 18:49:21 +0000 (20:49 +0200)]
Make string more readable for translators.

Fix #7309.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoMerge pull request #7316 from nextcloud/bugfix/blacklist-string-tr
Claudio Cambra [Tue, 15 Oct 2024 02:59:53 +0000 (10:59 +0800)]
Merge pull request #7316 from nextcloud/bugfix/blacklist-string-tr

Fix poor translation strings for blacklisted error reason strings

22 months agoFix poor translation strings for blacklisted error reason strings
Claudio Cambra [Mon, 14 Oct 2024 02:50:24 +0000 (10:50 +0800)]
Fix poor translation strings for blacklisted error reason strings

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Tue, 15 Oct 2024 02:45:28 +0000 (02:45 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Mon, 14 Oct 2024 02:44:37 +0000 (02:44 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Sun, 13 Oct 2024 02:51:58 +0000 (02:51 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Sat, 12 Oct 2024 02:45:14 +0000 (02:45 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7240 from nextcloud/bugfix/mac-vfs-login-loop
Claudio Cambra [Fri, 11 Oct 2024 08:43:27 +0000 (16:43 +0800)]
Merge pull request #7240 from nextcloud/bugfix/mac-vfs-login-loop

22 months agoStop fetching user profile details now that is not necessary in file provider extension
Claudio Cambra [Mon, 30 Sep 2024 08:05:50 +0000 (16:05 +0800)]
Stop fetching user profile details now that is not necessary in file provider extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoHandle userId correctly in File Provider Extension client interface
Claudio Cambra [Mon, 30 Sep 2024 08:05:30 +0000 (16:05 +0800)]
Handle userId correctly in File Provider Extension client interface

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoProperly provide both user-provided username AND backing user ID to File Provider...
Claudio Cambra [Mon, 30 Sep 2024 08:04:48 +0000 (16:04 +0800)]
Properly provide both user-provided username AND backing user ID to File Provider Extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoFetch user profile (and user ID) when setting up domain account
Claudio Cambra [Mon, 30 Sep 2024 06:05:33 +0000 (14:05 +0800)]
Fetch user profile (and user ID) when setting up domain account

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoWait for task to complete synchronously after setting up domain account rather than...
Claudio Cambra [Mon, 30 Sep 2024 05:53:55 +0000 (13:53 +0800)]
Wait for task to complete synchronously after setting up domain account rather than wrapping everything in task

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoRetry authentication if connection timed out
Claudio Cambra [Mon, 30 Sep 2024 05:52:18 +0000 (13:52 +0800)]
Retry authentication if connection timed out

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoTry to authenticate new account details before setting them
Claudio Cambra [Mon, 30 Sep 2024 05:46:47 +0000 (13:46 +0800)]
Try to authenticate new account details before setting them

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoMerge pull request #7286 from nextcloud/bugfix/cmd-hosturl-parse
Claudio Cambra [Fri, 11 Oct 2024 06:46:06 +0000 (14:46 +0800)]
Merge pull request #7286 from nextcloud/bugfix/cmd-hosturl-parse

Properly check for webdav or dav path in provided host url for cmd.cpp

22 months agoProperly check for webdav or dav path in provided host url for cmd.cpp
Claudio Cambra [Wed, 9 Oct 2024 01:47:03 +0000 (09:47 +0800)]
Properly check for webdav or dav path in provided host url for cmd.cpp

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoEncourage use of https in error message for cmd.cpp
Claudio Cambra [Wed, 9 Oct 2024 01:46:30 +0000 (09:46 +0800)]
Encourage use of https in error message for cmd.cpp

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoRemove unused <random> import in cmd.cpp
Claudio Cambra [Wed, 9 Oct 2024 01:46:06 +0000 (09:46 +0800)]
Remove unused <random> import in cmd.cpp

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Fri, 11 Oct 2024 02:54:56 +0000 (02:54 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7066 from nextcloud/ci/addGithubActionMacOsTimeout
Matthieu Gallien [Thu, 10 Oct 2024 14:19:30 +0000 (16:19 +0200)]
Merge pull request #7066 from nextcloud/ci/addGithubActionMacOsTimeout

try to increase timeout of github actions for macOS

22 months agoCI fix warning: inkscape was renamed to homebrew/cask/inkscape
Matthieu Gallien [Tue, 3 Sep 2024 14:00:39 +0000 (16:00 +0200)]
CI fix warning: inkscape was renamed to homebrew/cask/inkscape

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agono longer use deprecated Craft command line option
Matthieu Gallien [Tue, 3 Sep 2024 11:48:43 +0000 (13:48 +0200)]
no longer use deprecated Craft command line option

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agotry to increase timeout of github actions for macOS
Matthieu Gallien [Tue, 3 Sep 2024 07:48:14 +0000 (09:48 +0200)]
try to increase timeout of github actions for macOS

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7290 from nextcloud/bugfix/improveLogsAgainFromUsingThem
Matthieu Gallien [Thu, 10 Oct 2024 13:08:33 +0000 (15:08 +0200)]
Merge pull request #7290 from nextcloud/bugfix/improveLogsAgainFromUsingThem

Cleaning logs

22 months agoimprove log when too many deleted files are detected
Matthieu Gallien [Thu, 10 Oct 2024 08:38:00 +0000 (10:38 +0200)]
improve log when too many deleted files are detected

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoremove info level output from activity list model: not so usefull
Matthieu Gallien [Thu, 10 Oct 2024 08:36:16 +0000 (10:36 +0200)]
remove info level output from activity list model: not so usefull

they just are printed when everything is working fine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoremove not so usefull log output
Matthieu Gallien [Thu, 10 Oct 2024 08:04:51 +0000 (10:04 +0200)]
remove not so usefull log output

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7289 from nextcloud/bugfix/removeQStringArgWarning
Matthieu Gallien [Thu, 10 Oct 2024 12:35:12 +0000 (14:35 +0200)]
Merge pull request #7289 from nextcloud/bugfix/removeQStringArgWarning

remove extra argument from QString::arg: string has only 1 placeholder

22 months agoremove extra argument from QString::arg: string has only 1 placeholder
Matthieu Gallien [Thu, 10 Oct 2024 07:57:07 +0000 (09:57 +0200)]
remove extra argument from QString::arg: string has only 1 placeholder

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Thu, 10 Oct 2024 02:47:56 +0000 (02:47 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7284 from nextcloud/update/readmes
Camila Ayres [Tue, 8 Oct 2024 14:15:05 +0000 (16:15 +0200)]
Merge pull request #7284 from nextcloud/update/readmes

Small READMEs fix/updates

22 months agoFix permanent link to mac-crafter README.
Camila Ayres [Tue, 8 Oct 2024 12:38:03 +0000 (14:38 +0200)]
Fix permanent link to mac-crafter README.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoFix the list of steps order.
Camila Ayres [Tue, 8 Oct 2024 12:31:50 +0000 (14:31 +0200)]
Fix the list of steps order.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoMerge pull request #7252 from nextcloud/add/readmes
Camila Ayres [Tue, 8 Oct 2024 12:32:48 +0000 (14:32 +0200)]
Merge pull request #7252 from nextcloud/add/readmes

Add README about mac-crafter.

22 months agoMatch the universal build instructions with what we actually do with mac-crafter...
Claudio Cambra [Tue, 8 Oct 2024 02:41:33 +0000 (10:41 +0800)]
Match the universal build instructions with what we actually do with mac-crafter and make_universal

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoClarify architecture setting has automatic default in mac-crafter readme
Claudio Cambra [Tue, 8 Oct 2024 02:40:58 +0000 (10:40 +0800)]
Clarify architecture setting has automatic default in mac-crafter readme

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoSimplify build instructions in mac-crafter README
Claudio Cambra [Tue, 8 Oct 2024 02:40:30 +0000 (10:40 +0800)]
Simplify build instructions in mac-crafter README

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
22 months agoAdd note about craft-master in the main README.
Camila Ayres [Tue, 1 Oct 2024 15:22:39 +0000 (17:22 +0200)]
Add note about craft-master in the main README.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoAdd README about mac-crafter.
Camila Ayres [Tue, 1 Oct 2024 15:13:25 +0000 (17:13 +0200)]
Add README about mac-crafter.

Signed-off-by: Camila Ayres <hello@camilasan.com>
22 months agoMerge pull request #7282 from nextcloud/bugfix/catchFilesystemExceptions
Matthieu Gallien [Tue, 8 Oct 2024 11:47:48 +0000 (13:47 +0200)]
Merge pull request #7282 from nextcloud/bugfix/catchFilesystemExceptions

properly catch std::filesystem exceptions

22 months agoproperly catch std::filesystem exceptions
Matthieu Gallien [Tue, 8 Oct 2024 09:51:55 +0000 (11:51 +0200)]
properly catch std::filesystem exceptions

will prevent std::terminate from being called with uncatched exceptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoFix(l10n): Update translations from Transifex
Nextcloud bot [Tue, 8 Oct 2024 02:44:32 +0000 (02:44 +0000)]
Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
22 months agoMerge pull request #7271 from nextcloud/bugfix/fixPermanentDeleteLogCrash
Matthieu Gallien [Mon, 7 Oct 2024 15:04:35 +0000 (17:04 +0200)]
Merge pull request #7271 from nextcloud/bugfix/fixPermanentDeleteLogCrash

ensure log context category is valid before reading it

22 months agoensure log context category is valid before reading it
Matthieu Gallien [Mon, 7 Oct 2024 12:16:50 +0000 (14:16 +0200)]
ensure log context category is valid before reading it

category of logs accessed via log context can be null
in such a case, strcmp will crash

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7270 from nextcloud/bugfix/useQmlFusionOnWindows
Matthieu Gallien [Mon, 7 Oct 2024 13:31:00 +0000 (15:31 +0200)]
Merge pull request #7270 from nextcloud/bugfix/useQmlFusionOnWindows

Bugfix/use qml fusion on windows

22 months agoremove hard coded white color in elements of folder wizard
Matthieu Gallien [Mon, 7 Oct 2024 12:04:48 +0000 (14:04 +0200)]
remove hard coded white color in elements of folder wizard

fix broken white backgrounds in folder wizard when using Windows dark
mode

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoswitch folder wizar to modern style to avoid borken windows dark mode
Matthieu Gallien [Mon, 7 Oct 2024 11:51:41 +0000 (13:51 +0200)]
switch folder wizar to modern style to avoid borken windows dark mode

the QWizard AeroStyle style is broken on windows dark mode, switch to
ModernStyle that is working fine

see upstream Qt bug: https://bugreports.qt.io/browse/QTBUG-123853

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoqml Windows native style is broken on dark mode: switch to Fusion
Matthieu Gallien [Mon, 7 Oct 2024 08:40:41 +0000 (10:40 +0200)]
qml Windows native style is broken on dark mode: switch to Fusion

we will temporarily be using Fusion generic desktop style

Close https://github.com/nextcloud/desktop/issues/7215

see upstream Qt bug
https://bugreports.qt.io/browse/QTBUG-113469?focusedId=724929&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-724929

they apparently do not plan to fix Windows qml style to support dark
mode on Windows 11

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoMerge pull request #7263 from nextcloud/bugfix/cleanUpLogs
Matthieu Gallien [Mon, 7 Oct 2024 12:27:04 +0000 (14:27 +0200)]
Merge pull request #7263 from nextcloud/bugfix/cleanUpLogs

remove too verbose logs during discovery

22 months agodowngrade severity level of logs during propagation
Matthieu Gallien [Thu, 3 Oct 2024 16:42:11 +0000 (18:42 +0200)]
downgrade severity level of logs during propagation

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
22 months agoremove internal logs in propagation scheduler: not usefull
Matthieu Gallien [Thu, 3 Oct 2024 16:32:45 +0000 (18:32 +0200)]
remove internal logs in propagation scheduler: not usefull

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>