create a permanent log of delete actions

will log all deletions with the result of the discovery by the sync
enginre

should enable analyze even long time after such a delete occured

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7247 from nextcloud/docs/noid/issueTemplates

docs: Update template to match org-templates

docs: Update template to match org-templates

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>

Merge pull request #7116 from nextcloud/feature/warnOfManyDeleteInstructions

count the files deletion and warn if threshold is exceeded

count the files deletion and warn if threshold is exceeded

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7232 from nextcloud/bugfix/webengineprocess-crash-mac

Fix QtWebEngineProcess crash on macOS when building with mac-crafter

Codesign webengineprocess with correct entitlements on macOS with mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7163 from nextcloud/feature/mac-crafter-override-server-url

Add support for the new craft blueprint options relating to override server urls

Add support for the new craft blueprint options relating to override server urls

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7220 from nextcloud/tidy/improvePlatformDetectionUtilityFunctions

use constexpr function for platform detection

use constexpr function for platform detection

should decrease the cost of their usage when compared to preprocessor
conditional directives

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #6871 from nextcloud/bugfix/trailing-space

Only check for leading/trailing space for files on Windows.

Use preprocessor directives in tests.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix tests for trailing spaces on Linux.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Add test testCreateLocalPathsWithLeadingAndTrailingSpaces_syncOnSupportingOs.

- Fix discovery tests for files with invalid names.
- Now leading/trailing spaces trigger an error only on Windows.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Only check leading/trailing spaces for files on Windows.

Fix for #6807.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7200 from nextcloud/bugfix/useTransferTimeoutFromAccessManager

disable our code for network timeout

disable our code for network timeout

seems we have an issue with Windows and QTimer instances used to detect
network timeout

workaround, find cause of https://github.com/nextcloud/desktop/issues/7184

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7210 from nextcloud/bugfix/server-url

Validate input of APPLICATION_SERVER_URL.

Validate input of APPLICATION_SERVER_URL.

Tries to clean double quotes and output JSON parse error.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7142 from nextcloud/bugfix/native-ui

Fix alignment and size of buttons.

Fix alignment and size of buttons.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7216 from nextcloud/ci/removeObsoleteDockerWindowsCrossCompilation

remove obsolete not working docker image for windows compilation

remove obsolete not working docker image for windows compilation

that image was supposed to be usable for cross compilation from Linux to
build a Windows release

probably never worked

not working anymore but creating confusion

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7161 from nextcloud/bugfix/changeDefaultChunkSize

changing default chunk size to 100MB

changing default chunk size to 100MB

goal is to have better performance and uniform behavior between all files clients

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7208 from nextcloud/bugfix/missingUnlockCommand

Bugfix/missing unlock command

lock token should be sent via webdav only for token lock type

to be able to modify a locked file using token lock, we must sent it
with webdav requests

this must not be sent if the file is locked but the lock type is not a
token lock

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

clarify when desktop client should offer to unlock a file

a file can be unlocked when:

 * the lock is an user lock from the current user
 * the lock is a token lock from the current desktop files client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7167 from nextcloud/bugfix/appimage

Use version of linuxdeploy-plugin-qt from PR in the project.

Use version of linuxdeploy-plugin-qt from PR in the project.

Fix for #7128.

See https://github.com/linuxdeploy/linuxdeploy-plugin-qt/pull/186.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7199 from nextcloud/bugfix/startupQmlOnWindows

Bugfix/startup qml on windows

add seemingly needed qml import path

will hopefuly make the qml engine search inside install dir within qml
sub folder

Close #7156

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

rename our Window component to MainWindow to not use an existing name

we import QtQuick module that also define Window component name

to avoid any ambiguity, just use a different name on our side

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

change the order of imports in Window.qml

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Merge pull request #7193 from nextcloud/bugfix/fixUploadLockedFiles

Bugfix/fix upload locked files

provide LOCK token when uploading a single file via PUT

for simple webDAV upload via PUT verb, provide the needed lock token

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

if a file is locked/ provide token during upload

will add needed lock token in final move headers for chunk upload

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

receive and decode tokens for locks

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

store lock tokens in database

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7196 from nextcloud/nickvergessen-patch-1

Update issue template config.yml

Update config.yml

Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>

Merge pull request #7144 from nextcloud/update/mds

Update README.

Update README.

Signed-off-by: Camila Ayres <hello@camilasan.com>

Merge pull request #7160 from nextcloud/feature/hard-coded-servers

Add ability to provide multiple hardcoded server URLs via CMake define

Ensure we hide the combo box for multiple override servers by default

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use a raw string in config.h.in for application server url

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Display server URL in multi-server enforced combo box

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not automatically validate server URL when enforced servers is active but have multiple servers

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use url method instead of text field contents as url when deciding on error string in setup page

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

If using multi-server override url and forcing it then provide combo box selection url as url in setup page

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Accept combo box selection as completed state in setup page

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Show or hide multi-server overrides or text field depending on type of override url

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Do not apply override server url as account url if this is a multi-server JSON string

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add property for detecting of application override server url is in fact a JSON array string describing multiple servers

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add combo box to setup page UI

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7195 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.13.1

Bump cpp-linter/cpp-linter-action from 2.13.0 to 2.13.1

Bump cpp-linter/cpp-linter-action from 2.13.0 to 2.13.1

Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.13.0 to 2.13.1.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.13.0...v2.13.1)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7182 from nextcloud/bugfix/revert-always-use-http2

Revert always enable http2

Revert "Merge pull request #6986 from nextcloud/feature/alwaysEnableHttp2"

This reverts commit 5baec6f128734bc8ed0845ac7a8c269904c1027e, reversing
changes made to ab06ecbc4d02c4b18174e8280a8f242da9ea7970.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7172 from nextcloud/bugfix/min-version-macos

Fix issues with minimum system versions and deployment targets on macOS

Remove now unneeded deployment target checks in CMake

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Downgrade deployment target variables to 11.0 as 12.0 is not necessary

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Bump up minimum system version to 11.0 on macOS (required by Qt 6)

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7173 from nextcloud/feature/mac-crafter-package

Add packaging capability to Mac Crafter

Add note about packaging tooling in mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add package command for mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Make specific step functions for packaging fileprivate in mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Move packaging procedures into a single function in mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Create convenience function to convert architecture string to craft target string

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix work build path used in mac crafter packaging stage

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Remove unused sparkleFile var

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Use appName for packaging step in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add logging to packaging procedures in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability to build and sign sparkle tbz from mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability to notarise package from mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add ability to sign pkg from mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add flag to build pkg in mac-crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add buildPackage function to mac crafter

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Merge pull request #7164 from nextcloud/bugfix/mac-crafter-exit-correctly

Correctly kill processes spawned by mac-crafter if mac-crafter quits/is killed/etc

Correctly kill processes spawned by mac-crafter if mac-crafter quits/is killed/etc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #7138 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.13.0

Bump cpp-linter/cpp-linter-action from 2.12.1 to 2.13.0

Bump cpp-linter/cpp-linter-action from 2.12.1 to 2.13.0

Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.12.1 to 2.13.0.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.12.1...v2.13.0)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Fix(l10n): Update translations from Transifex

Signed-off-by: Nextcloud bot <bot@nextcloud.com>

Merge pull request #6717 from nextcloud/bugfix/fixVfsFolderStateWhenRemoteMoveIsForbidden

Bugfix/fix vfs folder state when remote move is forbidden

as a last resort, try to update VFS metadata of folders when discovered

when doing local discovery, it is possible that files or folders may be
discovered with VFS metadata not up to date (i.e. placeholder file not
set in sync)

in such case, generate a propagation instruction to set them in sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>